You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-11-21] [$500] Security - Status bar color does not match with header #27453
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.70.2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
changed the title [-]Security - Status bar color does not match with header[/-][+][$500] Security - Status bar color does not match with header[/+]on Sep 14, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@burczu] The PR that introduced the bug has been identified. Link to the PR:
I'm not sure how to treat this one because the issue was actually fixed somewhere else, I think here: #27483, and this issue and related PR actually does not fix anything (it just switches from using withLocalize to useLocalize in few places, so it's unrelated).
[@burczu] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@burczu] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@burczu] Determine if we should create a regression test for this bug.
[@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Okay cool! I'm curious if there's something in the dev lifecycle, like in the PR checklist or something for ensuring the status bar colour matches when introducing a new animation?
As for the regression test, we have this one below. So I was thinking of adding a couple of items bolded to accommodate this:
Navigate to Settings > Security > Two Factor Authentication (2FA)
[On Android/iOS] Verify the status bar animates to light blue (should be the same as the header of the page)
Verify the first step is to save the recovery codes
Click on Next
Verify there's an error indicating the user to copy/download the codes before continuing
Click on "Copy" and save the codes somewhere (for next test case)
Verify the "Next" button is enabled if the user clicks on "Copy"
Click Next
Verify the next step is to verify the authenticator app
Verify a QR code is displayed to use for the authenticator app
Note: We recommend Google Authenticator to execute these tests, can be downloaded from Google Play Store or the AppStore
Enter a incorrect 6 digit code
Verify an error is displayed and a incorrect 6-digit code is entered
Open your authenticator app and scan the QR or paste the secret key to set up the authenticator
Enter the 6 digit code provided by the authenticator app
Click Next
Verify a success screen is displayed and that it contains an animation
Navigate back to the main settings page
Verify the status bar animates back to dark green (should be the same as header of the page)
Okay cool! I'm curious if there's something in the dev lifecycle, like in the PR checklist or something for ensuring the status bar colour matches when introducing a new animation?
I don't think so, but I think it's quite rare when we change this particular part of the app. Maybe we should add something like I verified that the feature matches the design or something to the PR checklist, because I guess, this was on designs for this feature? But probably this won't be enough because this type of issue might be introduced by PR's fixing some other bugs that has no related designs...
Maybe we should add something like I verified that the feature matches the design or something to the PR checklist
Hm yeah, I think it's pretty generic -- we'd want to offer some direction. We do also have a note somewhere to add the design label for design changes. Okay, maybe we leave it for now then 👍
Activity
[-]Security - Status bar color does not match with header[/-][+][$500] Security - Status bar color does not match with header[/+]melvin-bot commentedon Sep 14, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01217477790895e67d
melvin-bot commentedon Sep 14, 2023
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 14, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Sep 14, 2023
Triggered auto assignment to @sophiepintoraetz (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.melvin-bot commentedon Sep 14, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (
External)ishpaul777 commentedon Sep 14, 2023
Proposal
Problem
Security - Status bar color does not match with header.
Root Cause
We are using Route instead of route name for defining the color for Header. https://github.com/Expensify/App/blob/main/src/styles/themes/default.js#L90
Changes
Add and new variable SECURITY under SETTINGS as Settings_Security.
https://github.com/Expensify/App/blob/8fcb69eed005554030734060e6e56dee218d043a/src/SCREENS.ts
use
SCREENS.SETTINGS.SECURITYhere instead ofROUTES.SETTINGS_SECURITYalso replace allSettings_Securitywith variable.also we need to do the same for
I_KNOW_A_TEACHERroutetrjExpensify commentedon Sep 14, 2023
Commented on the issue that implemented this: #26775 (comment)
35 remaining items
trjExpensify commentedon Nov 27, 2023
Sounds good!
trjExpensify commentedon Nov 29, 2023
Any luck? :)
burczu commentedon Dec 1, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
I'm not sure how to treat this one because the issue was actually fixed somewhere else, I think here: #27483, and this issue and related PR actually does not fix anything (it just switches from using
withLocalizetouseLocalizein few places, so it's unrelated).But the issue itself was introduced by the new feature (link to PR).
#26784 (review)
Regression test proposal in a separate comment.
burczu commentedon Dec 1, 2023
Regression Test Proposal
roryabraham commentedon Dec 1, 2023
LGTM 👍🏼
trjExpensify commentedon Dec 4, 2023
Okay cool! I'm curious if there's something in the dev lifecycle, like in the PR checklist or something for ensuring the status bar colour matches when introducing a new animation?
As for the regression test, we have this one below. So I was thinking of adding a couple of items bolded to accommodate this:
I'll float that with Applause here.
trjExpensify commentedon Dec 4, 2023
In the meantime, @gadhiyamanan sent you an offer for the bug report.
gadhiyamanan commentedon Dec 4, 2023
@trjExpensify offer accepted, thanks!
trjExpensify commentedon Dec 4, 2023
@gadhiyamanan - paid!
burczu commentedon Dec 4, 2023
@trjExpensify regarding this:
I don't think so, but I think it's quite rare when we change this particular part of the app. Maybe we should add something like
I verified that the feature matches the designor something to the PR checklist, because I guess, this was on designs for this feature? But probably this won't be enough because this type of issue might be introduced by PR's fixing some other bugs that has no related designs...trjExpensify commentedon Dec 6, 2023
Hm yeah, I think it's pretty generic -- we'd want to offer some direction. We do also have a note somewhere to add the design label for design changes. Okay, maybe we leave it for now then 👍
Everyone is settled up here, closing!