Skip to content

[HOLD for payment 2023-09-29] Tests in the App repo are not passing when we use onyx version with Batched updates  #27470

Closed

Description

@Szymon20000

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Apply onyx batching feature and run rpm run test

Expected Result:

All tests should be passing

Actual Result:

Some of them are failing

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 14, 2023
  2. melvin-bot commented on Sep 14, 2023

    @melvin-bot

    Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Sep 14, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. melvin-bot commented on Sep 15, 2023

    @melvin-bot

    Triggered auto assignment to @marcaaron, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  5. marcaaron commented on Sep 15, 2023

    @marcaaron
    Contributor

    Gonna take the Bug label off, but happy to help review this PR.

  6. removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 15, 2023
  7. marcaaron commented on Sep 19, 2023

    @marcaaron
    Contributor

    I believe we are waiting for a few regressions to be addressed. Margelo is traveling atm so probably this might take a couple days to close out. @tgolen has an approving review on the PR. I'm going to give the code another look now.

  8. 17 remaining items

  9. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 2, 2023
  10. melvin-bot commented on Oct 2, 2023

    @melvin-bot

    Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  11. melvin-bot commented on Oct 2, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  12. marcaaron commented on Oct 2, 2023

    @marcaaron
    Contributor

    @tjferriss This one is on production already - we just need help paying out @allroundexperts for the help in testing / reviewing.

  13. tjferriss commented on Oct 2, 2023

    @tjferriss
    Contributor

    @allroundexperts I've sent you an offer via Upworks for payment: https://www.upwork.com/jobs/~01b16f58f5af83ea0b

  14. allroundexperts commented on Oct 3, 2023

    @allroundexperts
    Contributor

    @tjferriss I get paid through the App. Can you please write a payment summary and I'll request the amount!

  15. tjferriss commented on Oct 3, 2023

    @tjferriss
    Contributor

    Payment summary:

    Contributor+ Review: @allroundexperts $500

  16. allroundexperts commented on Oct 3, 2023

    @allroundexperts
    Contributor

    Requested. Thanks @tjferriss!

  17. JmillsExpensify commented on Oct 5, 2023

    @JmillsExpensify
    Contributor

    $500 payment approved for @allroundexperts based on BZ summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions