Skip to content

[HOLD for payment 2023-09-29] [$500] Workspace details don't show up in participants selector #27510

Closed

Description

@thienlnam

Clean up for: #25564

When you select a workspace in the new request money flow, the workspace details do not show up.

image

  1. Request money
  2. Select a workspace
  3. Notice that it doesn't contain the details
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018607cb9d54e7235a
  • Upwork Job ID: 1702632412164861952
  • Last Price Increase: 2023-09-15
  • Automatic offers:
    • situchan | Reviewer | 26745052
    • bernhardoj | Contributor | 26745057

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 15, 2023
  2. melvin-bot commented on Sep 15, 2023

    @melvin-bot

    Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Sep 15, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 15, 2023
  5. changed the title [-]Workspace details don't show up in participants selector[/-] [+][$500] Workspace details don't show up in participants selector[/+] on Sep 15, 2023
  6. melvin-bot commented on Sep 15, 2023

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 15, 2023
  8. melvin-bot commented on Sep 15, 2023

    @melvin-bot

    Current assignee @sophiepintoraetz is eligible for the External assigner, not assigning anyone new.

  9. melvin-bot commented on Sep 15, 2023

    @melvin-bot

    Current assignee @situchan is eligible for the External assigner, not assigning anyone new.

  10. studentofcoding commented on Sep 15, 2023

    @studentofcoding
    Contributor

    Clean up for: #25564

    When you select a workspace in the new request money flow, the workspace details do not show up.

    image

    1. Request money
    2. Select a workspace
    3. Notice that it doesn't contain the details

    Upwork Automation - Do Not Edit

    Hey @thienlnam, the Image is broken, can you re-attach again? thanks!

  11. situchan commented on Sep 15, 2023

    @situchan
    Contributor
    Screenshot 2023-09-15
  12. 25 remaining items

  13. changed the title [-][$500] Workspace details don't show up in participants selector[/-] [+][HOLD for payment 2023-09-29] [$500] Workspace details don't show up in participants selector[/+] on Sep 22, 2023
  14. melvin-bot commented on Sep 22, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Sep 22, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.72-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-09-29. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  16. melvin-bot commented on Sep 22, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@situchan] The PR that introduced the bug has been identified. Link to the PR:
    • [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@situchan] Determine if we should create a regression test for this bug.
    • [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  17. sophiepintoraetz commented on Oct 2, 2023

    @sophiepintoraetz
    Contributor

    Payouts due:

    Issue Reporter: N/A
    Contributor: $750 @bernhardoj
    Contributor+: $750 @situchan (once you have completed the BZ checklist, I'll release payment!)

    Eligible for 50% #urgency bonus? Y

  18. situchan commented on Oct 2, 2023

    @situchan
    Contributor

    No regression. This was clean-up of #25564 in Simplify Global Create project.
    I think regression test will be part of https://github.com/Expensify/Expensify/issues/318720

  19. sophiepintoraetz commented on Oct 2, 2023

    @sophiepintoraetz
    Contributor

    Ah good point - @thienlnam - can you confirm there is a regression test included for this bug in https://github.com/Expensify/Expensify/issues/318720?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions