You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] Desktop - Unread count is incorrect when joining a thread #27512
Clicked on a thread made by other users that already had comments
Didn't add any comment
Left the thread
The thread disappeared from LHN
Expected Result:
New messages inside those threads should not be counted on my unread indications
Actual Result:
New messages on the threads that I can't see on my LHN are counting towards the unread counter on the app icon
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.67-1 Reproducible in staging?: n/a Reproducible in production?: n./a If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
changed the title [-]Desktop - Unread count is incorrect when joining a thread[/-][+][$500] Desktop - Unread count is incorrect when joining a thread[/+]on Sep 19, 2023
📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
@roryabraham sorry I don't have access to that repo for FixAccount so I don't know exactly how it's related to OpenApp. But I think that will work. If the user's last chat is the thread where there's no comment, the OpenReport will still be called. So If OpenApp clears it before, it won't cause any issue.
@garrettmknight@roryabraham Should we process payment for this issue? We spent lots of effort in the PR to discuss and implement my main solution and everything is almost done. Additionally, the PR that fixed this issue is the same as my alternative solution.
Activity
melvin-bot commentedon Sep 15, 2023
Triggered auto assignment to @garrettmknight (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 15, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)roryabraham commentedon Sep 19, 2023
This is super annoying and front-end fixable so I'm going to make it external
[-]Desktop - Unread count is incorrect when joining a thread[/-][+][$500] Desktop - Unread count is incorrect when joining a thread[/+]melvin-bot commentedon Sep 19, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01a81e245f41f24d05
melvin-bot commentedon Sep 19, 2023
Current assignee @garrettmknight is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Sep 19, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (
External)7 remaining items
melvin-bot commentedon Sep 19, 2023
📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
dukenv0307 commentedon Sep 19, 2023
@roryabraham sorry I don't have access to that repo for
FixAccountso I don't know exactly how it's related toOpenApp. But I think that will work. If the user's last chat is the thread where there's no comment, theOpenReportwill still be called. So IfOpenAppclears it before, it won't cause any issue.I agree that edge case can be handled separately.
dukenv0307 commentedon Sep 20, 2023
@fedirjh The PR is ready for review
garrettmknight commentedon Oct 11, 2023
Bumped the PR to investigate the checks that weren't successful.
dukenv0307 commentedon Oct 30, 2023
@garrettmknight @roryabraham Should we process payment for this issue? We spent lots of effort in the PR to discuss and implement my main solution and everything is almost done. Additionally, the PR that fixed this issue is the same as my alternative solution.
garrettmknight commentedon Nov 2, 2023
Since plenty of work was done here and we got pretty deep into the PR I think this counts for pay.
Summary of payments on this issue:
garrettmknight commentedon Nov 2, 2023
@fedirjh accept the new offer and I'll pay out.
fedirjh commentedon Nov 2, 2023
@garrettmknight Done.
garrettmknight commentedon Nov 2, 2023
All paid up.