Skip to content

[$500] Desktop - Unread count is incorrect when joining a thread #27512

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Clicked on a thread made by other users that already had comments
  2. Didn't add any comment
  3. Left the thread
  4. The thread disappeared from LHN

Expected Result:

New messages inside those threads should not be counted on my unread indications

Actual Result:

New messages on the threads that I can't see on my LHN are counting towards the unread counter on the app icon

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.67-1
Reproducible in staging?: n/a
Reproducible in production?: n./a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

n/a

Expensify/Expensify Issue URL:
Issue reported by: @danieldoglas
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694447504126939

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01a81e245f41f24d05
  • Upwork Job ID: 1703973226245242880
  • Last Price Increase: 2023-09-19
  • Automatic offers:
    • fedirjh | Reviewer | 26746291
    • dukenv0307 | Contributor | 26746293

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 15, 2023
  2. melvin-bot commented on Sep 15, 2023

    @melvin-bot

    Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Sep 15, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. roryabraham commented on Sep 19, 2023

    @roryabraham
    Contributor

    This is super annoying and front-end fixable so I'm going to make it external

  5. self-assigned this
    on Sep 19, 2023
  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 19, 2023
  7. changed the title [-]Desktop - Unread count is incorrect when joining a thread[/-] [+][$500] Desktop - Unread count is incorrect when joining a thread[/+] on Sep 19, 2023
  8. melvin-bot commented on Sep 19, 2023

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 19, 2023
  10. melvin-bot commented on Sep 19, 2023

    @melvin-bot

    Current assignee @garrettmknight is eligible for the External assigner, not assigning anyone new.

  11. melvin-bot commented on Sep 19, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

  12. 7 remaining items

  13. melvin-bot commented on Sep 19, 2023

    @melvin-bot

    📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job
    Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  14. dukenv0307 commented on Sep 19, 2023

    @dukenv0307
    Contributor

    @roryabraham sorry I don't have access to that repo for FixAccount so I don't know exactly how it's related to OpenApp. But I think that will work. If the user's last chat is the thread where there's no comment, the OpenReport will still be called. So If OpenApp clears it before, it won't cause any issue.

    I agree that edge case can be handled separately.

  15. dukenv0307 commented on Sep 20, 2023

    @dukenv0307
    Contributor

    @fedirjh The PR is ready for review

  16. garrettmknight commented on Oct 11, 2023

    @garrettmknight
    Contributor

    Bumped the PR to investigate the checks that weren't successful.

  17. dukenv0307 commented on Oct 30, 2023

    @dukenv0307
    Contributor

    @garrettmknight @roryabraham Should we process payment for this issue? We spent lots of effort in the PR to discuss and implement my main solution and everything is almost done. Additionally, the PR that fixed this issue is the same as my alternative solution.

  18. garrettmknight commented on Nov 2, 2023

    @garrettmknight
    Contributor

    Since plenty of work was done here and we got pretty deep into the PR I think this counts for pay.

    Summary of payments on this issue:

  19. garrettmknight commented on Nov 2, 2023

    @garrettmknight
    Contributor

    @fedirjh accept the new offer and I'll pay out.

  20. fedirjh commented on Nov 2, 2023

    @fedirjh
    Contributor
  21. garrettmknight commented on Nov 2, 2023

    @garrettmknight
    Contributor

    All paid up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions