You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-09-27] Web - search field or new group field remain focused after CTRL + K, CTRL + J or CTRL + SHIFT + K, CTRL + J #27516
Observe the search or new group field which is focused
Expected Result:
The search or new group field should not be focused since the keyboard shortcut modal is over the search RHN
Actual Result:
The search or new group field is focused and we can type when the keyboard shortcut is over the search or new group RHN
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.70.5 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Activity
OSBotify commentedon Sep 15, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Sep 15, 2023
Triggered auto assignment to @nkuoch (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.nkuoch commentedon Sep 15, 2023
Probably not a deploy blocker, but definitely a regression (happening on staging but not production) - trying to find the culprit
situchan commentedon Sep 15, 2023
@nkuoch I confirmed that the regression came from #24316. Shall we revert this?
nkuoch commentedon Sep 15, 2023
Yes, as the original fix isn't fixing anything major, let's revert and ask them to redo with the new bug in mind
situchan commentedon Sep 15, 2023
I can raise PR if you want.
situchan commentedon Sep 15, 2023
I agree to revert that PR. It also fixes another deploy blocker - #27519.
melvin-bot commentedon Sep 15, 2023
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
20 remaining items
nkuoch commentedon Sep 28, 2023
@stephanieelliott
stephanieelliott commentedon Sep 29, 2023
@misgana96 I extended the offer to you on Upwork, please accept when you get a chance! https://www.upwork.com/jobs/~01b782e555a9fce472
misgana96 commentedon Sep 29, 2023
Offer accepted. Thank you
melvin-bot commentedon Oct 2, 2023
@nkuoch, @stephanieelliott Whoops! This issue is 2 days overdue. Let's get this updated quick!
stephanieelliott commentedon Oct 4, 2023
All paid!
misgana96 commentedon Oct 4, 2023
Received. Thank you