You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-27] [$500] Android - Keyboard stays open when getting back to amount input page #27543
Click on the currency sign & try to select any currency asap
Try few times
Observe the keyboard stays open few times.
Expected Result:
The keyboard should be closed on the amount input page.
Actual Result:
The keyboard is not closed on the amount input page.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.70.2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
changed the title [-]Android - Keyboard stays open when getting back to amount input page[/-][+][$500] Android - Keyboard stays open when getting back to amount input page[/+]on Sep 15, 2023
Please re-state the problem that we are trying to solve in this issue.
Android - Keyboard stays open when getting back to amount input page
What is the root cause of that problem?
The root cause is the use of keyboardShouldPersistTaps="always" on SectionList used in the BaseOptionsList. This property essentially dictates that the keyboard should remain open even after a tap on the screen (like selecting an any result).
Please re-state the problem that we are trying to solve in this issue.
The keyboard is not closed on the amount input page.
What is the root cause of that problem?
We are using keyboardShouldPersistTaps="always" in BaseOptionsList. This basically means that Keyboard should stay visible after a tap, and "always" means it will not dismiss automatically. This is the root cause.
What changes do you think we should make in order to solve the problem?
We need to add Keyboard.dismiss() right AFTER navigating with back button AND navigating using confirmCurrencySelection function.
changed the title [-][$500] Android - Keyboard stays open when getting back to amount input page[/-][+][HOLD for payment 2023-10-27] [$500] Android - Keyboard stays open when getting back to amount input page[/+]on Oct 20, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.87-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-27. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@ArekChr] The PR that introduced the bug has been identified. Link to the PR:
[@ArekChr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@ArekChr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@ArekChr] Determine if we should create a regression test for this bug.
[@ArekChr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
[-]Android - Keyboard stays open when getting back to amount input page[/-][+][$500] Android - Keyboard stays open when getting back to amount input page[/+]melvin-bot commentedon Sep 15, 2023
Triggered auto assignment to @sophiepintoraetz (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 15, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01c8a396e607bd78b9
melvin-bot commentedon Sep 15, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Sep 15, 2023
Triggered auto assignment to @strepanier03 (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.melvin-bot commentedon Sep 15, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ArekChr (
External)kbecciv commentedon Sep 15, 2023
Proposal by: @Krishna2323
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694209564341799
Proposal
Please re-state the problem that we are trying to solve in this issue.
Android - Keyboard stays open when getting back to amount input page
What is the root cause of that problem?
The root cause is the use of keyboardShouldPersistTaps="always" on SectionList used in the BaseOptionsList. This property essentially dictates that the keyboard should remain open even after a tap on the screen (like selecting an any result).
App/src/components/OptionsList/BaseOptionsList.js
Lines 225 to 248 in bbc2342
What changes do you think we should make in order to solve the problem?
We need to dismiss keyboard by using Keyboard.dismiss() before navigating with back button or navigating using confirmCurrencySelection function.
App/src/pages/iou/IOUCurrencySelection.js
Lines 79 to 92 in bbc2342
I also tried to dismiss the keyboard using cleanup function but it didn't worked.
useEffect(() => () => Keyboard.dismiss(), []);
Result
PiyushChandra17 commentedon Sep 15, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
The keyboard is not closed on the amount input page.
What is the root cause of that problem?
We are using
keyboardShouldPersistTaps="always"in BaseOptionsList. This basically means that Keyboard should stay visible after a tap, and "always" means it will not dismiss automatically. This is the root cause.What changes do you think we should make in order to solve the problem?
We need to add
Keyboard.dismiss()right AFTER navigating with back button AND navigating using confirmCurrencySelection function.App/src/pages/iou/IOUCurrencySelection.js
Lines 79 to 92 in 191bda1
What alternative solutions did you explore? (Optional)
NA
59 remaining items
Krishna2323 commentedon Oct 16, 2023
@ArekChr, PR ready for review.
melvin-bot commentedon Oct 18, 2023
🎯 ⚡️ Woah @ArekChr / @Krishna2323, great job pushing this forwards! ⚡️
The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉
On to the next one 🚀
[-][$500] Android - Keyboard stays open when getting back to amount input page[/-][+][HOLD for payment 2023-10-27] [$500] Android - Keyboard stays open when getting back to amount input page[/+]melvin-bot commentedon Oct 20, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 20, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.87-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-27. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Oct 20, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
ArekChr commentedon Oct 23, 2023
sophiepintoraetz commentedon Oct 26, 2023
Paid!