You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for C+ payment via Newdot] [$500] Dev: mWeb - Offline message not positioned at bottom in private notes #27590
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: Dev 1.3.70.5 Reproducible in staging?: no Reproducible in production?: no If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
When offline OfflineIndicator will show below the content. So here the content does not take up the entire screen, leading to the offline message not being at the bottom.
What changes do you think we should make in order to solve the problem?
We should let the content take up the entire screen.
changed the title [-]Dev: mWeb - Offline message not positioned at bottom in private notes[/-][+][$500] Dev: mWeb - Offline message not positioned at bottom in private notes[/+]on Sep 16, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@eVoloshchak] Determine if we should create a regression test for this bug.
[@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
changed the title [-][HOLD for payment 2023-10-09] [$500] Dev: mWeb - Offline message not positioned at bottom in private notes[/-][+][HOLD for BugZero checklist and C+ payment via Newdot] [$500] Dev: mWeb - Offline message not positioned at bottom in private notes[/+]on Oct 10, 2023
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: there's already a reviewer checklist item to catch exactly these types of bugs, I don't think an additional discussion is needed
changed the title [-][HOLD for BugZero checklist and C+ payment via Newdot] [$500] Dev: mWeb - Offline message not positioned at bottom in private notes[/-][+][HOLD for C+ payment via Newdot] [$500] Dev: mWeb - Offline message not positioned at bottom in private notes[/+]on Oct 17, 2023
Activity
ahmedGaber93 commentedon Sep 16, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
offline message not positioned at bottom in private notes
What is the root cause of that problem?
The page content not wrapped with
<View style={[styles.flexGrow1]}>so not fit the available screen heightApp/src/pages/PrivateNotes/PrivateNotesListPage.js
Lines 131 to 135 in 76c1559
What changes do you think we should make in order to solve the problem?
we need this wrap this content with
<View style={[styles.flexGrow1]}>or at leatest_.mapApp/src/pages/PrivateNotes/PrivateNotesListPage.js
Lines 131 to 135 in 76c1559
What alternative solutions did you explore? (Optional)
N/A
namhihi237 commentedon Sep 16, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Offline messages should be positioned at the bottom when the network offline
What is the root cause of that problem?
We have wrapped the
ScreenWrappercontent of PrivateNotesListPage hereApp/src/pages/PrivateNotes/PrivateNotesListPage.js
Lines 120 to 135 in 76c1559
When offline OfflineIndicator will show below the content. So here the content does not take up the entire screen, leading to the offline message not being at the bottom.
What changes do you think we should make in order to solve the problem?
We should let the content take up the entire screen.
What alternative solutions did you explore? (Optional)
N/A
melvin-bot commentedon Sep 16, 2023
Triggered auto assignment to @kadiealexander (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 16, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)[-]Dev: mWeb - Offline message not positioned at bottom in private notes[/-][+][$500] Dev: mWeb - Offline message not positioned at bottom in private notes[/+]melvin-bot commentedon Sep 16, 2023
Job added to Upwork: https://www.upwork.com/jobs/~018108637756bc0d66
melvin-bot commentedon Sep 16, 2023
Current assignee @kadiealexander is eligible for the External assigner, not assigning anyone new.
38 remaining items
kadiealexander commentedon Oct 10, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[-][HOLD for payment 2023-10-09] [$500] Dev: mWeb - Offline message not positioned at bottom in private notes[/-][+][HOLD for BugZero checklist and C+ payment via Newdot] [$500] Dev: mWeb - Offline message not positioned at bottom in private notes[/+]eVoloshchak commentedon Oct 11, 2023
eVoloshchak commentedon Oct 11, 2023
Regression Test Proposal
Do we agree 👍 or 👎
eVoloshchak commentedon Oct 11, 2023
@kadiealexander, shouldn't it be $750 if the bonus is applied?
kadiealexander commentedon Oct 17, 2023
Updated.
[-][HOLD for BugZero checklist and C+ payment via Newdot] [$500] Dev: mWeb - Offline message not positioned at bottom in private notes[/-][+][HOLD for C+ payment via Newdot] [$500] Dev: mWeb - Offline message not positioned at bottom in private notes[/+]eVoloshchak commentedon Oct 17, 2023
Thanks!
Requested the payment
JmillsExpensify commentedon Oct 18, 2023
$750 payment approved for @eVoloshchak based on correct BZ summary.
eVoloshchak commentedon Oct 30, 2023
@kadiealexander, this one can be closed I think