Skip to content

[HOLD for C+ payment via Newdot] [$500] Dev: mWeb - Offline message not positioned at bottom in private notes #27590

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Create a workspace if not created
  2. Go to #admins
  3. Click on header
  4. Go to Private notes
  5. Go offline

Expected Result:

Offline message should be positioned at bottom

Actual Result:

Offline message not positioned at bottom

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: Dev 1.3.70.5
Reproducible in staging?: no
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20230915_185114_Chrome.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694784028569909

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018108637756bc0d66
  • Upwork Job ID: 1703113660113563648
  • Last Price Increase: 2023-09-23
  • Automatic offers:
    • dhairyasenjaliya | Contributor | 26884984
    • gadhiyamanan | Reporter | 26884986

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 16, 2023
  2. ahmedGaber93 commented on Sep 16, 2023

    @ahmedGaber93
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    offline message not positioned at bottom in private notes

    What is the root cause of that problem?

    The page content not wrapped with <View style={[styles.flexGrow1]}> so not fit the available screen height

    {report.isLoadingPrivateNotes && _.isEmpty(lodashGet(report, 'privateNotes', {})) ? (
    <FullScreenLoadingIndicator />
    ) : (
    _.map(privateNotes, (item, index) => getMenuItem(item, index))
    )}

    What changes do you think we should make in order to solve the problem?

    we need this wrap this content with <View style={[styles.flexGrow1]}> or at leatest _.map

    {report.isLoadingPrivateNotes && _.isEmpty(lodashGet(report, 'privateNotes', {})) ? (
    <FullScreenLoadingIndicator />
    ) : (
    _.map(privateNotes, (item, index) => getMenuItem(item, index))
    )}

    What alternative solutions did you explore? (Optional)

    N/A

  3. namhihi237 commented on Sep 16, 2023

    @namhihi237
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Offline messages should be positioned at the bottom when the network offline

    What is the root cause of that problem?

    We have wrapped the ScreenWrapper content of PrivateNotesListPage here

    <ScreenWrapper includeSafeAreaPaddingBottom={false}>
    <FullPageNotFoundView
    shouldShow={_.isEmpty(report.reportID) || (!report.isLoadingPrivateNotes && network.isOffline && _.isEmpty(lodashGet(report, 'privateNotes', {})))}
    onBackButtonPress={() => Navigation.goBack()}
    >
    <HeaderWithBackButton
    title={translate('privateNotes.title')}
    shouldShowBackButton
    onCloseButtonPress={() => Navigation.dismissModal()}
    onBackButtonPress={() => Navigation.goBack()}
    />
    {report.isLoadingPrivateNotes && _.isEmpty(lodashGet(report, 'privateNotes', {})) ? (
    <FullScreenLoadingIndicator />
    ) : (
    _.map(privateNotes, (item, index) => getMenuItem(item, index))
    )}

    When offline OfflineIndicator will show below the content. So here the content does not take up the entire screen, leading to the offline message not being at the bottom.

    What changes do you think we should make in order to solve the problem?

    We should let the content take up the entire screen.

    <View style={[styles.flex1]}>
    	{_.map(privateNotes, (item, index) => getMenuItem(item, index))}
    </View>

    What alternative solutions did you explore? (Optional)

    N/A

  4. melvin-bot commented on Sep 16, 2023

    @melvin-bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  5. melvin-bot commented on Sep 16, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 16, 2023
  7. changed the title [-]Dev: mWeb - Offline message not positioned at bottom in private notes[/-] [+][$500] Dev: mWeb - Offline message not positioned at bottom in private notes[/+] on Sep 16, 2023
  8. melvin-bot commented on Sep 16, 2023

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 16, 2023
  10. melvin-bot commented on Sep 16, 2023

    @melvin-bot

    Current assignee @kadiealexander is eligible for the External assigner, not assigning anyone new.

  11. 38 remaining items

  12. kadiealexander commented on Oct 10, 2023

    @kadiealexander
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  13. changed the title [-][HOLD for payment 2023-10-09] [$500] Dev: mWeb - Offline message not positioned at bottom in private notes[/-] [+][HOLD for BugZero checklist and C+ payment via Newdot] [$500] Dev: mWeb - Offline message not positioned at bottom in private notes[/+] on Oct 10, 2023
  14. eVoloshchak commented on Oct 11, 2023

    @eVoloshchak
    Contributor
    • The PR that introduced the bug has been identified. Link to the PR: Add private notes feature to newDot #25761
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/25761/files#r1355474009
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: there's already a reviewer checklist item to catch exactly these types of bugs, I don't think an additional discussion is needed
  15. eVoloshchak commented on Oct 11, 2023

    @eVoloshchak
    Contributor

    Regression Test Proposal

    1. Create a workspace if not created
    2. Go to #admins
    3. Click on header
    4. Go to Private notes
    5. Turn off internet connection
    6. Verify that offline indicator is be displayed at the bottom of the page

    Do we agree 👍 or 👎

  16. eVoloshchak commented on Oct 11, 2023

    @eVoloshchak
    Contributor

    Contributor: $500 @dhairyasenjaliya
    Contributor+: $500 @eVoloshchak

    @kadiealexander, shouldn't it be $750 if the bonus is applied?

  17. kadiealexander commented on Oct 17, 2023

    @kadiealexander
    Contributor

    Updated.

  18. changed the title [-][HOLD for BugZero checklist and C+ payment via Newdot] [$500] Dev: mWeb - Offline message not positioned at bottom in private notes[/-] [+][HOLD for C+ payment via Newdot] [$500] Dev: mWeb - Offline message not positioned at bottom in private notes[/+] on Oct 17, 2023
  19. eVoloshchak commented on Oct 17, 2023

    @eVoloshchak
    Contributor

    Thanks!
    Requested the payment

  20. JmillsExpensify commented on Oct 18, 2023

    @JmillsExpensify
    Contributor

    $750 payment approved for @eVoloshchak based on correct BZ summary.

  21. eVoloshchak commented on Oct 30, 2023

    @eVoloshchak
    Contributor

    @kadiealexander, this one can be closed I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionExternalAdded to denote the issue can be worked on by a contributorMonthlyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions