Skip to content

[HOLD for payment 2023-10-09] [$500] Web - App closes RHN directly when we open 'Send message' using CTRL+SHIFT+K and back #27669

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app
  2. Open settings
  3. Open search using CTRL+K/CMD+K
  4. Click back, it comes back to settings page
  5. Open 'Send message' by CTRL+SHIFT+K
  6. Click back and observe that it closes RHN instead of coming back to settings page

Expected Result:

App should not directly close RHN when we open any page, open Send message by CTRL+SHIFT+K shortcut and go back

Actual Result:

App directly closes RHN when we open any page, open Send message by CTRL+SHIFT+K shortcut and go back

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.71.4
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

back.closes.RHN.using.send.message.mp4
Recording.4554.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695033497745239

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01afcf31288891f8d0
  • Upwork Job ID: 1704074354945183744
  • Last Price Increase: 2023-09-19
  • Automatic offers:
    • Pluto0104 | Contributor | 26854267
    • dhanashree-sawant | Reporter | 26854269

Activity

  1. OSBotify commented on Sep 18, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Sep 18, 2023

    @melvin-bot

    Triggered auto assignment to @nkuoch (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. Pluto0104 commented on Sep 18, 2023

    @Pluto0104
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The problem we are addressing is that the Right Hand Navigation (RHN) is closing when we open the 'Send message' dialog using the keyboard shortcut CTRL+SHIFT+K and then navigate back.

    What is the root cause of that problem?

    The root cause of this issue is identified as a regression introduced in the 446f29b. The specific code snippet responsible for this behavior is found in NewChatSelectorPage.js, where Navigation.dismissModal is used to close the RHN.

    onBackButtonPress={Navigation.dismissModal}

    What changes do you think we should make in order to solve the problem?

    To address this issue, we propose using the Navigation.goBack function instead of Navigation.dismissModal. Alternatively, we can consider removing this line altogether, allowing the onBackButtonPress function to revert to its default behavior of using Navigation.goBack.

    What alternative solutions did you explore? (Optional)

    N/A

    Result

    27669.mp4
  4. removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Sep 18, 2023
  5. nkuoch commented on Sep 18, 2023

    @nkuoch
    Contributor

    Removing deploy blocker as think I kind of like this "regression".

    I feel like if a user starts using Ctrl+K or Ctrl+shift+K, it means that they were done with whatever they were doing on the right side, and it makes sense to me that it "replaces the RHN" rather than "go over it".
    So when clicking on the left arrow, I kind of like that it doesn't have to go through the previously opened RHN again.

    Either way, poor ROI or limited user impact, so closing.

  6. dhanashree-sawant commented on Sep 19, 2023

    @dhanashree-sawant

    Hi @nkuoch, if we decide closing RHN is correct, shouldn't it be also done for CTRL+K?

  7. nkuoch commented on Sep 19, 2023

    @nkuoch
    Contributor

    All right, makes sense to make it consistent.
    Let's just stick with going back rather than closing the modal then.

  8. reopened this on Sep 19, 2023
  9. added and removed on Sep 19, 2023
  10. 52 remaining items

  11. dylanexpensify commented on Oct 16, 2023

    @dylanexpensify
    Contributor

    @Pluto0104 we cannot, apologies!

  12. Pluto0104 commented on Oct 16, 2023

    @Pluto0104
    Contributor

    Hey @dylanexpensify, are you saying you won't cover the cost for that?

  13. dylanexpensify commented on Oct 16, 2023

    @dylanexpensify
    Contributor

    @Pluto0104 we can only make payments to your own Upwork account. If you need time to sort out your account, please do, and ping us when it's back on!

  14. Pluto0104 commented on Oct 16, 2023

    @Pluto0104
    Contributor

    @dylanexpensify, I've reached out multiple times, but my account has been permanently suspended.

  15. dylanexpensify commented on Oct 16, 2023

    @dylanexpensify
    Contributor

    discussing internally, one moment! 🙇‍♂️

  16. robertKozik commented on Oct 16, 2023

    @robertKozik
    Contributor
    • [@robertKozik] The PR that introduced the bug has been identified. Link to the PR: There was no particular PR inttroducing this - it was not a bug, but inconsistency between the behaviours
    • [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
    • [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • [@robertKozik] Determine if we should create a regression test for this bug. I don`t think we should create the regression test for it
    • [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A
  17. dylanexpensify commented on Oct 18, 2023

    @dylanexpensify
    Contributor

    Finishing this up today!

  18. melvin-bot commented on Oct 23, 2023

    @melvin-bot

    @nkuoch, @dylanexpensify, @robertKozik, @Pluto0104 Eep! 4 days overdue now. Issues have feelings too...

  19. melvin-bot commented on Oct 25, 2023

    @melvin-bot

    @nkuoch, @dylanexpensify, @robertKozik, @Pluto0104 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  20. melvin-bot commented on Oct 27, 2023

    @melvin-bot

    @nkuoch, @dylanexpensify, @robertKozik, @Pluto0104 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions