You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-09] [$500] Web - App closes RHN directly when we open 'Send message' using CTRL+SHIFT+K and back #27669
Click back and observe that it closes RHN instead of coming back to settings page
Expected Result:
App should not directly close RHN when we open any page, open Send message by CTRL+SHIFT+K shortcut and go back
Actual Result:
App directly closes RHN when we open any page, open Send message by CTRL+SHIFT+K shortcut and go back
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.71.4 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
The problem we are addressing is that the Right Hand Navigation (RHN) is closing when we open the 'Send message' dialog using the keyboard shortcut CTRL+SHIFT+K and then navigate back.
What is the root cause of that problem?
The root cause of this issue is identified as a regression introduced in the 446f29b. The specific code snippet responsible for this behavior is found in NewChatSelectorPage.js, where Navigation.dismissModal is used to close the RHN.
What changes do you think we should make in order to solve the problem?
To address this issue, we propose using the Navigation.goBack function instead of Navigation.dismissModal. Alternatively, we can consider removing this line altogether, allowing the onBackButtonPress function to revert to its default behavior of using Navigation.goBack.
What alternative solutions did you explore? (Optional)
Removing deploy blocker as think I kind of like this "regression".
I feel like if a user starts using Ctrl+K or Ctrl+shift+K, it means that they were done with whatever they were doing on the right side, and it makes sense to me that it "replaces the RHN" rather than "go over it".
So when clicking on the left arrow, I kind of like that it doesn't have to go through the previously opened RHN again.
Either way, poor ROI or limited user impact, so closing.
[@robertKozik] The PR that introduced the bug has been identified. Link to the PR: There was no particular PR inttroducing this - it was not a bug, but inconsistency between the behaviours
[@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
[@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[@robertKozik] Determine if we should create a regression test for this bug. I don`t think we should create the regression test for it
[@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A
Activity
OSBotify commentedon Sep 18, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Sep 18, 2023
Triggered auto assignment to @nkuoch (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.Pluto0104 commentedon Sep 18, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
The problem we are addressing is that the Right Hand Navigation (RHN) is closing when we open the 'Send message' dialog using the keyboard shortcut
CTRL+SHIFT+Kand then navigate back.What is the root cause of that problem?
The root cause of this issue is identified as a regression introduced in the 446f29b. The specific code snippet responsible for this behavior is found in
NewChatSelectorPage.js, whereNavigation.dismissModalis used to close the RHN.App/src/pages/NewChatSelectorPage.js
Line 36 in 06e8d3a
What changes do you think we should make in order to solve the problem?
To address this issue, we propose using the
Navigation.goBackfunction instead ofNavigation.dismissModal. Alternatively, we can consider removing this line altogether, allowing theonBackButtonPressfunction to revert to its default behavior of usingNavigation.goBack.What alternative solutions did you explore? (Optional)
N/A
Result
27669.mp4
nkuoch commentedon Sep 18, 2023
Removing deploy blocker as think I kind of like this "regression".
I feel like if a user starts using Ctrl+K or Ctrl+shift+K, it means that they were done with whatever they were doing on the right side, and it makes sense to me that it "replaces the RHN" rather than "go over it".
So when clicking on the left arrow, I kind of like that it doesn't have to go through the previously opened RHN again.
Either way, poor ROI or limited user impact, so closing.
dhanashree-sawant commentedon Sep 19, 2023
Hi @nkuoch, if we decide closing RHN is correct, shouldn't it be also done for CTRL+K?
nkuoch commentedon Sep 19, 2023
All right, makes sense to make it consistent.
Let's just stick with going back rather than closing the modal then.
52 remaining items
dylanexpensify commentedon Oct 16, 2023
@Pluto0104 we cannot, apologies!
Pluto0104 commentedon Oct 16, 2023
Hey @dylanexpensify, are you saying you won't cover the cost for that?
dylanexpensify commentedon Oct 16, 2023
@Pluto0104 we can only make payments to your own Upwork account. If you need time to sort out your account, please do, and ping us when it's back on!
Pluto0104 commentedon Oct 16, 2023
@dylanexpensify, I've reached out multiple times, but my account has been permanently suspended.
dylanexpensify commentedon Oct 16, 2023
discussing internally, one moment! 🙇♂️
robertKozik commentedon Oct 16, 2023
dylanexpensify commentedon Oct 18, 2023
Finishing this up today!
melvin-bot commentedon Oct 23, 2023
@nkuoch, @dylanexpensify, @robertKozik, @Pluto0104 Eep! 4 days overdue now. Issues have feelings too...
melvin-bot commentedon Oct 25, 2023
@nkuoch, @dylanexpensify, @robertKozik, @Pluto0104 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
melvin-bot commentedon Oct 27, 2023
@nkuoch, @dylanexpensify, @robertKozik, @Pluto0104 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!