Skip to content

[HOLD for payment 2023-09-29] [HOLD for payment 2023-09-27] Web - Wrong navigation after back from add-bank-account page #27673

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Click on your avatar to open settings
  2. Click wallet > Then Add payment method > Then Bank account
  3. Now Click on the browser back button

Expected Result:

User should return to the wallet page

Actual Result:

The user did not return to the wallet page, but instead went back to the settings page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.71.4
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screencast.from.17-09-23.04_21_16.webm
Recording.4557.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Ahmed-Abdella
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694914706789169

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01993d4f2d40318905
  • Upwork Job ID: 1710721784525074432
  • Last Price Increase: 2023-10-07

Activity

  1. OSBotify commented on Sep 18, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Sep 18, 2023

    @melvin-bot

    Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. ginsuma commented on Sep 18, 2023

    @ginsuma
    Contributor

    The regression is from my PR #26816
    I am investigating it.

  4. added a commit that references this issue on Sep 18, 2023
    9ebf90b
  5. Ahmed-Abdella commented on Sep 20, 2023

    @Ahmed-Abdella
    Contributor

    @thienlnam Sorry jack the reporting bonus again

  6. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Sep 20, 2023
  7. changed the title [-]Web - Wrong navigation after back from add-bank-account page[/-] [+][HOLD for payment 2023-09-27] Web - Wrong navigation after back from add-bank-account page[/+] on Sep 20, 2023
  8. 18 remaining items

  9. added
    InternalRequires API changes or must be handled by Expensify staff
    on Oct 7, 2023
  10. melvin-bot commented on Oct 7, 2023

    @melvin-bot
  11. melvin-bot commented on Oct 7, 2023

    @melvin-bot

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @aimane-chnaif (Internal)

  12. sakluger commented on Oct 7, 2023

    @sakluger
    Contributor

    Summarizing payouts for this issue:

    Bug reporter: @Ahmed-Abdella $50 (offer sent via Upwork)
    Contributor+: @aimane-chnaif $500 (offer sent via Upwork)

    Upwork job: https://www.upwork.com/jobs/~01993d4f2d40318905

    @Ahmed-Abdella @aimane-chnaif I'll complete the payouts once you've accepted the Upwork offers, thanks!

  13. deleted a comment from melvin-bot on Oct 7, 2023
  14. Ahmed-Abdella commented on Oct 7, 2023

    @Ahmed-Abdella
    Contributor

    @sakluger I accepted the offer, thanks

  15. melvin-bot commented on Oct 11, 2023

    @melvin-bot

    @sakluger, @joelbettner, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  16. aimane-chnaif commented on Oct 11, 2023

    @aimane-chnaif
    Contributor

    Accepted offer. Am I eligible for speed bonus?

  17. sakluger commented on Oct 11, 2023

    @sakluger
    Contributor

    Sorry for the delay everyone! All paid up now.

    @aimane-chnaif we don't have a speed bonus on internal issues, only external ones.

  18. aimane-chnaif commented on Oct 11, 2023

    @aimane-chnaif
    Contributor

    "internal" is determined by PR author, not by label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions