Skip to content

ReconnectApp is called after sending or receiving message with reliableUpdates beta #27754

Closed
Closed
ReconnectApp is called after sending or receiving message with reliableUpdates beta#27754
Assignees
danieldoglas
Labels
BugSomething is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewWeeklyKSv2

Description

@mountiny
mountiny
opened on Sep 19, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Break down in numbered steps

  1. Be on an account with reliableUpdates beta - internal only
  2. Send, or receive a message
  3. Notice a ReconnectApp command is called
  4. Its even triggering a full OpenApp which is bad for large accounts

Expected Result:

Describe what you think should've happened

Reconnect app should not be called

Actual Result:

Describe what actually happened

Reconnect app is called and triggers getting all the updates

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: v1.3.71-6
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @mountiny
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695109019955889

View all open jobs on GitHub

Activity

  1. mountiny
    added
    DeployBlockerCashThis issue or pull request should block deployment
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 19, 2023
  2. mountiny
    assigned
    danieldoglas
    on Sep 19, 2023
  3. melvin-bot
    assigned
    zanyrenney
    on Sep 19, 2023

  4. melvin-bot commented on Sep 19, 2023

    @melvin-bot
    melvin-botBot
    on Sep 19, 2023

    Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  5. melvin-bot commented on Sep 19, 2023

    @melvin-bot
    melvin-botBot
    on Sep 19, 2023

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

  6. mountiny commented on Sep 19, 2023

    @mountiny
    mountiny
    on Sep 19, 2023
    ContributorAuthor

    Its coming from #27180 and @danieldoglas si trying ot find a fix, if he cant in next hour or so we would revert it

  7. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Sep 19, 2023

  8. OSBotify commented on Sep 19, 2023

    @OSBotify
    OSBotify
    on Sep 19, 2023
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  9. melvin-bot commented on Sep 19, 2023

    @melvin-bot
    melvin-botBot
    on Sep 19, 2023

    Current assignee @danieldoglas is eligible for the Engineering assigner, not assigning anyone new.

  10. melvin-bot
    added
    ReviewingHas a PR in review
    WeeklyKSv2
    and removed
    HourlyKSv2
    on Sep 19, 2023

  11. danieldoglas commented on Sep 19, 2023

    @danieldoglas
    danieldoglas
    on Sep 19, 2023
    Contributor

    @zanyrenney removing you since this was fixed internally

  12. danieldoglas
    unassigned
    zanyrenney
    on Sep 19, 2023

  13. roryabraham commented on Sep 20, 2023

    @roryabraham
    roryabraham
    on Sep 20, 2023
    Contributor

    Good to close this then?

  14. roryabraham
    removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Sep 20, 2023

  15. danieldoglas commented on Sep 21, 2023

    @danieldoglas
    danieldoglas
    on Sep 21, 2023
    Contributor

    I think so! It's deployed to staging!

  16. roryabraham commented on Sep 21, 2023

    @roryabraham
    roryabraham
    on Sep 21, 2023
    Contributor

    and prod

  17. roryabraham
    closed this as completedon Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions