Repository navigation
[HOLD for payment 2023-10-02] [HOLD for payment 2023-09-29] [$500] Dev: Web - App crashing on creating new workspace #27782
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Login with new account
- Click on FAB > New workspace
- App crashes
Expected Result:
App should not crash and workspace is created
Actual Result:
App crashes and a console error is present
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: Dev 1.3.71-6
Reproducible in staging?: n
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
app-crashes.mp4
Expensify/Expensify Issue URL:
Issue reported by: @aman-atg
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695116344613649
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~016db5c84825401ac4
- Upwork Job ID: 1704127946717769728
- Last Price Increase: 2023-09-19
Activity
[-]Dev: Web - App crashing on creating new workspace[/-][+][$500] Dev: Web - App crashing on creating new workspace[/+]melvin-bot commentedon Sep 19, 2023
Job added to Upwork: https://www.upwork.com/jobs/~016db5c84825401ac4
melvin-bot commentedon Sep 19, 2023
Triggered auto assignment to @muttmuure (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.melvin-bot commentedon Sep 19, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ArekChr (
External)jeet-dhandha commentedon Sep 19, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
hideReactionListis not defined as its called before the ref could by the parent ref before the innerRef was set.What changes do you think we should make in order to solve the problem?
refandhideReactionListis defined before calling it.App/src/pages/home/report/ReactionList/PopoverReactionList/index.js
Lines 32 to 34 in 778f763
if (!innerReactionListRef.current || !innerReactionListRef.current.hideReactionList) { return; }What alternative solutions did you explore? (Optional)
Pujan92 commentedon Sep 19, 2023
Seems a regression from #27268 as for me while navigating back from profile crashes the app
PiyushChandra17 commentedon Sep 19, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Web - App crashing on creating new workspace
What is the root cause of that problem?
hideReactionListis not defined, need to check initialization firstWhat changes do you think we should make in order to solve the problem?
We need to check this condition first:
if (innerReactionListRef.current && innerReactionListRef.current.hideReactionList) {here,
App/src/pages/home/report/ReactionList/PopoverReactionList/index.js
Lines 32 to 34 in 12dbce8
What alternative solutions did you explore? (Optional)
NA
40 remaining items
melvin-bot commentedon Oct 4, 2023
@ArekChr, @mountiny, @muttmuure Huh... This is 4 days overdue. Who can take care of this?
mountiny commentedon Oct 4, 2023
@muttmuure Can you please handle the payment of $50 here and then we can close
muttmuure commentedon Oct 5, 2023
Invite sent to @aman-atg
aman-atg commentedon Oct 5, 2023
@muttmuure Submitted the proposal on Upwork
melvin-bot commentedon Oct 10, 2023
@ArekChr, @mountiny, @muttmuure Huh... This is 4 days overdue. Who can take care of this?
muttmuure commentedon Oct 11, 2023
Handling
muttmuure commentedon Oct 11, 2023
Offer sent
melvin-bot commentedon Oct 17, 2023
@ArekChr, @mountiny, @muttmuure Huh... This is 4 days overdue. Who can take care of this?
muttmuure commentedon Oct 17, 2023
Paid!