[HOLD for payment 2023-10-09] [Awaiting payment Oct 2 2023 / $500] Web - green dot appears even if task is deleted

@gadhiyamanan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to any chat
Click on + icon and select assign task
Enter title and assign task to you
Create task
Go to task thread and delete the task

Expected Result:

should not show green dot show if task is deleted

Actual Result:

green dot appears even if task is deleted

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: Dev 1.3.71-5
Reproducible in staging?: Y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-19.at.12.19.29.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695106297939429

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01833b320ff7bd97a7
Upwork Job ID: 1704197379523981312
Last Price Increase: 2023-09-19
Automatic offers:

paultsimura | Contributor | 26790441
gadhiyamanan | Reporter | 26790444

Job added to Upwork: https://www.upwork.com/jobs/~01833b320ff7bd97a7

@michaelhaxhiu

Triggered auto assignment to @michaelhaxhiu (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@allroundexperts

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

The green dot is displayed in LHN for deleted task

What is the root cause of that problem?

Here we check for the optionItem.isArchivedRoom to check if the task is closed. The archival logic was removed now.

App/src/components/LHNOptionsList/OptionRowLHN.js

Lines 104 to 108 in f2282b2

    
           const shouldShowGreenDotIndicator = 
        
               !hasBrickError && 
        
               (optionItem.isUnreadWithMention || 
        
                   ReportUtils.isWaitingForIOUActionFromCurrentUser(optionItem) || 
        
                   (optionItem.isTaskReport && optionItem.isTaskAssignee && !optionItem.isCompletedTaskReport && !optionItem.isArchivedRoom));

What changes do you think we should make in order to solve the problem?

We need to check for optionItem.isOpenTaskReport instead:

    const shouldShowGreenDotIndicator =
        !hasBrickError &&
        (optionItem.isUnreadWithMention ||
            ReportUtils.isWaitingForIOUActionFromCurrentUser(optionItem) ||
-           (optionItem.isTaskReport && optionItem.isTaskAssignee && !optionItem.isCompletedTaskReport && !optionItem.isArchivedRoom))
+           (optionItem.isOpenTaskReport && optionItem.isTaskAssignee));

Add in SidebarUtils:

    if (result.isTaskReport) {
+       result.isOpenTaskReport = ReportUtils.isOpenTaskReport(report);
-       result.isCompletedTaskReport = ReportUtils.isCompletedTaskReport(report);
        result.isTaskAssignee = ReportUtils.isReportManager(report);
    }

App/src/libs/SidebarUtils.js

Lines 268 to 271 in f6efb26

    
           if (result.isTaskReport) { 
        
               result.isCompletedTaskReport = ReportUtils.isCompletedTaskReport(report); 
        
               result.isTaskAssignee = ReportUtils.isReportManager(report); 
        
           }

Result:

https://www.loom.com/share/4e2f44055ded410ea5dfe9bef3368db8?sid=1c7304e3-39be-47b6-8685-2b6bd517ce21

What alternative solutions did you explore? (Optional)

Proposal

The green dot is displayed in LHN for deleted task

What is the root cause of that problem?

we are not checking if the task is canceled in the green flag assignment

App/src/components/LHNOptionsList/OptionRowLHN.js

Lines 104 to 109 in 0603fe1

    
           const shouldShowGreenDotIndicator = 
        
               !hasBrickError && 
        
               (optionItem.isUnreadWithMention || 
        
                   ReportUtils.isWaitingForIOUActionFromCurrentUser(optionItem) || 
        
                   (optionItem.isTaskReport && optionItem.isTaskAssignee && !optionItem.isCompletedTaskReport && !optionItem.isArchivedRoom));

What changes do you think we should make in order to solve the problem?

we should check if the task is not cancelled as well

    const shouldShowGreenDotIndicator =
        !hasBrickError &&
        (optionItem.isUnreadWithMention ||
            ReportUtils.isWaitingForIOUActionFromCurrentUser(optionItem) ||
            (optionItem.isTaskReport && optionItem.isTaskAssignee && !optionItem.isCompletedTaskReport && !optionItem.isCanceledTaskReport && !optionItem.isArchivedRoom));

and of course add the isCanceledTaskReport object to the SideBarUtils.js in line 268 to enable the OptionRowLHN to access it

    if (result.isTaskReport) {
        result.isCompletedTaskReport = ReportUtils.isCompletedTaskReport(report);
        result.isCanceledTaskReport = ReportUtils.isCanceledTaskReport(report);
        result.isTaskAssignee = ReportUtils.isReportManager(report);
    }

POC:

Not able to reproduce in latest main - v1.3.71-11

Still reproducible on 1.3.71-13

@paultsimura

Oops! Sorry @paultsimura. I can also reproduce it. Thanks for the verification.

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@gadhiyamanan

I'm handing this off to another BZ as I'm going on sabbatical by end of week, and want to ensure this is paid.

Next steps are as follows:

Bug reporter: @gadhiyamanan $50
Contributor: @paultsimura $750 (50% bonus x OG price)
C+: @allroundexperts $750 (50% bonus x OG price)

@paultsimura

@paultsimura you've been paid
@gadhiyamanan please accept the offer so that I can pay you.

@flaviadefaria

@flaviadefaria offer accepted, thanks!

Reviewing label has been removed, please complete the "BugZero Checklist".

@paultsimura

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: Web - green dot appears even if task is deleted #27915

If no regressions arise, payment will be issued on 2023-10-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@paultsimura requires payment offer (Contributor)
@allroundexperts does not require payment (Eligible for Manual Requests)
@gadhiyamanan requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

@allroundexperts

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
[@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@allroundexperts] Determine if we should create a regression test for this bug.
[@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@flaviadefaria] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/322364

Reviewer Checklist

Show green dot for uncompleted tasks assigned to current user #20808
https://github.com/Expensify/App/pull/20808/files#r1343276213
I think a Slack discussion is not needed since this could have been caught only by better testing.
Regression test would be helpful here.

Regression Test Steps

Go to any chat and create task and assign it to yourself.
Go to the created task and cancel it.

Verify that a green dot does not show up in the LHN beside the task item.

Do we 👍 or 👎 ?

@allroundexperts

$750 payment approved for @allroundexperts based on BZ summary.

Alright, I believe everyone has been paid so closing this.

Navigation Menu

Repository navigation

[HOLD for payment 2023-10-09] [Awaiting payment Oct 2 2023 / $500] Web - green dot appears even if task is deleted #27805

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

POC:

35 remaining items

Reviewer Checklist

Regression Test Steps

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const shouldShowGreenDotIndicator =
	!hasBrickError &&
	(optionItem.isUnreadWithMention \|\|
	ReportUtils.isWaitingForIOUActionFromCurrentUser(optionItem) \|\|
	(optionItem.isTaskReport && optionItem.isTaskAssignee && !optionItem.isCompletedTaskReport && !optionItem.isArchivedRoom));

	if (result.isTaskReport) {
	result.isCompletedTaskReport = ReportUtils.isCompletedTaskReport(report);
	result.isTaskAssignee = ReportUtils.isReportManager(report);
	}

[HOLD for payment 2023-10-09] [Awaiting payment Oct 2 2023 / $500] Web - green dot appears even if task is deleted #27805

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Sep 19, 2023

melvin-bot commented on Sep 19, 2023

melvin-bot commented on Sep 19, 2023

paultsimura commented on Sep 19, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

abzokhattab commented on Sep 19, 2023

Proposal

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

POC:

rojiphil commented on Sep 20, 2023

paultsimura commented on Sep 20, 2023

rojiphil commented on Sep 20, 2023

melvin-bot commented on Sep 21, 2023

35 remaining items

michaelhaxhiu commented on Sep 27, 2023

flaviadefaria commented on Oct 2, 2023

gadhiyamanan commented on Oct 2, 2023

melvin-bot commented on Oct 2, 2023

melvin-bot commented on Oct 2, 2023

melvin-bot commented on Oct 2, 2023

allroundexperts commented on Oct 3, 2023

Reviewer Checklist

Regression Test Steps

JmillsExpensify commented on Oct 5, 2023

flaviadefaria commented on Oct 9, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions