Skip to content

[$500] Chat - The user is able to scroll through the suggestion list #27866

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Login to any account.
  2. Open any chat that has a long chat history.
  3. Type "@" followed by the search keyword in the compose field.
  4. Ensure that the suggestion list ONLY returns a FEW results so that the scroll bar doesn't appear.
  5. Long-press on any item in the suggestion list and scroll up/down.
  6. Observation: The content behind the suggestion list scrolls.

Expected Result:

The content behind the suggestion list should not scroll.

Actual Result:

The user is able to scroll through the suggestion list, causing the chat behind it to scroll.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.72.6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

scroll-through.mp4
Recording.4627.mp4

Expensify/Expensify Issue URL:
Issue reported by: @tranvantoan-qn
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695140320778399

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c3091e29ea2936a7
  • Upwork Job ID: 1704497441979785216
  • Last Price Increase: 2023-10-11

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 20, 2023
  2. changed the title [-]Chat - The user is able to scroll through the suggestion list[/-] [+][$500] Chat - The user is able to scroll through the suggestion list[/+] on Sep 20, 2023
  3. melvin-bot commented on Sep 20, 2023

    @melvin-bot

    Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. melvin-bot commented on Sep 20, 2023

    @melvin-bot
  5. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 20, 2023
  6. melvin-bot commented on Sep 20, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  7. melvin-bot commented on Sep 20, 2023

    @melvin-bot

    Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  8. melvin-bot commented on Sep 20, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

  9. dummy-1111 commented on Sep 20, 2023

    @dummy-1111
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Emoji or mention suggestions list is scrollable

    What is the root cause of that problem?

    We don't have any modal-like style or element to prevent interaction when suggestion list shows

    This is the root cause

    What changes do you think we should make in order to solve the problem?

    We need to add modal-like parent to suggestion list.
    This PR is in progress and uses portal.
    I think we need to hold this issue until the above PR is merged

    Result

    What alternative solutions did you explore? (Optional)

  10. trjExpensify commented on Sep 21, 2023

    @trjExpensify
    Contributor

    Assigned second, dropping off.

  11. 168 remaining items

  12. francoisl commented on Mar 14, 2024

    @francoisl
    Contributor

    Yes we can issue payments now @lschurr and then close this.

  13. lschurr commented on Mar 18, 2024

    @lschurr
    Contributor

    Ah sorry I missed this. I'll take care of payments today.

  14. lschurr commented on Mar 19, 2024

    @lschurr
    Contributor

    Payment summary:

    • Contributor: @MrRefactor (agency - no payment needed)
    • Contributor+: @situchan $500 (to be paid in Upwork)
  15. lschurr commented on Mar 19, 2024

    @lschurr
    Contributor
  16. lschurr commented on Mar 19, 2024

    @lschurr
    Contributor

    This is complete.

  17. tranvantoan-qn commented on Mar 19, 2024

    @tranvantoan-qn

    @lschurr I'm eligible for a reporting bonus as well 😄

  18. lschurr commented on Mar 19, 2024

    @lschurr
    Contributor

    Oh wow, you're right! This is an old one. I sent an offer via Upwork @tranvantoan-qn: https://www.upwork.com/nx/wm/offer/101471120

  19. tranvantoan-qn commented on Mar 19, 2024

    @tranvantoan-qn

    Thank you!
    I have accepted the offer

  20. lschurr commented on Mar 19, 2024

    @lschurr
    Contributor

    All set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions