[$500] Task - Unable to copy task complete/reopen message

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Issue found when executing PR #27119

Action Performed:

Go to staging.new.expensify.com
Go to any task report
Complete the task and then reopen it
Right click on the task completion or reopening message > Copy to clipboard
Paste it in the composer

Expected Result:

The copied task message is pasted

Actual Result:

The copied task message is not pasted. The message is not copied at all

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.72-6

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6207782_20230921_000923.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0181f1cb78999beeb1
Upwork Job ID: 1706863200146464768
Last Price Increase: 2023-09-27

@anmurali

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Proposal

Please re-state the problem that we are trying to solve in this issue

The copied task message is pasted

What is the root cause of that problem?

The cause of the problem is that we need to wrap the TaskAction is not using the CopyTextToClipboard, where other text are using it.

What changes do you think we should make in order to solve the problem?

We need to wrap the text with the CopyTextToClipboard component. Similar on what is done here:

App/src/pages/iou/ReceiptSelector/index.js

Lines 118 to 121 in 4c207ec

    
           <CopyTextToClipboard 
        
               text={CONST.EMAIL.RECEIPTS} 
        
               textStyles={[styles.textBlue]} 
        
           />

So at this part, we need to wrap the report action message with the component above, that way it is know that needs to be copied:

App/src/components/ReportActionItem/TaskAction.js

Lines 23 to 25 in 4c207ec

    
           <View style={[styles.flex1, styles.flexRow, styles.alignItemsCenter]}> 
        
               <Text style={[styles.chatItemMessage, styles.colorMuted]}>{Task.getTaskReportActionMessage(props.actionName, props.taskReportID, false)}</Text> 
        
           </View>

What alternative solutions did you explore? (Optional)

@anmurali

@anmurali Eep! 4 days overdue now. Issues have feelings too...

Yep, can reproduce

Job added to Upwork: https://www.upwork.com/jobs/~0181f1cb78999beeb1

@s77rt

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

@cead22

@cead22, @MariaHCD, @anmurali, @s77rt Still overdue 6 days?! Let's take care of this!

@cead22

@cead22, @MariaHCD, @anmurali, @s77rt 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@thienlnam

cc: @thienlnam if you have any context around why the childReportID is included in the TASKREOPENED / TASKCOMPLETED report actions: #27884 (comment)

That shouldn't be happening, the code that adds those reportActions doesn't include a childReportID
https://github.com/Expensify/Auth/blob/53aea0415eddf80a82db5283ace0162feba26a19/auth/lib/Report.cpp#L5828-L5845

I wonder if it's happening via the FE? Or if this is still reproducible with a new task report

Still seeing it on new task reports 🤔

It seems to me that we're deliberately setting the childReportID to the task reportID here?

Ahhh yes, so this was only meant to be added to the ADD_COMMENT reportActions not these other task actions. I can update it so that happens

Context: You can assign a task to an infinite number of people, and they might not have access to the parent report of the task so they get a reportAction in the DM between the owner and the assignee with a link to the task report. The childReportID is added to those to make sure they all link to the same task report.

@thienlnam

Thanks, @thienlnam! Approved the BE fix, tested locally and it worked as expected:

Screen.Recording.2023-10-26.at.11.30.24.AM.mov

We'll update this issue once the fix is deployed.

@s77rt

Heads up, @s77rt, the backend fix was deployed to production. Can we retest? Thanks!

@MariaHCD

@MariaHCD It's fixed! 🚀

Nice, thanks! I don't think any payments are required or anything else is needed from engineering? So we should be good to close this one out.

Navigation Menu

Repository navigation

[$500] Task - Unable to copy task complete/reopen message #27884

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

39 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<CopyTextToClipboard
	text={CONST.EMAIL.RECEIPTS}
	textStyles={[styles.textBlue]}
	/>

	<View style={[styles.flex1, styles.flexRow, styles.alignItemsCenter]}>
	<Text style={[styles.chatItemMessage, styles.colorMuted]}>{Task.getTaskReportActionMessage(props.actionName, props.taskReportID, false)}</Text>
	</View>

[$500] Task - Unable to copy task complete/reopen message #27884

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Sep 20, 2023

melvin-bot commented on Sep 20, 2023

Bug0 Triage Checklist (Main S/O)

lcsvcn commented on Sep 20, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Sep 26, 2023

anmurali commented on Sep 27, 2023

melvin-bot commented on Sep 27, 2023

melvin-bot commented on Sep 27, 2023

39 remaining items

melvin-bot commented on Oct 18, 2023

melvin-bot commented on Oct 20, 2023

MariaHCD commented on Oct 23, 2023

thienlnam commented on Oct 23, 2023

MariaHCD commented on Oct 25, 2023

thienlnam commented on Oct 25, 2023

MariaHCD commented on Oct 26, 2023

MariaHCD commented on Oct 30, 2023

s77rt commented on Oct 30, 2023

MariaHCD commented on Oct 30, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions