[HOLD for payment 2023-10-13] [$500] Chat - Creating a new line in composer causes the composer to jump when expanding

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to staging.new.expensify.com
Go to any chat
Click on the composer
Create a new line by Shift + Enter

Expected Result:

The composer does not jump when expanding

Actual Result:

The composer jumps when expanding

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.72-6

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6207916_20230921_020518.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0199195af3f24f9d73
Upwork Job ID: 1705074693317824512
Last Price Increase: 2023-09-22
Automatic offers:

s-alves10 | Contributor | 26864648

@johncschuster

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@tylerkaraszewski

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

I've confirmed this happens but I'm not sure where to look to fix it.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Creating a new line in the main composer causes the composer to jump while expading

What is the root cause of that problem?

We determine the vertical padding here based on numberOfLinesProp

App/src/components/Composer/index.js

Line 447 in 5ff88b7

StyleUtils.getComposeTextAreaPadding(numberOfLinesProp, isComposerFullSize),

And we pass numberOfLines props to RNTextInput component here

App/src/components/Composer/index.js

Line 468 in 5ff88b7

numberOfLines={numberOfLines}

The problem is in the mismatch of numberOfLines and numberOfLinesProp
When needed, we change both the numberOfLines state and numberOfLinesProp here

App/src/components/Composer/index.js

Lines 364 to 366 in 5ff88b7

    
           onNumberOfLinesChange(generalNumberOfLines); 
        
           updateIsFullComposerAvailable({isFullComposerAvailable, setIsFullComposerAvailable}, generalNumberOfLines); 
        
           setNumberOfLines(generalNumberOfLines);

but changing numberOfLinesProp requires Onyx merge and takes some more time

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions.js

Line 232 in 5ff88b7

Report.saveReportCommentNumberOfLines(reportID, newNumberOfLines);

So numberOfLinesProps changes a little bit later than numberOfLines state
This makes the composer jump

What changes do you think we should make in order to solve the problem?

We don't need to calculate the vertical padding based on numberOfLinesProps props. We have numberOfLines state and get padding based on this. This makes more sense than using props because this value represent the current state of the composer.

    const inputStyleMemo = useMemo(
        () => [
            // We are hiding the scrollbar to prevent it from reducing the text input width,
            // so we can get the correct scroll height while calculating the number of lines.
            numberOfLines < maxLines ? styles.overflowHidden : {},

            StyleSheet.flatten([style, {outline: 'none'}]),
            StyleUtils.getComposeTextAreaPadding(numberOfLines, isComposerFullSize),
        ],
        [style, maxLines, numberOfLines, isComposerFullSize],
    );

This works as expected

Result

27892.mp4

What alternative solutions did you explore? (Optional)

@robertKozik

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.78-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: get styles based on state numberOfLines #28188

If no regressions arise, payment will be issued on 2023-10-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@robertKozik does not require payment (Contractor)
@s-alves10 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

@robertKozik

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@robertKozik] The PR that introduced the bug has been identified. Link to the PR:
[@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@robertKozik] Determine if we should create a regression test for this bug.
[@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Payment has been issued to @s-alves10

@robertKozik

@robertKozik can you complete the BZ Checklist when you get a moment? Thank you!

@robertKozik

[@robertKozik] The PR that introduced the bug has been identified. Link to the PR: I cannot find any particular PR which introduce it. I believe it was overlooked during implementation

[@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A

[@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A

[@robertKozik] Determine if we should create a regression test for this bug. I don't think we need it here. This bug didn't block any crucial user flow

[@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

CC. @johncschuster

Sweet! Thank you!

Navigation Menu

Repository navigation

[HOLD for payment 2023-10-13] [$500] Chat - Creating a new line in composer causes the composer to jump when expanding #27892

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

34 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	onNumberOfLinesChange(generalNumberOfLines);
	updateIsFullComposerAvailable({isFullComposerAvailable, setIsFullComposerAvailable}, generalNumberOfLines);
	setNumberOfLines(generalNumberOfLines);

[HOLD for payment 2023-10-13] [$500] Chat - Creating a new line in composer causes the composer to jump when expanding #27892

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Sep 20, 2023

melvin-bot commented on Sep 20, 2023

Bug0 Triage Checklist (Main S/O)

OSBotify commented on Sep 20, 2023

melvin-bot commented on Sep 20, 2023

tylerkaraszewski commented on Sep 20, 2023

dummy-1111 commented on Sep 21, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

34 remaining items

melvin-bot commented on Oct 6, 2023

melvin-bot commented on Oct 6, 2023

johncschuster commented on Oct 16, 2023

johncschuster commented on Oct 16, 2023

robertKozik commented on Oct 16, 2023

johncschuster commented on Oct 19, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions