Skip to content

[HOLD for payment 2023-10-23] [$500] Android native - Default Scrollbar is visible when scrolling in a chat #27931

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch app
  2. Tap on a report
  3. Scroll the page up and down

Expected Result:

Open any report in LHN, a white line must not appear on left side while scrolling the page up and down.

Actual Result:

Open any report in LHN, User can see a white line appears on left side while scrolling the page up and down.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.72-6

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6208418_scrol.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e7fb1a538e34bc1d
  • Upwork Job ID: 1705059508445011968
  • Last Price Increase: 2023-10-06
  • Automatic offers:
    • abdulrahuman5196 | Reviewer | 26938079
    • situchan | Contributor | 26938083
    • bernhardoj | Contributor | 27130414

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 21, 2023
  2. melvin-bot commented on Sep 21, 2023

    @melvin-bot

    Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Sep 21, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. OSBotify commented on Sep 21, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Sep 21, 2023

    @melvin-bot

    Triggered auto assignment to @cristipaval (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  6. dummy-1111 commented on Sep 21, 2023

    @dummy-1111
    Contributor

    I can see this issue on production as well

  7. changed the title [-]Android-Report-A white line appears on left side while scrolling the page up and down.[/-] [+]Android native - Default Scrollbar is visible when scrolling in a chat[/+] on Sep 21, 2023
  8. cristipaval commented on Sep 21, 2023

    @cristipaval
    Contributor

    @s-alves10 This is reproducible to me with the latest Staging version but it isn't reproducible with the latest production (1.3.69-2). Could you please check what is your production version where you can reproduce?

  9. 74 remaining items

  10. changed the title [-][HOLD for payment 2023-10-23] [$500] Android native - Default Scrollbar is visible when scrolling in a chat[/-] [+][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [$500] Android native - Default Scrollbar is visible when scrolling in a chat[/+] on Oct 16, 2023
  11. melvin-bot commented on Oct 16, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-10-23. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  12. melvin-bot commented on Oct 16, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
    • [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@abdulrahuman5196] Determine if we should create a regression test for this bug.
    • [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  13. changed the title [-][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [$500] Android native - Default Scrollbar is visible when scrolling in a chat[/-] [+][HOLD for payment 2023-10-23] [$500] Android native - Default Scrollbar is visible when scrolling in a chat[/+] on Oct 17, 2023
  14. lschurr commented on Oct 23, 2023

    @lschurr
    Contributor

    @abdulrahuman5196 - Could you work on the checklist for this one?

  15. lschurr commented on Oct 23, 2023

    @lschurr
    Contributor

    Payment summary:

  16. lschurr commented on Oct 23, 2023

    @lschurr
    Contributor

    Payments have been made in Upwork.

  17. abdulrahuman5196 commented on Oct 23, 2023

    @abdulrahuman5196
    Contributor

    The PR that introduced the bug has been identified. Link to the PR:
    The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    Not a regression per say, since we had a patch and the patch is not working after the update.

    Determine if we should create a regression test for this bug.

    Yes. If not already present.

    If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    1. Open any chat with enough messages to scroll
    2. Verify the scrollbar is on the right side of the screen
    3. Verify the chat list is inverted, i.e. you need to scroll from bottom to top

    @lschurr

  18. lschurr commented on Oct 23, 2023

    @lschurr
    Contributor

    Great! This is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions