You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-23] [$500] Android native - Default Scrollbar is visible when scrolling in a chat #27931
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-]Android-Report-A white line appears on left side while scrolling the page up and down.[/-][+]Android native - Default Scrollbar is visible when scrolling in a chat[/+]on Sep 21, 2023
@s-alves10 This is reproducible to me with the latest Staging version but it isn't reproducible with the latest production (1.3.69-2). Could you please check what is your production version where you can reproduce?
changed the title [-][HOLD for payment 2023-10-23] [$500] Android native - Default Scrollbar is visible when scrolling in a chat[/-][+][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [$500] Android native - Default Scrollbar is visible when scrolling in a chat[/+]on Oct 16, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-23. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
[@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@abdulrahuman5196] Determine if we should create a regression test for this bug.
[@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [$500] Android native - Default Scrollbar is visible when scrolling in a chat[/-][+][HOLD for payment 2023-10-23] [$500] Android native - Default Scrollbar is visible when scrolling in a chat[/+]on Oct 17, 2023
The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
Not a regression per say, since we had a patch and the patch is not working after the update.
Determine if we should create a regression test for this bug.
Yes. If not already present.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Open any chat with enough messages to scroll
Verify the scrollbar is on the right side of the screen
Verify the chat list is inverted, i.e. you need to scroll from bottom to top
Activity
melvin-bot commentedon Sep 21, 2023
Triggered auto assignment to @lschurr (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 21, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)OSBotify commentedon Sep 21, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Sep 21, 2023
Triggered auto assignment to @cristipaval (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.dummy-1111 commentedon Sep 21, 2023
I can see this issue on production as well
[-]Android-Report-A white line appears on left side while scrolling the page up and down.[/-][+]Android native - Default Scrollbar is visible when scrolling in a chat[/+]cristipaval commentedon Sep 21, 2023
@s-alves10 This is reproducible to me with the latest Staging version but it isn't reproducible with the latest production (1.3.69-2). Could you please check what is your production version where you can reproduce?
74 remaining items
[-][HOLD for payment 2023-10-23] [$500] Android native - Default Scrollbar is visible when scrolling in a chat[/-][+][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [$500] Android native - Default Scrollbar is visible when scrolling in a chat[/+]melvin-bot commentedon Oct 16, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-23. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Oct 16, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[-][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [$500] Android native - Default Scrollbar is visible when scrolling in a chat[/-][+][HOLD for payment 2023-10-23] [$500] Android native - Default Scrollbar is visible when scrolling in a chat[/+]lschurr commentedon Oct 23, 2023
@abdulrahuman5196 - Could you work on the checklist for this one?
lschurr commentedon Oct 23, 2023
Payment summary:
lschurr commentedon Oct 23, 2023
Payments have been made in Upwork.
abdulrahuman5196 commentedon Oct 23, 2023
Not a regression per say, since we had a patch and the patch is not working after the update.
Yes. If not already present.
@lschurr
lschurr commentedon Oct 23, 2023
Great! This is complete.