You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-27] [$500] Android - Scan IOU - A broken image is downloaded to the device when receipt cannot be downloaded #27992
changed the title [-]Android - Scan IOU - A broken image is downloaded to the device when receipt cannot be downloaded[/-][+][$500] Android - Scan IOU - A broken image is downloaded to the device when receipt cannot be downloaded[/+]on Sep 22, 2023
I hope you're well. I would like to request your approval for my proposal. If you can provide the approval, I will be able to create the pull request (PR) within the next hour. Your prompt response would be greatly appreciated.
changed the title [-][$500] Android - Scan IOU - A broken image is downloaded to the device when receipt cannot be downloaded[/-][+][HOLD for payment 2023-10-27] [$500] Android - Scan IOU - A broken image is downloaded to the device when receipt cannot be downloaded[/+]on Oct 20, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.87-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-27. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@ArekChr] The PR that introduced the bug has been identified. Link to the PR:
[@ArekChr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@ArekChr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@ArekChr] Determine if we should create a regression test for this bug.
[@ArekChr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Sep 22, 2023
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 22, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)sakluger commentedon Sep 22, 2023
Yep, that's a bug. @izarutskaya do you know what caused it to throw the error?
[-]Android - Scan IOU - A broken image is downloaded to the device when receipt cannot be downloaded[/-][+][$500] Android - Scan IOU - A broken image is downloaded to the device when receipt cannot be downloaded[/+]melvin-bot commentedon Sep 22, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0126f987f66d4dbcf0
melvin-bot commentedon Sep 22, 2023
Current assignee @sakluger is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Sep 22, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (
External)ayazalavi commentedon Sep 22, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
As soon as user try downloading file then error is thrown along with junk file stored.
What is the root cause of that problem?
Root cause exists when we try to copy file in media store which does not exist.
App/src/libs/fileDownload/index.android.js
Lines 75 to 84 in 171259c
This results in junk file saved.
What changes do you think we should make in order to solve the problem?
Use RNFetchBlob.fs.exists(attachmentPath) to check if file exists before trying to save the file.
Result:
0e23b2c6-cb5b-4260-b827-af117f8d6127.mp4
What alternative solutions did you explore? (Optional)
We can alternatively check for file system issues happening through the app and fix them all.
ayazalavi commentedon Sep 22, 2023
Hi @mananjadhav,
I hope you're well. I would like to request your approval for my proposal. If you can provide the approval, I will be able to create the pull request (PR) within the next hour. Your prompt response would be greatly appreciated.
Thank you for your consideration.
Best regards,
Ayaz Alavi
56 remaining items
mvtglobally commentedon Oct 17, 2023
Issue not reproducible during KI retests. (Third week)
melvin-bot commentedon Oct 18, 2023
🎯 ⚡️ Woah @ArekChr / @bernhardoj, great job pushing this forwards! ⚡️
The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉
On to the next one 🚀
[-][$500] Android - Scan IOU - A broken image is downloaded to the device when receipt cannot be downloaded[/-][+][HOLD for payment 2023-10-27] [$500] Android - Scan IOU - A broken image is downloaded to the device when receipt cannot be downloaded[/+]melvin-bot commentedon Oct 20, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 20, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.87-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-27. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Oct 20, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
ArekChr commentedon Oct 23, 2023
Regresion test proposal:
Do we agree 👍 or 👎
sakluger commentedon Oct 27, 2023
Proposed regression test steps look good. 👍
I've paid out @bernhardoj, so we're good to close this one. Thanks everyone! 🚀