Skip to content

[$500] Web - LHN Subtitle Changed to "Not Active" Instead of "Delete" After Deleting Assigned Tasks and Attachment #28015

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Click on FAB and select "Assign Tasks"
  2. Add a title and share it somewhere
  3. Complete the tasks and reopen them, then delete them
  4. Observe that the LHN subtitle is changed to "Deleted", which is correct
  5. Add an attachment and observe that the subtitle changes to "Attachment", which is correct
  6. Delete the attachment and observe that the LHN subtitle should change back to "Deleted", but instead it changes to "Not Active"

Expected Result:

After deleting assigned tasks, adding an attachment, and then deleting the attachment, the LHN subtitle should change back to "Deleted"

Actual Result:

After following the above steps, the LHN subtitle changes to "Not Active" instead of "Deleted"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.73.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-capture.-.2023-09-20T045952.964.webm
Recording.4685.mp4

Expensify/Expensify Issue URL:
Issue reported by: @tewodrosGirmaA
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695210969594049

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01dcaedc710fed40e3
  • Upwork Job ID: 1705218203708387328
  • Last Price Increase: 2023-09-29

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 22, 2023
  2. changed the title [-]Web - LHN Subtitle Changed to "Not Active" Instead of "Delete" After Deleting Assigned Tasks and Attachment[/-] [+][$500] Web - LHN Subtitle Changed to "Not Active" Instead of "Delete" After Deleting Assigned Tasks and Attachment[/+] on Sep 22, 2023
  3. melvin-bot commented on Sep 22, 2023

    @melvin-bot
  4. melvin-bot commented on Sep 22, 2023

    @melvin-bot

    Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  5. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 22, 2023
  6. melvin-bot commented on Sep 22, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  7. melvin-bot commented on Sep 22, 2023

    @melvin-bot

    Triggered auto assignment to @maddylewis (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  8. melvin-bot commented on Sep 22, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

  9. ZhenjaHorbach commented on Sep 22, 2023

    @ZhenjaHorbach
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue

    After deleting a task, adding an attachment, and then deleting the attachment, the subtitle should change back to "Deleted"

    What is the root cause of that problem?

    After removing of the attachment
    The number of reports becomes zero

    } else {
    result.alternateText = lastMessageTextFromReport.length > 0 ? lastMessageText : Localize.translate(preferredLocale, 'report.noActivityYet');
    }

    What changes do you think we should make in order to solve the problem?

    We can add new condition for alternateText

     else if (lodashGet(lastAction, 'actionName', '') === CONST.REPORT.ACTIONS.TYPE.TASKCANCELLED) {
                result.alternateText = `${Localize.translate(preferredLocale, 'task.messages.canceled')}: ${report.reportName}`;
            } 
    

    const lastAction = visibleReportActionItems[report.reportID];
    if (lodashGet(lastAction, 'actionName', '') === CONST.REPORT.ACTIONS.TYPE.RENAMED) {
    const newName = lodashGet(lastAction, 'originalMessage.newName', '');
    result.alternateText = Localize.translate(preferredLocale, 'newRoomPage.roomRenamedTo', {newName});
    } else if (lodashGet(lastAction, 'actionName', '') === CONST.REPORT.ACTIONS.TYPE.TASKREOPENED) {
    result.alternateText = `${Localize.translate(preferredLocale, 'task.messages.reopened')}: ${report.reportName}`;
    } else if (lodashGet(lastAction, 'actionName', '') === CONST.REPORT.ACTIONS.TYPE.TASKCOMPLETED) {
    result.alternateText = `${Localize.translate(preferredLocale, 'task.messages.completed')}: ${report.reportName}`;
    } else {
    result.alternateText = lastMessageTextFromReport.length > 0 ? lastMessageText : Localize.translate(preferredLocale, 'report.noActivityYet');
    }

    What alternative solutions did you explore? (Optional)

    NA

  10. rojiphil commented on Sep 22, 2023

    @rojiphil
    Contributor

    Dupe of #26679. Different problem but same RCA. That will solve this problem too.

  11. mananjadhav commented on Sep 24, 2023

    @mananjadhav
    Collaborator

    @isabelastisser @maddylewis We should put this on hold for 26679.

    Thanks @rojiphil.

  12. isabelastisser commented on Sep 25, 2023

    @isabelastisser
    Contributor

    Thanks @rojiphil!

    Hey @mananjadhav, will this issue be solved once 26679 is fixed? If yes, should we close this one instead of putting it on Hold?

  13. isabelastisser commented on Sep 27, 2023

    @isabelastisser
    Contributor

    @mananjadhav please follow up on my comment above, thanks!

  14. melvin-bot commented on Sep 29, 2023

    @melvin-bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  15. mananjadhav commented on Oct 2, 2023

    @mananjadhav
    Collaborator

    @isabelastisser Apologies I was OOO. Are you , @kbecciv, @rojiphil able to reproduce? If not we can close this one out. I don't have the bandwidth to get to this soon. If still needs a C+ (which I don't think it needs), can you please reassign?

  16. isabelastisser commented on Oct 2, 2023

    @isabelastisser
    Contributor

    hey @rojiphil, can you please follow up on my comment here #28015 (comment)? thanks!

    @rojiphil @kbecciv can you still reproduce this?

  17. kbecciv commented on Oct 3, 2023

    @kbecciv
    Author

    @isabelastisser Checking, will update you shortly.

  18. kbecciv commented on Oct 3, 2023

    @kbecciv
    Author

    Unable to reproduce it on build 1.3.76.4

    Recording.4832.mp4
  19. rojiphil commented on Oct 3, 2023

    @rojiphil
    Contributor

    hey @rojiphil, can you please follow up on my comment here #28015 (comment)? thanks!

    @isabelastisser @mananjadhav
    Sorry for the delayed response.
    The PR we were holding on to was merged in 1.3.76-0 here.
    And, that solves the problem in this issue.
    @kbecciv confirmed this in 1.3.76.4

  20. isabelastisser commented on Oct 3, 2023

    @isabelastisser
    Contributor

    Thanks @rojiphil and @kbecciv! Closing!

  21. tewodrosGirmaA commented on Oct 3, 2023

    @tewodrosGirmaA

    @isabelastisser am I eligible for payment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions