You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] Web - LHN Subtitle Changed to "Not Active" Instead of "Delete" After Deleting Assigned Tasks and Attachment #28015
Complete the tasks and reopen them, then delete them
Observe that the LHN subtitle is changed to "Deleted", which is correct
Add an attachment and observe that the subtitle changes to "Attachment", which is correct
Delete the attachment and observe that the LHN subtitle should change back to "Deleted", but instead it changes to "Not Active"
Expected Result:
After deleting assigned tasks, adding an attachment, and then deleting the attachment, the LHN subtitle should change back to "Deleted"
Actual Result:
After following the above steps, the LHN subtitle changes to "Not Active" instead of "Deleted"
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.73.0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
changed the title [-]Web - LHN Subtitle Changed to "Not Active" Instead of "Delete" After Deleting Assigned Tasks and Attachment[/-][+][$500] Web - LHN Subtitle Changed to "Not Active" Instead of "Delete" After Deleting Assigned Tasks and Attachment[/+]on Sep 22, 2023
@isabelastisser Apologies I was OOO. Are you , @kbecciv, @rojiphil able to reproduce? If not we can close this one out. I don't have the bandwidth to get to this soon. If still needs a C+ (which I don't think it needs), can you please reassign?
@isabelastisser@mananjadhav
Sorry for the delayed response.
The PR we were holding on to was merged in 1.3.76-0 here.
And, that solves the problem in this issue. @kbecciv confirmed this in 1.3.76.4
Activity
[-]Web - LHN Subtitle Changed to "Not Active" Instead of "Delete" After Deleting Assigned Tasks and Attachment[/-][+][$500] Web - LHN Subtitle Changed to "Not Active" Instead of "Delete" After Deleting Assigned Tasks and Attachment[/+]melvin-bot commentedon Sep 22, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01dcaedc710fed40e3
melvin-bot commentedon Sep 22, 2023
Triggered auto assignment to @isabelastisser (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 22, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Sep 22, 2023
Triggered auto assignment to @maddylewis (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.melvin-bot commentedon Sep 22, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (
External)ZhenjaHorbach commentedon Sep 22, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue
After deleting a task, adding an attachment, and then deleting the attachment, the subtitle should change back to "Deleted"
What is the root cause of that problem?
After removing of the attachment
The number of reports becomes zero
App/src/libs/SidebarUtils.js
Lines 346 to 348 in 7bebfd3
What changes do you think we should make in order to solve the problem?
We can add new condition for alternateText
App/src/libs/SidebarUtils.js
Lines 338 to 348 in 7bebfd3
What alternative solutions did you explore? (Optional)
NA
rojiphil commentedon Sep 22, 2023
Dupe of #26679. Different problem but same RCA. That will solve this problem too.
mananjadhav commentedon Sep 24, 2023
@isabelastisser @maddylewis We should put this on hold for 26679.
Thanks @rojiphil.
isabelastisser commentedon Sep 25, 2023
Thanks @rojiphil!
Hey @mananjadhav, will this issue be solved once 26679 is fixed? If yes, should we close this one instead of putting it on Hold?
isabelastisser commentedon Sep 27, 2023
@mananjadhav please follow up on my comment above, thanks!
melvin-bot commentedon Sep 29, 2023
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
mananjadhav commentedon Oct 2, 2023
@isabelastisser Apologies I was OOO. Are you , @kbecciv, @rojiphil able to reproduce? If not we can close this one out. I don't have the bandwidth to get to this soon. If still needs a C+ (which I don't think it needs), can you please reassign?
isabelastisser commentedon Oct 2, 2023
hey @rojiphil, can you please follow up on my comment here #28015 (comment)? thanks!
@rojiphil @kbecciv can you still reproduce this?
kbecciv commentedon Oct 3, 2023
@isabelastisser Checking, will update you shortly.
kbecciv commentedon Oct 3, 2023
Unable to reproduce it on build 1.3.76.4
Recording.4832.mp4
rojiphil commentedon Oct 3, 2023
@isabelastisser @mananjadhav
Sorry for the delayed response.
The PR we were holding on to was merged in 1.3.76-0 here.
And, that solves the problem in this issue.
@kbecciv confirmed this in 1.3.76.4
isabelastisser commentedon Oct 3, 2023
Thanks @rojiphil and @kbecciv! Closing!
tewodrosGirmaA commentedon Oct 3, 2023
@isabelastisser am I eligible for payment?