You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-10] [$500] Request money flow is not proceeded to the next page #28022
changed the title [-]Request money flow is not proceeded to the next page[/-][+][$500] Request money flow is not proceeded to the next page[/+]on Sep 22, 2023
The PR that introduced the bug has been identified. Link to the PR: [CP Staging] Fix the Enter on Money request flows #26606. However, I don't think we can call this a regression, the PR description specifically states that Now this means you cannot use Enter to submit the Distance request, however, its a new feature and its going to be used in mobiles right now mainly so this is fine.
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: I don't think an additional discussion is needed here
Regression Test Proposal
Open the app.
Click on the FAB button > Request Money.
Select the Manual Tab.
Enter an amount.
Press Enter on the keyboard.
Verify that you are navigated to the next step (contact selector)
Do we agree 👍 or 👎
Also noting that this has caused a regression in #29051
Activity
melvin-bot commentedon Sep 22, 2023
Current assignee @dylanexpensify is eligible for the Bug assigner, not assigning anyone new.
[-]Request money flow is not proceeded to the next page[/-][+][$500] Request money flow is not proceeded to the next page[/+]melvin-bot commentedon Sep 22, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0126a0498c5bbce06a
melvin-bot commentedon Sep 22, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Sep 22, 2023
Current assignee @dylanexpensify is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Sep 22, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (
External)dylanexpensify commentedon Sep 22, 2023
related #26588
ZhenjaHorbach commentedon Sep 22, 2023
On the latest version main and on staging do not reproduce
55 remaining items
dylanexpensify commentedon Nov 6, 2023
Should be good now?
dylanexpensify commentedon Nov 7, 2023
@eVoloshchak to confirm
parasharrajat commentedon Nov 7, 2023
Yes, the payment date should be 6 Nov here. @dylanexpensify
melvin-bot commentedon Nov 10, 2023
@johnmlee101, @eVoloshchak, @parasharrajat, @dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Nov 10, 2023
@johnmlee101, @eVoloshchak, @parasharrajat, @dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
eVoloshchak commentedon Nov 12, 2023
Now this means you cannot use Enter to submit the Distance request, however, its a new feature and its going to be used in mobiles right now mainly so this is fine.Regression Test Proposal
Do we agree 👍 or 👎
Also noting that this has caused a regression in #29051
dylanexpensify commentedon Nov 14, 2023
Payment summary:
Please apply in Upwork or create a NewDot request!
JmillsExpensify commentedon Nov 22, 2023
$250 payment approved for @eVoloshchak based on the comment above.
parasharrajat commentedon Apr 5, 2024
Payment requested as per #28022 (comment)
JmillsExpensify commentedon Apr 8, 2024
$250 approved for @parasharrajat