Skip to content

[HOLD for payment 2023-10-10] [$500] Request money flow is not proceeded to the next page #28022

Closed

Description

@dylanexpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #26520

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to + > Request money
  3. Change to the Distance tab.
  4. Add waypoints.
  5. When the submit button is enabled, Hit Enter on the keyboard.

Expected:

Pressing Enter should submit the Distance request.

Actual:

Enter key submission does not work on Distance Page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.62-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6186267_20230902_234752.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0126a0498c5bbce06a
  • Upwork Job ID: 1705231943999688704
  • Last Price Increase: 2023-09-22

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 22, 2023
  2. melvin-bot commented on Sep 22, 2023

    @melvin-bot

    Current assignee @dylanexpensify is eligible for the Bug assigner, not assigning anyone new.

  3. changed the title [-]Request money flow is not proceeded to the next page[/-] [+][$500] Request money flow is not proceeded to the next page[/+] on Sep 22, 2023
  4. melvin-bot commented on Sep 22, 2023

    @melvin-bot
  5. melvin-bot commented on Sep 22, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 22, 2023
  7. melvin-bot commented on Sep 22, 2023

    @melvin-bot

    Current assignee @dylanexpensify is eligible for the External assigner, not assigning anyone new.

  8. melvin-bot commented on Sep 22, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

  9. dylanexpensify commented on Sep 22, 2023

    @dylanexpensify
    ContributorAuthor

    related #26588

  10. ZhenjaHorbach commented on Sep 22, 2023

    @ZhenjaHorbach
    Contributor

    On the latest version main and on staging do not reproduce

  11. 55 remaining items

  12. dylanexpensify commented on Nov 6, 2023

    @dylanexpensify
    ContributorAuthor

    Should be good now?

  13. dylanexpensify commented on Nov 7, 2023

    @dylanexpensify
    ContributorAuthor

    @eVoloshchak to confirm

  14. parasharrajat commented on Nov 7, 2023

    @parasharrajat
    Member

    Yes, the payment date should be 6 Nov here. @dylanexpensify

  15. melvin-bot commented on Nov 10, 2023

    @melvin-bot

    @johnmlee101, @eVoloshchak, @parasharrajat, @dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  16. melvin-bot commented on Nov 10, 2023

    @melvin-bot

    @johnmlee101, @eVoloshchak, @parasharrajat, @dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  17. eVoloshchak commented on Nov 12, 2023

    @eVoloshchak
    Contributor
    • The PR that introduced the bug has been identified. Link to the PR: [CP Staging] Fix the Enter on Money request flows #26606. However, I don't think we can call this a regression, the PR description specifically states that Now this means you cannot use Enter to submit the Distance request, however, its a new feature and its going to be used in mobiles right now mainly so this is fine.
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: I don't think an additional discussion is needed here

    Regression Test Proposal

    1. Open the app.
    2. Click on the FAB button > Request Money.
    3. Select the Manual Tab.
    4. Enter an amount.
    5. Press Enter on the keyboard.
    6. Verify that you are navigated to the next step (contact selector)

    Do we agree 👍 or 👎

    Also noting that this has caused a regression in #29051

  18. dylanexpensify commented on Nov 14, 2023

    @dylanexpensify
    ContributorAuthor

    Payment summary:

    Please apply in Upwork or create a NewDot request!

  19. JmillsExpensify commented on Nov 22, 2023

    @JmillsExpensify
    Contributor

    $250 payment approved for @eVoloshchak based on the comment above.

  20. parasharrajat commented on Apr 5, 2024

    @parasharrajat
    Member

    Payment requested as per #28022 (comment)

  21. JmillsExpensify commented on Apr 8, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @parasharrajat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions