Skip to content

[HOLD for payment 2023-10-12] [$500] Request money - Inappropriate Error message show up when going back #28086

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Action Performed:

  1. Click on FAB > Request money
  2. Click 'Next' without entering a valid number
  3. Notice an error message show up
  4. Enter a Valid number and Click on next
  5. Click the back button on the manual page to go back to the Request Money page
  6. Erase the valid amount entered. Notice an error message shows up

Expected Result:

The error should only show up after the user taps the button again

Actual Result:

An error message shows up

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.73.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

T150.Errormassagegoingback-1.mp4
Recording.4733.mp4

Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695514629151899

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0136329907e03b716d
  • Upwork Job ID: 1706132442238746624
  • Last Price Increase: 2023-09-25
  • Automatic offers:
    • fedirjh | Reviewer | 26976243
    • akinwale | Contributor | 26976246

Activity

  1. OSBotify commented on Sep 24, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Sep 24, 2023

    @melvin-bot

    Everybody was OOO, so I assigned 10 random eligible people.

  3. 52 remaining items

  4. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Oct 5, 2023
  5. changed the title [-][$500] Request money - Inappropriate Error message show up when going back[/-] [+][HOLD for payment 2023-10-12] [$500] Request money - Inappropriate Error message show up when going back[/+] on Oct 5, 2023
  6. melvin-bot commented on Oct 5, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  7. melvin-bot commented on Oct 5, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.77-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-10-12. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  8. fedirjh commented on Oct 13, 2023

    @fedirjh
    Contributor

    BugZero Checklist:

    Regression Test Proposal

    1. Open newDot
    2. Open the global create menu and select Request Money.
    3. Select the Manual tab if it is not already active.
    4. Click or tap on the Next button without entering any amount.
    5. Verify that an error message is displayed.
    6. Enter a valid amount.
    7. Optionally, click on the Next button to navigate to the next step, and then click on the Back button to navigate to the amount form.
    8. Clear the digits from the input until it is empty.
    9. Verify that no error message is displayed.
    10. Click on the Next button again when the amount field is empty.
    11. Verify that an error message is displayed.
    • Do we agree 👍 or 👎
  9. lschurr commented on Oct 13, 2023

    @lschurr
    Contributor

    Payment summary:

  10. lschurr commented on Oct 13, 2023

    @lschurr
    Contributor

    Payments are made to @akinwale and @fedirjh. I invited you to the job as well @daveSeife - could you accept and apply?

  11. akinwale commented on Oct 13, 2023

    @akinwale
    Contributor

    Payments are made to @akinwale and @fedirjh. I invited you to the job as well @daveSeife - could you accept and apply?

    Received. Thanks!

  12. lschurr commented on Oct 13, 2023

    @lschurr
    Contributor

    All payments made. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions