You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-09] [$500] Profile - Save button is disabled in Display name page in offline mode #28148
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
The Save button is disabled in Display name page in offline mode
What is the root cause of that problem?
In the FormProvider component, the enabledWhenOffline prop (which is used to determine whether or not a form can be submitted when offline) is not being forwarded to the FormWrapper component.
changed the title [-]Profile - Save button is disabled in Display name page in offline mode[/-][+][$500] Profile - Save button is disabled in Display name page in offline mode[/+]on Sep 26, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@parasharrajat] Determine if we should create a regression test for this bug.
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@tjferriss] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2023-10-09] [HOLD for payment 2023-10-05] [$500] Profile - Save button is disabled in Display name page in offline mode[/-][+][HOLD for payment 2023-10-09] [$500] Profile - Save button is disabled in Display name page in offline mode[/+]on Oct 6, 2023
To clarify, payment is expected on 2023-10-09 as long as we don't see any regressions.
This was originally deployed to production on 2023-09-28, so the payment date of 2023-10-05 is the correct one. Looks like it got mixed up in the deployment process a second time so the bot got confused.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: It was a simple mistake so no discussion is needed.
[@parasharrajat] Determine if we should create a regression test for this bug. No, It is already covered.
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. We already have regression steps for this.
Activity
melvin-bot commentedon Sep 25, 2023
Triggered auto assignment to @tjferriss (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 25, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)OSBotify commentedon Sep 25, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Sep 25, 2023
Auto-assign attempt failed, all eligible assignees are OOO.
akinwale commentedon Sep 25, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
The Save button is disabled in Display name page in offline mode
What is the root cause of that problem?
In the FormProvider component, the
enabledWhenOfflineprop (which is used to determine whether or not a form can be submitted when offline) is not being forwarded to theFormWrappercomponent.App/src/components/Form/FormProvider.js
Lines 237 to 244 in 21b3e64
What changes do you think we should make in order to solve the problem?
Forward the
enabledWhenOfflineprop to theFormWrappercomponent.<FormWrapper {...rest} + enabledWhenOffline={enabledWhenOffline} onSubmit={submit} inputRefs={inputRefs} errors={errors} >What alternative solutions did you explore? (Optional)
None.
[-]Profile - Save button is disabled in Display name page in offline mode[/-][+][$500] Profile - Save button is disabled in Display name page in offline mode[/+]melvin-bot commentedon Sep 26, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0134557e3ac359277d
38 remaining items
melvin-bot commentedon Oct 2, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
tjferriss commentedon Oct 5, 2023
@parasharrajat can you get started on the checklist?
[-][HOLD for payment 2023-10-09] [HOLD for payment 2023-10-05] [$500] Profile - Save button is disabled in Display name page in offline mode[/-][+][HOLD for payment 2023-10-09] [$500] Profile - Save button is disabled in Display name page in offline mode[/+]tjferriss commentedon Oct 6, 2023
To clarify, payment is expected on 2023-10-09 as long as we don't see any regressions.
akinwale commentedon Oct 6, 2023
This was originally deployed to production on 2023-09-28, so the payment date of 2023-10-05 is the correct one. Looks like it got mixed up in the deployment process a second time so the bot got confused.
parasharrajat commentedon Oct 7, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
We already have regression steps for this.
tjferriss commentedon Oct 9, 2023
@akinwale has been paid via Upworks. We're waiting on @parasharrajat to be paid, then we can close the issue.
akinwale commentedon Oct 9, 2023
Received. Thanks!
parasharrajat commentedon Oct 12, 2023
Payment requested as per #28148 (comment)
JmillsExpensify commentedon Oct 12, 2023
$750 payment approved for @parasharrajat based on BZ summary.