Skip to content

[HOLD for payment 2023-10-09] [$500] Profile - Save button is disabled in Display name page in offline mode #28148

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #27025

Action Performed:

  1. Launch New Expensify app
  2. Go offline
  3. Go to Settings > Profile > Display name
  4. Make some changes

Expected Result:

User is able to save the changes in offline mode

Actual Result:

Save button is disabled and user cannot make changes during offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.74-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6213691_Screen_Recording_20230925_211750_New_Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0134557e3ac359277d
  • Upwork Job ID: 1706560446209835008
  • Last Price Increase: 2023-09-26
  • Automatic offers:
    • akinwale | Contributor | 26896617

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 25, 2023
  2. melvin-bot commented on Sep 25, 2023

    @melvin-bot

    Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Sep 25, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. OSBotify commented on Sep 25, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Sep 25, 2023

    @melvin-bot

    Auto-assign attempt failed, all eligible assignees are OOO.

  6. akinwale commented on Sep 25, 2023

    @akinwale
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The Save button is disabled in Display name page in offline mode

    What is the root cause of that problem?

    In the FormProvider component, the enabledWhenOffline prop (which is used to determine whether or not a form can be submitted when offline) is not being forwarded to the FormWrapper component.

    <FormWrapper
    {...rest}
    onSubmit={submit}
    inputRefs={inputRefs}
    errors={errors}
    >
    {children}
    </FormWrapper>

    What changes do you think we should make in order to solve the problem?

    Forward the enabledWhenOffline prop to the FormWrapper component.

    <FormWrapper
        {...rest}
    +   enabledWhenOffline={enabledWhenOffline}
        onSubmit={submit}
        inputRefs={inputRefs}
        errors={errors}
    >

    What alternative solutions did you explore? (Optional)

    None.

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 26, 2023
  8. changed the title [-]Profile - Save button is disabled in Display name page in offline mode[/-] [+][$500] Profile - Save button is disabled in Display name page in offline mode[/+] on Sep 26, 2023
  9. melvin-bot commented on Sep 26, 2023

    @melvin-bot
  10. 38 remaining items

  11. melvin-bot commented on Oct 2, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
    • [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@parasharrajat] Determine if we should create a regression test for this bug.
    • [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@tjferriss] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  12. tjferriss commented on Oct 5, 2023

    @tjferriss
    Contributor

    @parasharrajat can you get started on the checklist?

  13. changed the title [-][HOLD for payment 2023-10-09] [HOLD for payment 2023-10-05] [$500] Profile - Save button is disabled in Display name page in offline mode[/-] [+][HOLD for payment 2023-10-09] [$500] Profile - Save button is disabled in Display name page in offline mode[/+] on Oct 6, 2023
  14. tjferriss commented on Oct 6, 2023

    @tjferriss
    Contributor

    To clarify, payment is expected on 2023-10-09 as long as we don't see any regressions.

  15. akinwale commented on Oct 6, 2023

    @akinwale
    Contributor

    To clarify, payment is expected on 2023-10-09 as long as we don't see any regressions.

    This was originally deployed to production on 2023-09-28, so the payment date of 2023-10-05 is the correct one. Looks like it got mixed up in the deployment process a second time so the bot got confused.

  16. parasharrajat commented on Oct 7, 2023

    @parasharrajat
    Member

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: Refactor form component #27025
    • [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/27025/files#r1349483938
    • [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: It was a simple mistake so no discussion is needed.
    • [@parasharrajat] Determine if we should create a regression test for this bug. No, It is already covered.
    • [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
      We already have regression steps for this.
  17. tjferriss commented on Oct 9, 2023

    @tjferriss
    Contributor

    @akinwale has been paid via Upworks. We're waiting on @parasharrajat to be paid, then we can close the issue.

  18. akinwale commented on Oct 9, 2023

    @akinwale
    Contributor

    @akinwale has been paid via Upworks. We're waiting on @parasharrajat to be paid, then we can close the issue.

    Received. Thanks!

  19. parasharrajat commented on Oct 12, 2023

    @parasharrajat
    Member

    Payment requested as per #28148 (comment)

  20. JmillsExpensify commented on Oct 12, 2023

    @JmillsExpensify
    Contributor

    $750 payment approved for @parasharrajat based on BZ summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions