Skip to content

[HOLD for payment 2023-10-09] Apply UI fixes to the profile status feature #28210

Closed

Description

@Julesssss

cc @stitesExpensify - maybe this needs to be tagged with a project? LMK

Problem

Some UI issues were noticed with the launch of the new Status UI feature:

the clear status row should use the same exact styles as any other option row, but looks like they are using rounded corners and not the correct height?

image (10)

If you have no Status, the “Status” label should be vertically centered in the push-to-page row and use our normal font size. Curious why this one didn’t work out of the box, as in, shouldn’t this be a shared global component?

image (11)

Solution

Do the things

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016b059ec2ac57b545
  • Upwork Job ID: 1706497543710756864
  • Last Price Increase: 2023-09-26

Activity

  1. melvin-bot commented on Sep 26, 2023

    @melvin-bot
  2. melvin-bot commented on Sep 26, 2023

    @melvin-bot

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @Ollyws (Internal)

  3. Julesssss commented on Sep 26, 2023

    @Julesssss
    ContributorAuthor

    Hey @Ollyws, here's the PR to review: #28122

  4. melvin-bot commented on Sep 26, 2023

    @melvin-bot

    Triggered auto assignment to @luacmartins, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  5. Julesssss commented on Sep 27, 2023

    @Julesssss
    ContributorAuthor

    Whoops, I forgot to assign myeslf to this issue which triggered the random PR review assignment

  6. 11 remaining items

  7. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 11, 2023
  8. melvin-bot commented on Oct 11, 2023

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  9. melvin-bot commented on Oct 11, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  10. luacmartins commented on Oct 11, 2023

    @luacmartins
    Contributor

    Adding Bug label to get a BZ team member assigned to process payment. @mallenexpensify could you please assist? We just need to pay @Ollyws for the PR review

  11. mallenexpensify commented on Oct 12, 2023

    @mallenexpensify
    Contributor

    👋 @Ollyws can you please accept the job and reply here once you have?
    https://www.upwork.com/jobs/~016b059ec2ac57b545

  12. Ollyws commented on Oct 12, 2023

    @Ollyws
    Contributor

    @mallenexpensify Accepted, thanks!

  13. melvin-bot commented on Oct 16, 2023

    @melvin-bot

    @Julesssss, @Ollyws, @luacmartins, @mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  14. Julesssss commented on Oct 16, 2023

    @Julesssss
    ContributorAuthor

    I think this has been paid?

  15. Ollyws commented on Oct 16, 2023

    @Ollyws
    Contributor

    Still awaiting payment on this one.

  16. mallenexpensify commented on Oct 17, 2023

    @mallenexpensify
    Contributor

    Contributor+: @Ollyws paid $500 via Upwork.

    Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions