You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-10] [HOLD for payment 2023-10-09] [HOLD for payment 2023-10-6] [$500] Request money - Extra 0 digit in the amount and app crashes when requesting money #28417
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-][HOLD for payment 2023-10-6] [$500] Request money - Extra 0 digit in the amount and app crashes when requesting money[/-][+][HOLD for payment 2023-10-09] [HOLD for payment 2023-10-6] [$500] Request money - Extra 0 digit in the amount and app crashes when requesting money[/+]on Oct 2, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-09. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@cubuspl42] The PR that introduced the bug has been identified. Link to the PR:
[@cubuspl42] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@cubuspl42] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@cubuspl42] Determine if we should create a regression test for this bug.
[@cubuspl42] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2023-10-09] [HOLD for payment 2023-10-6] [$500] Request money - Extra 0 digit in the amount and app crashes when requesting money[/-][+][HOLD for payment 2023-10-10] [HOLD for payment 2023-10-09] [HOLD for payment 2023-10-6] [$500] Request money - Extra 0 digit in the amount and app crashes when requesting money[/+]on Oct 3, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.76-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-10. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@cubuspl42] The PR that introduced the bug has been identified. Link to the PR:
[@cubuspl42] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@cubuspl42] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@cubuspl42] Determine if we should create a regression test for this bug.
[@cubuspl42] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Sep 28, 2023
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 28, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)OSBotify commentedon Sep 28, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Sep 28, 2023
Triggered auto assignment to @AndrewGable (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.pradeepmdk commentedon Sep 28, 2023
due to this PR started crashing https://github.com/Expensify/react-native-onyx/pull/329/files
tgolen commentedon Sep 29, 2023
@ospfranco Do you think it's related? I'm not seeing the connection necessarily, but if it is related, can you come up with a fix?
tgolen commentedon Sep 29, 2023
@pradeepmdk Can you please share how you determined that was the PR?
34 remaining items
[-][HOLD for payment 2023-10-6] [$500] Request money - Extra 0 digit in the amount and app crashes when requesting money[/-][+][HOLD for payment 2023-10-09] [HOLD for payment 2023-10-6] [$500] Request money - Extra 0 digit in the amount and app crashes when requesting money[/+]melvin-bot commentedon Oct 2, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 2, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-09. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Oct 2, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
jliexpensify commentedon Oct 3, 2023
Payment Summary here
Invited!
jliexpensify commentedon Oct 3, 2023
Paid, and job closed!
[-][HOLD for payment 2023-10-09] [HOLD for payment 2023-10-6] [$500] Request money - Extra 0 digit in the amount and app crashes when requesting money[/-][+][HOLD for payment 2023-10-10] [HOLD for payment 2023-10-09] [HOLD for payment 2023-10-6] [$500] Request money - Extra 0 digit in the amount and app crashes when requesting money[/+]melvin-bot commentedon Oct 3, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.76-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-10. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Oct 3, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: