You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-10] [HOLD for payment 2023-10-09] Chat - App crashes when replying to message in thread #28419
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
[@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@aimane-chnaif] Determine if we should create a regression test for this bug.
[@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Sep 28, 2023
Triggered auto assignment to @garrettmknight (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 28, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)OSBotify commentedon Sep 28, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Sep 28, 2023
Triggered auto assignment to @AndrewGable (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.rojiphil commentedon Sep 28, 2023
Could Onyx related changes for fixing #26627 be causing this?
pradeepmdk commentedon Sep 28, 2023
@rojiphil this issue comes from this PR https://github.com/Expensify/react-native-onyx/pull/329/files
this related changes #26087
mountiny commentedon Sep 29, 2023
cc @ospfranco @chrispader can you look into this
24 remaining items
melvin-bot commentedon Oct 3, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
garrettmknight commentedon Oct 9, 2023
@aimane-chnaif can you complete the checklist when you get a chance so I can process payment?
aimane-chnaif commentedon Oct 9, 2023
The regression came from big refactor in Onyx repo.
And this was caught by Applause team.
So I think we can skip checklist here.
garrettmknight commentedon Oct 11, 2023
Summarizing payments:
Upwork job/contract: https://www.upwork.com/en-gb/ab/applicants/1712184752085946368/suggested
garrettmknight commentedon Oct 11, 2023
@aimane-chnaif can you accept the contract so I can pay? Thanks!
garrettmknight commentedon Oct 11, 2023
Done