Skip to content

Strikethrough text is not working as expected if there's a space before the ~ #2846

Closed

Description

@isagoico

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Expected Result:

Text shouldn't be strikethrough

Actual Result:

Text is strikethrough

Action Performed:

  1. Navigate to a conversation
  2. Send this text
    ~this text shouldn't be crossed if there's a space behind ~ test

Workaround:

No need, visual issue.

Platform:

Where is this issue occurring?

Web ✔️
iOS
Android
Desktop App
Mobile Web

Version Number: 1.0.43-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

image

Expensify/Expensify Issue URL:

View all open jobs on Upwork


From @mallenexpensify https://expensify.slack.com/archives/C01GTK53T8Q/p1620845857125700

When using multiple ~ in chat, markdown treats them as strikethrough. When there is a space before the second ~ we shouldn't use that to denote the markdown.

Upwork job post: https://www.upwork.com/jobs/~0185450afd7993674c

Activity

  1. added
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on May 13, 2021
  2. MelvinBot commented on May 13, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @sophiepintoraetz (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

  3. removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on May 13, 2021
  4. sophiepintoraetz commented on May 13, 2021

    @sophiepintoraetz
    Contributor

    Copied the text and performed Step 2 in the web version and was able to reproduce:
    image

  5. MelvinBot commented on May 13, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @nickmurray47 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  6. 38 remaining items

  7. changed the title [-]Strikethrough text is not working as expected if there's a space before the ~[/-] [+][HOLD for payment on July 9] Strikethrough text is not working as expected if there's a space before the ~[/+] on Jul 3, 2021
  8. Jag96 commented on Jul 3, 2021

    @Jag96
    Contributor

    Reopening to keep track of payment

  9. reopened this on Jul 3, 2021
  10. puneetlath commented on Jul 10, 2021

    @puneetlath
    Contributor

    Paid.

  11. changed the title [-][HOLD for payment on July 9] Strikethrough text is not working as expected if there's a space before the ~[/-] [+]Strikethrough text is not working as expected if there's a space before the ~[/+] on Jul 16, 2021
  12. mallenexpensify commented on Jul 16, 2021

    @mallenexpensify
    Contributor

    @parasharrajat per this Slack thread, looks like we have a regression so I'm reopening
    When markdown is used for only one character, it's not working correctly
    https://files.slack.com/files-pri/T03SC9DTT-F0291KKFEHW/image.png

  13. parasharrajat commented on Jul 17, 2021

    @parasharrajat
    Member

    PR is up Expensify/expensify-common#395 for regression.

  14. puneetlath commented on Jul 19, 2021

    @puneetlath
    Contributor

    Looks like that PR was merged, so going to go ahead and close this.

  15. parasharrajat commented on Jul 19, 2021

    @parasharrajat
    Member

    Ah, Need to update the ref here in E.cash.

  16. parasharrajat commented on Aug 4, 2021

    @parasharrajat
    Member

    Coming from slack thread https://expensify.slack.com/archives/C01GTK53T8Q/p1628107138154400. We might need to consider the Parsing for ~. It is not yet confirmed. Thanks

  17. puneetlath commented on Aug 9, 2021

    @puneetlath
    Contributor

    Ok, let's open a new issue if we decide we need to make a change. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.ReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions