Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Open Desktop App or go to staging.new.expensify.com
- Login to any account
- Open chat with long history
- Go Offline
- Scroll chat history that has been cached
Expected Result:
Loading animation will be shown when the cached part of the chat ends
Actual Result:
Loading animation is not shown
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.3.75-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug6218642_1695966451095.Chat-offline-no-loading-animation.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0115f790294bf26093
- Upwork Job ID: 1708780525432848384
- Last Price Increase: 2023-10-02
- Automatic offers:
- situchan | Reviewer | 27034754
- bernhardoj | Contributor | 27034757

Activity
melvin-bot commentedon Sep 29, 2023
Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 29, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)OSBotify commentedon Sep 29, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Sep 29, 2023
Triggered auto assignment to @cristipaval (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.kbecciv commentedon Sep 29, 2023
Reproduced with build 1.3.75-3
28466.Desktop.1-3-75-3.mp4
cristipaval commentedon Sep 29, 2023
I think this regression was introduced by this PR, but I would revert it because it's a big one and brings performance optimizations. I will remove the deploy blocker and fix this as a regular issue. It's a minor UI bug reproducible in a corner(ish) use case.
32 remaining items
melvin-bot commentedon Oct 11, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 11, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.80-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-18. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Oct 11, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
JmillsExpensify commentedon Oct 17, 2023
Payment summary:
JmillsExpensify commentedon Oct 17, 2023
@situchan Do you mind completing the BZ checklist above?
melvin-bot commentedon Oct 23, 2023
@JmillsExpensify, @cristipaval, @bernhardoj, @situchan Huh... This is 4 days overdue. Who can take care of this?
cristipaval commentedon Oct 23, 2023
bump @situchan
situchan commentedon Oct 23, 2023
I was not able to find offending PR.
Recent PR should have reverted the changes made in #26772 but git blame shows nothing. @bernhardoj it would be great if you can help finding.
As this was caught by Applause team, no need another regression test.
JmillsExpensify commentedon Oct 23, 2023
Thanks for that. Payment issued. Closing since we're also covered on regression tests.