Skip to content

[HOLD for payment 2023-10-18] [$500] Chat - No loading animation when scrolling through chat history offline #28466

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open Desktop App or go to staging.new.expensify.com
  2. Login to any account
  3. Open chat with long history
  4. Go Offline
  5. Scroll chat history that has been cached

Expected Result:

Loading animation will be shown when the cached part of the chat ends

Actual Result:

Loading animation is not shown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.75-0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6218642_1695966451095.Chat-offline-no-loading-animation.mp4

Bug6218642_1695966451107!Production-loading-animation

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0115f790294bf26093
  • Upwork Job ID: 1708780525432848384
  • Last Price Increase: 2023-10-02
  • Automatic offers:
    • situchan | Reviewer | 27034754
    • bernhardoj | Contributor | 27034757

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 29, 2023
  2. melvin-bot commented on Sep 29, 2023

    @melvin-bot

    Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Sep 29, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. OSBotify commented on Sep 29, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Sep 29, 2023

    @melvin-bot

    Triggered auto assignment to @cristipaval (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  6. kbecciv commented on Sep 29, 2023

    @kbecciv

    Reproduced with build 1.3.75-3

    28466.Desktop.1-3-75-3.mp4
  7. cristipaval commented on Sep 29, 2023

    @cristipaval
    Contributor

    I think this regression was introduced by this PR, but I would revert it because it's a big one and brings performance optimizations. I will remove the deploy blocker and fix this as a regular issue. It's a minor UI bug reproducible in a corner(ish) use case.

  8. 32 remaining items

  9. melvin-bot commented on Oct 11, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  10. melvin-bot commented on Oct 11, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.80-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-10-18. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  11. melvin-bot commented on Oct 11, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@situchan] The PR that introduced the bug has been identified. Link to the PR:
    • [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@situchan] Determine if we should create a regression test for this bug.
    • [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  12. JmillsExpensify commented on Oct 17, 2023

    @JmillsExpensify
    Contributor

    Payment summary:

  13. JmillsExpensify commented on Oct 17, 2023

    @JmillsExpensify
    Contributor

    @situchan Do you mind completing the BZ checklist above?

  14. melvin-bot commented on Oct 23, 2023

    @melvin-bot

    @JmillsExpensify, @cristipaval, @bernhardoj, @situchan Huh... This is 4 days overdue. Who can take care of this?

  15. cristipaval commented on Oct 23, 2023

    @cristipaval
    Contributor
  16. situchan commented on Oct 23, 2023

    @situchan
    Contributor

    I was not able to find offending PR.
    Recent PR should have reverted the changes made in #26772 but git blame shows nothing. @bernhardoj it would be great if you can help finding.

    As this was caught by Applause team, no need another regression test.

  17. JmillsExpensify commented on Oct 23, 2023

    @JmillsExpensify
    Contributor

    Thanks for that. Payment issued. Closing since we're also covered on regression tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions