Skip to content

[$1000] Desktop-"Hmm.. it's not here" page appears when the app auto closes to update #28495

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. App is backgrounded
  2. App auto closes to update

Expected Result:

  1. App to reopen to the last chat that was open (which I don't think is what we're doing now)
  2. If not the # 1 happening, app opens to a report that is accessible.

Actual Result:

App opens to the "Hmm... it's not here" page. Also there is o reportID for the error screen

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.74-2
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

image (1)

image

Expensify/Expensify Issue URL:
Issue reported by: @mallenexpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695712867448569

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0135298da9abe1170c
  • Upwork Job ID: 1712596316625391616
  • Last Price Increase: 2023-11-28
  • Automatic offers:
    • tienifr | Contributor | 27866693

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 29, 2023
  2. melvin-bot commented on Sep 29, 2023

    @melvin-bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Sep 29, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. mallenexpensify commented on Oct 2, 2023

    @mallenexpensify
    Contributor

    I think this might be part of a multi-part issue/bug?

    1. This examples opens to nothing, a non-existent report
    2. The app opens to random reports that exist. I had it happen the past week where the app opened to a weird test report with no comments - https://staging.new.expensify.com/r/92476783
    image-2023-10-02 14_35_20 723
  5. melvin-bot commented on Oct 3, 2023

    @melvin-bot

    @kadiealexander Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  6. kadiealexander commented on Oct 3, 2023

    @kadiealexander
    Contributor

    I'm ooo, reassigning so this isn't blocked on me!

  7. removed their assignment
    on Oct 3, 2023
  8. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 3, 2023
  9. melvin-bot commented on Oct 3, 2023

    @melvin-bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  10. 94 remaining items

  11. melvin-bot commented on Nov 28, 2023

    @melvin-bot

    📣 @eVoloshchak Please request via NewDot manual requests for the Reviewer role ($1000)

  12. melvin-bot commented on Nov 28, 2023

    @melvin-bot

    📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job
    Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  13. tienifr commented on Nov 29, 2023

    @tienifr
    Contributor

    PR ready for review #32158.

  14. mallenexpensify commented on Dec 5, 2023

    @mallenexpensify
    Contributor

    @eVoloshchak please review the PR today or post in #contributor-plus to find someone to take over, thx.

  15. eVoloshchak commented on Dec 5, 2023

    @eVoloshchak
    Contributor

    Will review this today, apologies for the delay

  16. eVoloshchak commented on Dec 22, 2023

    @eVoloshchak
    Contributor

    Not sure why the automation failed (don't see any problems with the PR, the issue is linked properly). This was deployed to production on Dec 14, so payment date is Dec 21. Posting the BZ checklist manually

    • The PR that introduced the bug has been identified. Link to the PR: there isn't a PR that has caused this, this is the initial implementation
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: I don't think an additional discussion is needed, this is very specific bug, a general solution isn't needed
  17. eVoloshchak commented on Dec 22, 2023

    @eVoloshchak
    Contributor

    Regression Test Proposal

    MacOS Desktop only

    1. Open the app
    2. Reload app (CMD+R or View >> Reload)
    3. Verify the app doesn't show Not found page

    Do we agree 👍 or 👎

  18. mallenexpensify commented on Dec 23, 2023

    @mallenexpensify
    Contributor

    Contributor: @tienifr paid $1000 via Upwork
    Contributor+: @eVoloshchak owed $1000 via NewDot

    I don't think we need a regression test for this since the bug at startup would be the error page, which is the first thing after signup (so there's no need for an additional test to find it)

    Thanks @tienifr and @eVoloshchak I particularly hated this 🐛

  19. JmillsExpensify commented on Jan 22, 2024

    @JmillsExpensify
    Contributor

    $1,000 payment approved for @eVoloshchak based on summary above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions