You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-13] Request money - Merchant scan error is not below the merchant field #28498
changed the title [-]Request money - Merchant scan error is not below the merchant field[/-][+][HOLD for payment 2023-10-13] Request money - Merchant scan error is not below the merchant field[/+]on Oct 6, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.78-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-13. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@s77rt] The PR that introduced the bug has been identified. Link to the PR:
[@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@s77rt] Determine if we should create a regression test for this bug.
[@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Sep 29, 2023
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 29, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)allroundexperts commentedon Sep 29, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Merchant scan error has a inconsistent position.
What is the root cause of that problem?
We're supplying the error as a subtitle here.
What changes do you think we should make in order to solve the problem?
We should supply the error to the
errorprop of theMenuItemWithTopDescriptioninstead ofsubtitlelike we're doing here.What alternative solutions did you explore? (Optional)
We can also make the error show up as subtitle instead everywhere.
mountiny commentedon Oct 2, 2023
cc @Gonals coming from your PR I believe, you might want to handle this internally #27735
melvin-bot commentedon Oct 2, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01789730632c97595a
melvin-bot commentedon Oct 2, 2023
Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt (
Internal)jliexpensify commentedon Oct 2, 2023
Not overdue, waiting on Alberto.
5 remaining items
[-]Request money - Merchant scan error is not below the merchant field[/-][+][HOLD for payment 2023-10-13] Request money - Merchant scan error is not below the merchant field[/+]melvin-bot commentedon Oct 6, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 6, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.78-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-13. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Oct 6, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
s77rt commentedon Oct 6, 2023
jliexpensify commentedon Oct 9, 2023
Is this payment summary correct? Doesn't look like there's a bug reporter or Contributor:
Upworks job
s77rt commentedon Oct 9, 2023
@jliexpensify Seems correct
jliexpensify commentedon Oct 16, 2023
Sorry I was out sick at the end of the week - paying now!
jliexpensify commentedon Oct 16, 2023
Paid and post removed!