You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-25] Chat - Pasted text reflects Full Display name #28521
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
What changes do you think we should make in order to solve the problem?
getIOUReportActionDisplayMessage responsible to generate the text to copy, is only called in a single place, we can just update the function call to include the short form flag.
What alternative solutions did you explore? (Optional)
I think it's not a real deploy blocker. It's just a small inconsistency issue, users can still copy the IOU message (with a full display name).
If we can decrease the priority of this issue, I think we can have time to fix another potential inconsistency issue between displaying the IOU message and copying the IOU message.
Displaying IOU message, we're using ReportUtils.getReportPreviewMessage util
changed the title [-]Chat - Pasted text reflects Full Display name[/-][+][HOLD for payment 2023-10-25] Chat - Pasted text reflects Full Display name[/+]on Oct 18, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.86-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-25. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
@mananjadhavdoes not require payment (Eligible for Manual Requests)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
[@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mananjadhav] Determine if we should create a regression test for this bug.
[@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@peterdbarkerUK] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Sep 29, 2023
Triggered auto assignment to @peterdbarkerUK (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 29, 2023
Bug0 Triage Checklist (Main S/O)
N/A New Feature
Platformsin OP are ✅)OSBotify commentedon Sep 29, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Sep 29, 2023
Triggered auto assignment to @tylerkaraszewski (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.abdel-h66 commentedon Sep 30, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
IOU text message "Firstname paid elsewhere" does not match the copied text.
What is the root cause of that problem?
The copy action of the message
Firstname paid elsewheredoes not use the same logic as the preview.In the preview we are getting only the short form of the payer name by passing
trueas second argument togetDisplayNameForParticipantconst payerName = isExpenseReport(report) ? getPolicyName(report) : getDisplayNameForParticipant(report.managerID, true);In the copy to clipboard action, we are using almost the same logic but without the
trueflagApp/src/libs/ReportUtils.js
Line 3654 in 52f0e3c
What changes do you think we should make in order to solve the problem?
getIOUReportActionDisplayMessageresponsible to generate the text to copy, is only called in a single place, we can just update the function call to include the short form flag.What alternative solutions did you explore? (Optional)
N/A
hoangzinh commentedon Sep 30, 2023
I think it's not a real deploy blocker. It's just a small inconsistency issue, users can still copy the IOU message (with a full display name).
If we can decrease the priority of this issue, I think we can have time to fix another potential inconsistency issue between displaying the IOU message and copying the IOU message.
ReportUtils.getReportPreviewMessageutilApp/src/pages/home/report/ReportActionItemMessage.js
Lines 41 to 48 in 52f0e3c
ReportUtils.getIOUReportActionDisplayMessageutilApp/src/pages/home/report/ContextMenu/ContextMenuActions.js
Lines 202 to 203 in 52f0e3c
App/src/libs/OptionsListUtils.js
Lines 392 to 393 in 52f0e3c
11 remaining items
rayane-d commentedon Oct 1, 2023
PR ready for review
mananjadhav commentedon Oct 2, 2023
@mountiny Does this need review here?
[-]Chat - Pasted text reflects Full Display name[/-][+][HOLD for payment 2023-10-25] Chat - Pasted text reflects Full Display name[/+]melvin-bot commentedon Oct 18, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 18, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.86-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-25. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Oct 18, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
mananjadhav commentedon Oct 19, 2023
No payout for me here, I didn't review this. Unassigning myself.
mountiny commentedon Oct 19, 2023
This was already paid and this was a regression handled from here #27114