Skip to content

[HOLD for payment 2023-10-10] [HOLD for payment 2023-10-09] [$500] Android - Scan IOU - Error shows up when tapping on Capture button to take a photo #28526

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch New Expensify app.
  2. Go to + > Request money > Scan.
  3. Tap on the capture button.
  4. Close the error.
  5. Tap Give permission and allow camera access.
  6. Tap on the capture button.

Expected Result:

The image is captured

Actual Result:

An error shows up.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.75-3

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6219561_1696019114035.screen_recording_20230930_014705_new_expensify.mp4

Not repro in Production

Screen_Recording_20230930_030512_Chrome.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f80a0a462cf36708
  • Upwork Job ID: 1708859395779575808
  • Last Price Increase: 2023-10-02

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 29, 2023
  2. melvin-bot commented on Sep 29, 2023

    @melvin-bot

    Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Sep 29, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. OSBotify commented on Sep 29, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Sep 29, 2023

    @melvin-bot

    Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  6. allroundexperts commented on Sep 29, 2023

    @allroundexperts
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Android receipt scanning not working

    What is the root cause of that problem?

    The root cause of the issue is that we're supplying an extra reportId parameter here to the navigateToNextPage function. It was recently changed here and the reportID parameter was removed from the function signature.

    What changes do you think we should make in order to solve the problem?

    We just need to replace this with:

    IOU.navigateToNextPage(iou, iouType, report, route.path);
    

    What alternative solutions did you explore? (Optional)

    None

  7. tgolen commented on Sep 29, 2023

    @tgolen
    Contributor

    Thanks! This was probably during one of the many conflicts I had to fix.

  8. 34 remaining items

  9. mountiny commented on Oct 11, 2023

    @mountiny
    Contributor

    This was a simple fix after a conflict with two PRs, the author was internal and not around in time to fix this. @allroundexperts Do you accept $250 flat fee for this fix since it was quite straightforward? We appreciate the urgency.

  10. mountiny commented on Oct 11, 2023

    @mountiny
    Contributor

    @allroundexperts @fedirjh could you please complete the checklist here, thanks!

  11. fedirjh commented on Oct 11, 2023

    @fedirjh
    Contributor

    BugZero Checklist:


    Regression Test Proposal

    1. Launch New Expensify app on native.
    2. Go to + > Request money > Scan.
    3. Tap Give permission and allow camera access.
    4. Tap on the capture button.
    5. Verify that the image is captured and the user proceeds to the next step.
    • Do we agree 👍 or 👎
  12. laurenreidexpensify commented on Oct 13, 2023

    @laurenreidexpensify
    Contributor

    @mountiny can you confirm the payment amounts for both assignees so I know what to update in the payment summary? Thanks

  13. mountiny commented on Oct 15, 2023

    @mountiny
    Contributor

    I think flat $500 for both @allroundexperts and @fedirjh is what we should go with here based on how the issue was marked when proposals were given and accepted.

  14. laurenreidexpensify commented on Oct 16, 2023

    @laurenreidexpensify
    Contributor

    Payment Summary:

    • @allroundexperts $500 - please request in newdot
    • @fedirjh $500 - please apply to job in Upwork Payment issued in Upwork
  15. allroundexperts commented on Oct 18, 2023

    @allroundexperts
    Contributor

    Requested. Thanks everyone!

  16. laurenreidexpensify commented on Oct 18, 2023

    @laurenreidexpensify
    Contributor

    @fedirjh I just sent over the offer now 👍

  17. fedirjh commented on Oct 18, 2023

    @fedirjh
    Contributor

    Accepted. Thank you!

  18. JmillsExpensify commented on Oct 23, 2023

    @JmillsExpensify
    Contributor

    $500 payment approved for @allroundexperts based on summary above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions