You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-10] [HOLD for payment 2023-10-09] [$500] Android - Scan IOU - Error shows up when tapping on Capture button to take a photo #28526
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
Android receipt scanning not working
What is the root cause of that problem?
The root cause of the issue is that we're supplying an extra reportId parameter here to the navigateToNextPage function. It was recently changed here and the reportID parameter was removed from the function signature.
What changes do you think we should make in order to solve the problem?
This was a simple fix after a conflict with two PRs, the author was internal and not around in time to fix this. @allroundexperts Do you accept $250 flat fee for this fix since it was quite straightforward? We appreciate the urgency.
I think flat $500 for both @allroundexperts and @fedirjh is what we should go with here based on how the issue was marked when proposals were given and accepted.
Activity
melvin-bot commentedon Sep 29, 2023
Triggered auto assignment to @laurenreidexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 29, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)OSBotify commentedon Sep 29, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Sep 29, 2023
Triggered auto assignment to @tylerkaraszewski (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.allroundexperts commentedon Sep 29, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Android receipt scanning not working
What is the root cause of that problem?
The root cause of the issue is that we're supplying an extra
reportIdparameter here to thenavigateToNextPagefunction. It was recently changed here and thereportIDparameter was removed from the function signature.What changes do you think we should make in order to solve the problem?
We just need to replace this with:
What alternative solutions did you explore? (Optional)
None
tgolen commentedon Sep 29, 2023
Thanks! This was probably during one of the many conflicts I had to fix.
34 remaining items
mountiny commentedon Oct 11, 2023
This was a simple fix after a conflict with two PRs, the author was internal and not around in time to fix this. @allroundexperts Do you accept $250 flat fee for this fix since it was quite straightforward? We appreciate the urgency.
mountiny commentedon Oct 11, 2023
@allroundexperts @fedirjh could you please complete the checklist here, thanks!
fedirjh commentedon Oct 11, 2023
BugZero Checklist:
Regression Test Proposal
laurenreidexpensify commentedon Oct 13, 2023
@mountiny can you confirm the payment amounts for both assignees so I know what to update in the payment summary? Thanks
mountiny commentedon Oct 15, 2023
I think flat $500 for both @allroundexperts and @fedirjh is what we should go with here based on how the issue was marked when proposals were given and accepted.
laurenreidexpensify commentedon Oct 16, 2023
Payment Summary:
please apply to job in UpworkPayment issued in Upworkallroundexperts commentedon Oct 18, 2023
Requested. Thanks everyone!
laurenreidexpensify commentedon Oct 18, 2023
@fedirjh I just sent over the offer now 👍
fedirjh commentedon Oct 18, 2023
Accepted. Thank you!
JmillsExpensify commentedon Oct 23, 2023
$500 payment approved for @allroundexperts based on summary above.