You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Awaiting Checklist] [$500] Chat - Hovering menu option didn't hightlight the icon #28535
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.75.2 Reproducible in staging?: y Reproducible in production?: new feature If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
changed the title [-]Chat - Hovering menu option didn't hightlight the icon[/-][+][$500] Chat - Hovering menu option didn't hightlight the icon[/+]on Sep 30, 2023
What changes do you think we should make in order to solve the problem?
In order to keep the iconFill and still able to change color while hovering, we can add a new props called shouldAcceptHoverState to our MenuItem, if shouldAcceptHoverState is true, we will get the correct fill color for it.
getIconFillColorForMenuItem will have similar logic with getIconFillColor (will need to update the color of each state to match the design) but will early return with props.iconFill if shouldAcceptHoverState is false
What alternative solutions did you explore? (Optional)
Remove all the iconFill propperty from our threedotMenus.
changed the title [-][$500] Chat - Hovering menu option didn't hightlight the icon[/-][+][HOLD for payment 2023-10-24] [$500] Chat - Hovering menu option didn't hightlight the icon[/+]on Oct 17, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.85-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-24. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
@eVoloshchakdoes not require payment (Eligible for Manual Requests)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
[@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@eVoloshchak] Determine if we should create a regression test for this bug.
[@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2023-10-24] [$500] Chat - Hovering menu option didn't hightlight the icon[/-][+][Awaiting Checklist] [$500] Chat - Hovering menu option didn't hightlight the icon[/+]on Oct 24, 2023
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: this is a purely visual bug, I don't think an additional discussion is necessary
Determine if we should create a regression test for this bug. Is it easy to test for this bug? Yes
Is the bug related to an important user flow? Yes
Is it an impactful bug? No
While the bug isn't impactful, this is a component every user interacts with at some point, so a small regression test would be beneficial here I think
Activity
[-]Chat - Hovering menu option didn't hightlight the icon[/-][+][$500] Chat - Hovering menu option didn't hightlight the icon[/+]melvin-bot commentedon Sep 30, 2023
Triggered auto assignment to @twisterdotcom (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 30, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01afeb6d58d5ae9d6b
melvin-bot commentedon Sep 30, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Sep 30, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (
External)kbecciv commentedon Sep 30, 2023
Proposal by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695953603559579
Proposal
Please re-state the problem that we are trying to solve in this issue.
The icons from threedots menu are not highlight while hovering on it.
What is the root cause of that problem?
We added new UI in our threedots menu and adding new property
iconFillto each item:App/src/pages/home/HeaderView.js
Line 100 in 6093340
However, in our
MenuItemlogic, if we hasiconFillprops, our icon won't change the color when hovering:App/src/components/MenuItem.js
Lines 198 to 204 in 6093340
What changes do you think we should make in order to solve the problem?
In order to keep the
iconFilland still able to change color while hovering, we can add a new props calledshouldAcceptHoverStateto our MenuItem, if shouldAcceptHoverState is true, we will get the correct fill color for it.getIconFillColorForMenuItemwill have similar logic withgetIconFillColor(will need to update the color of each state to match the design) but will early return withprops.iconFillifshouldAcceptHoverStateis falseWhat alternative solutions did you explore? (Optional)
Remove all the
iconFillpropperty from our threedotMenus.neonbhai commentedon Sep 30, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Hovering menu option didn't hightlight the icon
What is the root cause of that problem?
This threedot menu is rendered by
HeaderView:The
MenuItemsinPopoverMenuare styled by default. But the styles don't get applied if we pass a static props.iconfill:App/src/components/MenuItem.js
Lines 198 to 204 in 6093340
What changes do you think we should make in order to solve the problem?
We should remove the static iconfill from the menuItem object here:
App/src/pages/home/HeaderView.js
Line 94 in 52f0e3c
Why?
This will allow the default styles to be applied:
App/src/components/MenuItem.js
Lines 198 to 204 in 6093340
Keeping the popover styles consistent in the app.
Result:
popover.webm
What alternative solutions did you explore? (Optional)
xx
neonbhai commentedon Sep 30, 2023
Proposal
Updated
Added video implementing solution.
saranshbalyan-1234 commentedon Sep 30, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Hovering menu option didn't hightlight the icon
What is the root cause of that problem?
App/src/components/MenuItem.js
Lines 198 to 204 in 52f0e3c
props.iconFill is not letting other styles apply.
What changes do you think we should make in order to solve the problem?
This way if the icon is hovered, hovered style will be applied rest normal styles will remain same.
What alternative solutions did you explore? (Optional)
N/A
35 remaining items
[-][$500] Chat - Hovering menu option didn't hightlight the icon[/-][+][HOLD for payment 2023-10-24] [$500] Chat - Hovering menu option didn't hightlight the icon[/+]melvin-bot commentedon Oct 17, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 17, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.85-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-24. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Oct 17, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
twisterdotcom commentedon Oct 24, 2023
Payment summary:
@eVoloshchak requires payment via Manual Requests - $750
@hungvu193 paid $750 here: https://www.upwork.com/nx/wm/offer/27030886 (Contributor)
[-][HOLD for payment 2023-10-24] [$500] Chat - Hovering menu option didn't hightlight the icon[/-][+][Awaiting Checklist] [$500] Chat - Hovering menu option didn't hightlight the icon[/+]eVoloshchak commentedon Oct 24, 2023
Is it easy to test for this bug? Yes
Is the bug related to an important user flow? Yes
Is it an impactful bug? No
While the bug isn't impactful, this is a component every user interacts with at some point, so a small regression test would be beneficial here I think
eVoloshchak commentedon Oct 24, 2023
Regression Test Proposal
Do we agree 👍 or 👎
twisterdotcom commentedon Oct 25, 2023
Sorted.
JmillsExpensify commentedon Nov 1, 2023
$750 payment approved for @eVoloshchak based on this summary.