Skip to content

[Awaiting Checklist] [$500] Chat - Hovering menu option didn't hightlight the icon #28535

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to any admin or announce room
  2. Click on three dot menu.
  3. Hover the options
  4. Observer the icon.

Expected Result:

Icon should be highlight when hovering

Actual Result:

Icon is not highlight when hovering

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.75.2
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-30.at.11.35.50.mov
Screen.Recording.2023-09-29.at.09.15.25.mov
Screen.Recording.2023-09-29.at.09.13.41.mov
Recording.4804.mp4

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695953603559579

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01afeb6d58d5ae9d6b
  • Upwork Job ID: 1708126153549336576
  • Last Price Increase: 2023-09-30
  • Automatic offers:
    • hungvu193 | Contributor | 27030886
    • hungvu193 | Reporter | 27030888

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 30, 2023
  2. changed the title [-]Chat - Hovering menu option didn't hightlight the icon[/-] [+][$500] Chat - Hovering menu option didn't hightlight the icon[/+] on Sep 30, 2023
  3. melvin-bot commented on Sep 30, 2023

    @melvin-bot

    Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. melvin-bot commented on Sep 30, 2023

    @melvin-bot
  5. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 30, 2023
  6. melvin-bot commented on Sep 30, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  7. melvin-bot commented on Sep 30, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

  8. kbecciv commented on Sep 30, 2023

    @kbecciv
    Author

    Proposal by: @hungvu193
    Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695953603559579

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The icons from threedots menu are not highlight while hovering on it.

    What is the root cause of that problem?

    We added new UI in our threedots menu and adding new property iconFill to each item:

    iconFill: themeColors.icon,

    However, in our MenuItem logic, if we has iconFill props, our icon won't change the color when hovering:
    fill={
    props.iconFill ||
    StyleUtils.getIconFillColor(
    getButtonState(props.focused || isHovered, pressed, props.success, props.disabled, props.interactive),
    true,
    )
    }

    What changes do you think we should make in order to solve the problem?

    In order to keep the iconFill and still able to change color while hovering, we can add a new props called shouldAcceptHoverState to our MenuItem, if shouldAcceptHoverState is true, we will get the correct fill color for it.

    fill={ 
         StyleUtils.getIconFillColorForMenuItem(props.iconFill, shouldAcceptHoverState, props.focused || isHovered, pressed, props.success, props.disabled, props.interactive) || 
         StyleUtils.getIconFillColor( 
             getButtonState(props.focused || isHovered, pressed, props.success, props.disabled, props.interactive), 
             true, 
         ) 
     } 

    getIconFillColorForMenuItem will have similar logic with getIconFillColor (will need to update the color of each state to match the design) but will early return with props.iconFill if shouldAcceptHoverState is false

    What alternative solutions did you explore? (Optional)

    Remove all the iconFill propperty from our threedotMenus.

  9. neonbhai commented on Sep 30, 2023

    @neonbhai
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Hovering menu option didn't hightlight the icon

    What is the root cause of that problem?

    This threedot menu is rendered by HeaderView:

    The MenuItems in PopoverMenu are styled by default. But the styles don't get applied if we pass a static props.iconfill:

    fill={
    props.iconFill ||
    StyleUtils.getIconFillColor(
    getButtonState(props.focused || isHovered, pressed, props.success, props.disabled, props.interactive),
    true,
    )
    }

    What changes do you think we should make in order to solve the problem?

    We should remove the static iconfill from the menuItem object here:

    const threeDotMenuItems = [];

    Why?

    This will allow the default styles to be applied:

    fill={
    props.iconFill ||
    StyleUtils.getIconFillColor(
    getButtonState(props.focused || isHovered, pressed, props.success, props.disabled, props.interactive),
    true,
    )
    }

    Keeping the popover styles consistent in the app.

    Result:

    popover.webm

    What alternative solutions did you explore? (Optional)

    xx

  10. neonbhai commented on Sep 30, 2023

    @neonbhai
    Contributor

    Proposal

    Updated

    Added video implementing solution.

  11. saranshbalyan-1234 commented on Sep 30, 2023

    @saranshbalyan-1234
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Hovering menu option didn't hightlight the icon

    What is the root cause of that problem?

    fill={
    props.iconFill ||
    StyleUtils.getIconFillColor(
    getButtonState(props.focused || isHovered, pressed, props.success, props.disabled, props.interactive),
    true,
    )
    }

    props.iconFill is not letting other styles apply.

    What changes do you think we should make in order to solve the problem?

    fill={
      isHovered || !props.iconFill ? 
        StyleUtils.getIconFillColor(
            getButtonState(props.focused || isHovered, pressed, props.success, props.disabled, props.interactive),
            true,
        ): props.iconFill
    }

    This way if the icon is hovered, hovered style will be applied rest normal styles will remain same.

    What alternative solutions did you explore? (Optional)

    N/A

  12. 35 remaining items

  13. changed the title [-][$500] Chat - Hovering menu option didn't hightlight the icon[/-] [+][HOLD for payment 2023-10-24] [$500] Chat - Hovering menu option didn't hightlight the icon[/+] on Oct 17, 2023
  14. melvin-bot commented on Oct 17, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Oct 17, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.85-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-10-24. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  16. melvin-bot commented on Oct 17, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
    • [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@eVoloshchak] Determine if we should create a regression test for this bug.
    • [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  17. twisterdotcom commented on Oct 24, 2023

    @twisterdotcom
    Contributor

    Payment summary:
    @eVoloshchak requires payment via Manual Requests - $750
    @hungvu193 paid $750 here: https://www.upwork.com/nx/wm/offer/27030886 (Contributor)

  18. changed the title [-][HOLD for payment 2023-10-24] [$500] Chat - Hovering menu option didn't hightlight the icon[/-] [+][Awaiting Checklist] [$500] Chat - Hovering menu option didn't hightlight the icon[/+] on Oct 24, 2023
  19. eVoloshchak commented on Oct 24, 2023

    @eVoloshchak
    Contributor
    • The PR that introduced the bug has been identified. Link to the PR: Move all header buttons to overflow menu #27748
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/27748/files#r1370607807
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: this is a purely visual bug, I don't think an additional discussion is necessary
    • Determine if we should create a regression test for this bug.
      Is it easy to test for this bug? Yes
      Is the bug related to an important user flow? Yes
      Is it an impactful bug? No

      While the bug isn't impactful, this is a component every user interacts with at some point, so a small regression test would be beneficial here I think
  20. eVoloshchak commented on Oct 24, 2023

    @eVoloshchak
    Contributor

    Regression Test Proposal

    1. Go to any chat
    2. Click on three-dot menu at the top right
    3. Hover over the options (or long press on mWeb and mobile).
    4. Verify that icons are highlighted when hovering (or long pressing on mWeb and mobile).

    Do we agree 👍 or 👎

  21. twisterdotcom commented on Oct 25, 2023

    @twisterdotcom
    Contributor

    Sorted.

  22. JmillsExpensify commented on Nov 1, 2023

    @JmillsExpensify
    Contributor

    $750 payment approved for @eVoloshchak based on this summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions