Skip to content

[HOLD 28358][$500] Edited currency Changes back to the previous currency #28605

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Request money within Distance
  2. Go to the IOU report page > Edit page
  3. Click on the amount
  4. Change currency and click save
  5. Go back to the IOU report page then again to the Edit page

Expected Result:

Edited currency does not Change back to the previous currency

Actual Result:

Edited currency Changes back to the previous currency

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.75-8
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

T153.Currency-1.mp4
T153mac.Currency-1.mp4
Recording.1613.mp4

Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696209699900619

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0111b151ad3cf8d7ec
  • Upwork Job ID: 1708815265481723904
  • Last Price Increase: 2023-10-02

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 2, 2023
  2. melvin-bot commented on Oct 2, 2023

    @melvin-bot

    Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Oct 2, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. OSBotify commented on Oct 2, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Oct 2, 2023

    @melvin-bot

    Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 2, 2023
  7. changed the title [-]Edited currency Changes back to the previous currency[/-] [+][$500] Edited currency Changes back to the previous currency[/+] on Oct 2, 2023
  8. melvin-bot commented on Oct 2, 2023

    @melvin-bot
  9. 9 remaining items

  10. added
    InternalRequires API changes or must be handled by Expensify staff
    on Oct 2, 2023
  11. melvin-bot commented on Oct 2, 2023

    @melvin-bot

    Current assignee @rushatgabhane is eligible for the Internal assigner, not assigning anyone new.

  12. removed
    ExternalAdded to denote the issue can be worked on by a contributor
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 2, 2023
  13. mountiny commented on Oct 2, 2023

    @mountiny
    Contributor

    This is not a deploy blocker as its a new feature. I have also confirmed the UpdateDistanceRequest API endpoint does not accept currency key: https://github.com/Expensify/Web-Expensify/blob/7cfa639d6459a9b100c179be98d8215ec0d12bbb/api.php#L3022-L3034

    @arosiclair @neil-marcellini @jasperhuangg @tgolen Is this expected? I think there is a bit more logic involved when changing the amount as we also need to update the per mile instructions so its possible this is intentional but we should probs handle this better in the App, could you please take care of this? Adding this to the wave 5 project with no status, up to you

  14. alexpensify commented on Oct 2, 2023

    @alexpensify
    Contributor

    Thanks for sharing these feeedback points @mountiny!

  15. tgolen commented on Oct 2, 2023

    @tgolen
    Contributor

    I'm going to unassign everyone from this. There is a lot of cleanup happening for distance requests and this should be covered as part of them. Primarily, #28358 is going to be splitting out the mega EditDistanceRequest API into an API for each field so that it matches the UX and a true 1:1:1 pattern. We'll need to revisit how the currency change will work along with that.

  16. changed the title [-][$500] Edited currency Changes back to the previous currency[/-] [+][HOLD 28358][$500] Edited currency Changes back to the previous currency[/+] on Oct 3, 2023
  17. neil-marcellini commented on Oct 4, 2023

    @neil-marcellini
    Contributor

    Closing as explained here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugSomething is broken. Auto assigns a BugZero manager.EngineeringInternalRequires API changes or must be handled by Expensify staffWeeklyKSv2

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions