You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD 28358][$500] Edited currency Changes back to the previous currency #28605
Go back to the IOU report page then again to the Edit page
Expected Result:
Edited currency does not Change back to the previous currency
Actual Result:
Edited currency Changes back to the previous currency
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.75-8 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-]Edited currency Changes back to the previous currency[/-][+][$500] Edited currency Changes back to the previous currency[/+]on Oct 2, 2023
@arosiclair@neil-marcellini@jasperhuangg@tgolen Is this expected? I think there is a bit more logic involved when changing the amount as we also need to update the per mile instructions so its possible this is intentional but we should probs handle this better in the App, could you please take care of this? Adding this to the wave 5 project with no status, up to you
I'm going to unassign everyone from this. There is a lot of cleanup happening for distance requests and this should be covered as part of them. Primarily, #28358 is going to be splitting out the mega EditDistanceRequest API into an API for each field so that it matches the UX and a true 1:1:1 pattern. We'll need to revisit how the currency change will work along with that.
changed the title [-][$500] Edited currency Changes back to the previous currency[/-][+][HOLD 28358][$500] Edited currency Changes back to the previous currency[/+]on Oct 3, 2023
Activity
melvin-bot commentedon Oct 2, 2023
Triggered auto assignment to @alexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Oct 2, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)OSBotify commentedon Oct 2, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Oct 2, 2023
Triggered auto assignment to @srikarparsi (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.[-]Edited currency Changes back to the previous currency[/-][+][$500] Edited currency Changes back to the previous currency[/+]melvin-bot commentedon Oct 2, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0111b151ad3cf8d7ec
9 remaining items
melvin-bot commentedon Oct 2, 2023
Current assignee @rushatgabhane is eligible for the Internal assigner, not assigning anyone new.
mountiny commentedon Oct 2, 2023
This is not a deploy blocker as its a new feature. I have also confirmed the UpdateDistanceRequest API endpoint does not accept
currencykey: https://github.com/Expensify/Web-Expensify/blob/7cfa639d6459a9b100c179be98d8215ec0d12bbb/api.php#L3022-L3034@arosiclair @neil-marcellini @jasperhuangg @tgolen Is this expected? I think there is a bit more logic involved when changing the amount as we also need to update the per mile instructions so its possible this is intentional but we should probs handle this better in the App, could you please take care of this? Adding this to the wave 5 project with no status, up to you
alexpensify commentedon Oct 2, 2023
Thanks for sharing these feeedback points @mountiny!
tgolen commentedon Oct 2, 2023
I'm going to unassign everyone from this. There is a lot of cleanup happening for distance requests and this should be covered as part of them. Primarily, #28358 is going to be splitting out the mega
EditDistanceRequestAPI into an API for each field so that it matches the UX and a true 1:1:1 pattern. We'll need to revisit how the currency change will work along with that.[-][$500] Edited currency Changes back to the previous currency[/-][+][HOLD 28358][$500] Edited currency Changes back to the previous currency[/+]neil-marcellini commentedon Oct 4, 2023
Closing as explained here