Skip to content

[PAID] [$500] LHN - Incorrect backup avatar while waiting for avatar to load #28638

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app from a fresh sign in
  2. Observe your own avatar in the top right of the LHN area

Expected Result:

I would expect this avatar to either use our fallback avatar image, or just be a solid icon fill circle like the rest of the loading avatars on the page

Actual Result:

The app displayed one of our default avatars while waiting for the correct avatar to load

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.76-0

Reproducible in staging?: Yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

image (2) (1)

2023-10-02.1.28.20.PM.1.mov

Expensify/Expensify Issue URL:

Issue reported by: @shawnborton

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696240585729759

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01fb65a5e1b63a2756
  • Upwork Job ID: 1718973678534291456
  • Last Price Increase: 2023-10-30
  • Automatic offers:
    • dukenv0307 | Contributor | 27439507

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 2, 2023
  2. dukenv0307 commented on Oct 2, 2023

    @dukenv0307
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Incorrect backup avatar while waiting for avatar to load

    What is the root cause of that problem?

    We pass the fallbackIcon as the default avatar of the user here to display if the data is loading

    fallbackIcon={currentUserPersonalDetails.fallbackIcon}

    What changes do you think we should make in order to solve the problem?

    In PressableAvatarWithIndicator we can subscribe isLoading from Onyx with key ONYXKEYS.IS_LOADING_APP. And pass this to AvatarWithIndicator

    export default withCurrentUserPersonalDetails(PressableAvatarWithIndicator);

    And in AvatarWithIndicator we will only display the View with background color themColors.skeletonLHNIn

    <View style={[styles.sidebarAvatar, props.isLoading && {backgroundColor: themeColors.skeletonLHNIn}]}>
        {!props.isLoading && (
            <>
                <Avatar
                    source={UserUtils.getSmallSizeAvatar(props.source)}
                    fallbackIcon={props.fallbackIcon}
                />
                <Indicator />
            </>
        )}
    </View>
    

    What alternative solutions did you explore? (Optional)

  3. changed the title [-]LHN - Incorrect backup avatar while waiting for avatar to load[/-] [+][$500] LHN - Incorrect backup avatar while waiting for avatar to load[/+] on Oct 2, 2023
  4. melvin-bot commented on Oct 2, 2023

    @melvin-bot
  5. melvin-bot commented on Oct 2, 2023

    @melvin-bot

    Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 2, 2023
  7. melvin-bot commented on Oct 2, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  8. melvin-bot commented on Oct 2, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @ArekChr (External)

  9. strepanier03 commented on Oct 2, 2023

    @strepanier03
    Contributor

    Able to repro:

    image
  10. strepanier03 commented on Oct 2, 2023

    @strepanier03
    Contributor

    All good to move forward. This was reported by one of our designers so they'd be the experts in expected behavior.

  11. ArekChr commented on Oct 3, 2023

    @ArekChr
    Contributor

    @strepanier03 Having a preview(thumbnail) image in base64 from the backend would be awesome as a fallback image.

  12. 62 remaining items

  13. changed the title [-][$500] LHN - Incorrect backup avatar while waiting for avatar to load[/-] [+][HOLD for payment 2023-11-22] [$500] LHN - Incorrect backup avatar while waiting for avatar to load[/+] on Nov 15, 2023
  14. melvin-bot commented on Nov 15, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Nov 15, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.99-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-11-22. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter - Internal report
    • Contributor that fixed the issue - @dukenv0307 - $500 via Upwork
    • Contributor+ that helped on the issue and/or PR - N/A Callstack

    For reference, here are some details about the assignees on this issue:

  16. melvin-bot commented on Nov 15, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ArekChr] The PR that introduced the bug has been identified. Link to the PR: No bug identified.
    • [@ArekChr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: n/a
    • [@ArekChr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: n/a
    • [@ArekChr] Determine if we should create a regression test for this bug: Yes
    • [@ArekChr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again: Done
    • [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/339563
  17. ArekChr commented on Nov 16, 2023

    @ArekChr
    Contributor
    • Link to the PR: No bug identified.
    • Link to comment: n/a
    • Link to discussion: n/a
    • Determine if we should create a regression test for this bug: We can create a simple test.

    Regression Test Proposal

    1. Open the app from a fresh sign-in
    2. Verify your avatar in the top right of the LHN area; it should show the skeleton loader as a fallback image.

    Do we agree 👍 or 👎

  18. melvin-bot commented on Nov 27, 2023

    @melvin-bot

    @youssef-lr, @strepanier03, @ArekChr, @dukenv0307 Eep! 4 days overdue now. Issues have feelings too...

  19. strepanier03 commented on Nov 27, 2023

    @strepanier03
    Contributor

    Thanks all! I was OoO last week for the holiday but am working on this now, sorry for the delay!

  20. strepanier03 commented on Nov 27, 2023

    @strepanier03
    Contributor

    This has been paid, regression test is proposed, and we're ready to close.

    Thank you all!

  21. changed the title [-][HOLD for payment 2023-11-22] [$500] LHN - Incorrect backup avatar while waiting for avatar to load[/-] [+][PAID] [$500] LHN - Incorrect backup avatar while waiting for avatar to load[/+] on Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions