You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[PAID] [$500] LHN - Incorrect backup avatar while waiting for avatar to load #28638
Observe your own avatar in the top right of the LHN area
Expected Result:
I would expect this avatar to either use our fallback avatar image, or just be a solid icon fill circle like the rest of the loading avatars on the page
Actual Result:
The app displayed one of our default avatars while waiting for the correct avatar to load
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.76-0
Reproducible in staging?: Yes
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
changed the title [-]LHN - Incorrect backup avatar while waiting for avatar to load[/-][+][$500] LHN - Incorrect backup avatar while waiting for avatar to load[/+]on Oct 2, 2023
changed the title [-][$500] LHN - Incorrect backup avatar while waiting for avatar to load[/-][+][HOLD for payment 2023-11-22] [$500] LHN - Incorrect backup avatar while waiting for avatar to load[/+]on Nov 15, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.99-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-11-22. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter - Internal report
Contributor that fixed the issue - @dukenv0307 - $500 via Upwork
Contributor+ that helped on the issue and/or PR - N/A Callstack
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@ArekChr] The PR that introduced the bug has been identified. Link to the PR: No bug identified.
[@ArekChr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: n/a
[@ArekChr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: n/a
[@ArekChr] Determine if we should create a regression test for this bug: Yes
[@ArekChr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again: Done
changed the title [-][HOLD for payment 2023-11-22] [$500] LHN - Incorrect backup avatar while waiting for avatar to load[/-][+][PAID] [$500] LHN - Incorrect backup avatar while waiting for avatar to load[/+]on Nov 27, 2023
Activity
dukenv0307 commentedon Oct 2, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Incorrect backup avatar while waiting for avatar to load
What is the root cause of that problem?
We pass the
fallbackIconas the default avatar of the user here to display if the data is loadingApp/src/pages/home/sidebar/PressableAvatarWithIndicator.js
Line 55 in 05aa0c3
What changes do you think we should make in order to solve the problem?
In
PressableAvatarWithIndicatorwe can subscribeisLoadingfrom Onyx with keyONYXKEYS.IS_LOADING_APP. And pass this toAvatarWithIndicatorApp/src/pages/home/sidebar/PressableAvatarWithIndicator.js
Line 65 in c81a509
And in
AvatarWithIndicatorwe will only display theViewwith background colorthemColors.skeletonLHNInWhat alternative solutions did you explore? (Optional)
[-]LHN - Incorrect backup avatar while waiting for avatar to load[/-][+][$500] LHN - Incorrect backup avatar while waiting for avatar to load[/+]melvin-bot commentedon Oct 2, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01702f576387e8afe4
melvin-bot commentedon Oct 2, 2023
Triggered auto assignment to @strepanier03 (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Oct 2, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Oct 2, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ArekChr (
External)strepanier03 commentedon Oct 2, 2023
Able to repro:
strepanier03 commentedon Oct 2, 2023
All good to move forward. This was reported by one of our designers so they'd be the experts in expected behavior.
ArekChr commentedon Oct 3, 2023
@strepanier03 Having a preview(thumbnail) image in base64 from the backend would be awesome as a fallback image.
62 remaining items
[-][$500] LHN - Incorrect backup avatar while waiting for avatar to load[/-][+][HOLD for payment 2023-11-22] [$500] LHN - Incorrect backup avatar while waiting for avatar to load[/+]melvin-bot commentedon Nov 15, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Nov 15, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.99-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-11-22. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 15, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
ArekChr commentedon Nov 16, 2023
Regression Test Proposal
Do we agree 👍 or 👎
melvin-bot commentedon Nov 27, 2023
@youssef-lr, @strepanier03, @ArekChr, @dukenv0307 Eep! 4 days overdue now. Issues have feelings too...
strepanier03 commentedon Nov 27, 2023
Thanks all! I was OoO last week for the holiday but am working on this now, sorry for the delay!
strepanier03 commentedon Nov 27, 2023
This has been paid, regression test is proposed, and we're ready to close.
Thank you all!
[-][HOLD for payment 2023-11-22] [$500] LHN - Incorrect backup avatar while waiting for avatar to load[/-][+][PAID] [$500] LHN - Incorrect backup avatar while waiting for avatar to load[/+]