You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-02-20] [LOW] Drafts: Migrate the next steps to client side wherever it makes sense #28771
changed the title [-]Wave6 - Drafts - Migrate the next steps to client side wherever it makes sense[/-][+][Wave 6: Drafts] Migrate the next steps to client side wherever it makes sense[/+]on Oct 4, 2023
Yeah I think we actually can focus on other stuff which brings us more value than this right now. That means I would consider closing this issue for now
@mallenexpensify Yep, we'll have to create a new one. The test steps given in the PR description here look comprehensive enough to me. Let me know if you need any help with those.
On a side note, this PR caused a bug so the payment should technically be 1/2. Although, I think this was a complex PR which took me some time to review, so if we can waive the penalty, that would be great. Please let me know.
I think that we should not decrease payment because of that. The Cancel Payment was a new feature added along with this so it was hard to notice regression like this
Activity
[-]Wave6 - Drafts - Migrate the next steps to client side wherever it makes sense[/-][+][Wave 6: Drafts] Migrate the next steps to client side wherever it makes sense[/+]greg-schroeder commentedon Nov 13, 2023
I think this one might go to @rezkiy37 per slack discussion
greg-schroeder commentedon Nov 20, 2023
Can you comment on this issue @rezkiy37?
rezkiy37 commentedon Nov 21, 2023
Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.
rezkiy37 commentedon Nov 21, 2023
it is still a general issue and does not require any actions now. Slack thread.
mountiny commentedon Nov 21, 2023
Yeah I think we actually can focus on other stuff which brings us more value than this right now. That means I would consider closing this issue for now
greg-schroeder commentedon Nov 27, 2023
Let's close this for now.
mountiny commentedon Jan 4, 2024
Repening now as we are in spot where this makes more sense
62 remaining items
melvin-bot commentedon Feb 20, 2024
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Feb 21, 2024
Contributor+: @allroundexperts owed $500 via NewDot
Do we need to update or create a new regression test here? Seems like we might want a new one?
allroundexperts commentedon Feb 21, 2024
@mallenexpensify Yep, we'll have to create a new one. The test steps given in the PR description here look comprehensive enough to me. Let me know if you need any help with those.
mountiny commentedon Feb 21, 2024
Yep I think we should create new ones here, I have asked @rezkiy37 if he could clean them up for the regression testing purpose
allroundexperts commentedon Feb 21, 2024
On a side note, this PR caused a bug so the payment should technically be 1/2. Although, I think this was a complex PR which took me some time to review, so if we can waive the penalty, that would be great. Please let me know.
mountiny commentedon Feb 21, 2024
I think that we should not decrease payment because of that. The Cancel Payment was a new feature added along with this so it was hard to notice regression like this
mountiny commentedon Feb 21, 2024
@mallenexpensify Michal has actually already written the tests here #28771 (comment)
mallenexpensify commentedon Feb 23, 2024
Thanks all! We should be set. TestRail GH is here
JmillsExpensify commentedon Mar 2, 2024
$500 approved for @allroundexperts based on this summary.