Skip to content

[HOLD for payment 2024-02-20] [LOW] Drafts: Migrate the next steps to client side wherever it makes sense #28771

Closed

Description

@mountiny

Part of https://github.com/Expensify/Expensify/issues/308213

Coming from here in the doc, we are planning to migrate some of the next steps which make sense to do so to be client side/ optimistic.

Activity

  1. changed the title [-]Wave6 - Drafts - Migrate the next steps to client side wherever it makes sense[/-] [+][Wave 6: Drafts] Migrate the next steps to client side wherever it makes sense[/+] on Oct 4, 2023
  2. greg-schroeder commented on Nov 13, 2023

    @greg-schroeder
    Contributor

    I think this one might go to @rezkiy37 per slack discussion

  3. greg-schroeder commented on Nov 20, 2023

    @greg-schroeder
    Contributor

    Can you comment on this issue @rezkiy37?

  4. rezkiy37 commented on Nov 21, 2023

    @rezkiy37
    Contributor

    Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

  5. rezkiy37 commented on Nov 21, 2023

    @rezkiy37
    Contributor

    it is still a general issue and does not require any actions now. Slack thread.

  6. mountiny commented on Nov 21, 2023

    @mountiny
    ContributorAuthor

    Yeah I think we actually can focus on other stuff which brings us more value than this right now. That means I would consider closing this issue for now

  7. greg-schroeder commented on Nov 27, 2023

    @greg-schroeder
    Contributor

    Let's close this for now.

  8. mountiny commented on Jan 4, 2024

    @mountiny
    ContributorAuthor

    Repening now as we are in spot where this makes more sense

  9. 62 remaining items

  10. melvin-bot commented on Feb 20, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  11. mallenexpensify commented on Feb 21, 2024

    @mallenexpensify
    Contributor

    Contributor+: @allroundexperts owed $500 via NewDot

    Do we need to update or create a new regression test here? Seems like we might want a new one?

  12. allroundexperts commented on Feb 21, 2024

    @allroundexperts
    Contributor

    @mallenexpensify Yep, we'll have to create a new one. The test steps given in the PR description here look comprehensive enough to me. Let me know if you need any help with those.

  13. mountiny commented on Feb 21, 2024

    @mountiny
    ContributorAuthor

    Yep I think we should create new ones here, I have asked @rezkiy37 if he could clean them up for the regression testing purpose

  14. allroundexperts commented on Feb 21, 2024

    @allroundexperts
    Contributor

    On a side note, this PR caused a bug so the payment should technically be 1/2. Although, I think this was a complex PR which took me some time to review, so if we can waive the penalty, that would be great. Please let me know.

  15. mountiny commented on Feb 21, 2024

    @mountiny
    ContributorAuthor

    I think that we should not decrease payment because of that. The Cancel Payment was a new feature added along with this so it was hard to notice regression like this

  16. mountiny commented on Feb 21, 2024

    @mountiny
    ContributorAuthor

    @mallenexpensify Michal has actually already written the tests here #28771 (comment)

  17. mallenexpensify commented on Feb 23, 2024

    @mallenexpensify
    Contributor

    Thanks all! We should be set. TestRail GH is here

  18. JmillsExpensify commented on Mar 2, 2024

    @JmillsExpensify
    Contributor

    $500 approved for @allroundexperts based on this summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2NewFeatureSomething to build that is a new item.

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions