Skip to content

[HOLD for payment 2024-01-24] [$250] Workspace members - Members deleted offline are not crossed out #28807

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the App
  2. Login with account
  3. Go to Settings -> Workspace -> Open any WS -> Invite several members
  4. Turn off the internet connection
  5. Delete WS member

Expected Result:

Members deleted offline crossed out

Actual Result:

Members deleted offline are not crossed out

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: v1.3.77-2

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6224496_1696416059346.Record_2023-10-03-23-20-42_4f9154176b47c00da84e32064abf1c48.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016d912d0feb7321c7
  • Upwork Job ID: 1709541114926034944
  • Last Price Increase: 2023-10-18
  • Automatic offers:
    • hoangzinh | Reviewer | 27291935

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 4, 2023
  2. changed the title [-]Android - Workspace members - Members deleted offline are not crossed out[/-] [+][$500] Android - Workspace members - Members deleted offline are not crossed out[/+] on Oct 4, 2023
  3. melvin-bot commented on Oct 4, 2023

    @melvin-bot
  4. melvin-bot commented on Oct 4, 2023

    @melvin-bot

    Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  5. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 4, 2023
  6. melvin-bot commented on Oct 4, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  7. melvin-bot commented on Oct 4, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

  8. izarutskaya commented on Oct 4, 2023

    @izarutskaya
    Author

    Not repro on Prod

    Screen_Recording_20231004_110047_New.Expensify.mp4
  9. 121 remaining items

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jan 17, 2024
  11. changed the title [-][$250] Workspace members - Members deleted offline are not crossed out[/-] [+][HOLD for payment 2024-01-24] [$250] Workspace members - Members deleted offline are not crossed out[/+] on Jan 17, 2024
  12. melvin-bot commented on Jan 17, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Jan 17, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.25-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-01-24. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Jan 17, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@hoangzinh] The PR that introduced the bug has been identified. Link to the PR:
    • [@hoangzinh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@hoangzinh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@hoangzinh] Determine if we should create a regression test for this bug.
    • [@hoangzinh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  15. miljakljajic commented on Jan 22, 2024

    @miljakljajic
    Contributor

    @hoangzinh I sent you a new offer, the previous one expired. Accept it when you can so I can pay promptly on the 24th!

  16. miljakljajic commented on Jan 22, 2024

    @miljakljajic
    Contributor
  17. hoangzinh commented on Jan 22, 2024

    @hoangzinh
    Contributor

    Regression Test Proposal

    1. Sign in to any account
    2. Create a workspace if the user doesn't have any workspace yet.
    3. Go to Settings -> Workspace -> Open any workspace -> Invite a member
    4. Turn off the internet connection
    5. Remove a member in that workspace
    6. Verify that the member being deleted in step (5) becomes crossed out.

    Do we agree 👍 or 👎

  18. hoangzinh commented on Jan 22, 2024

    @hoangzinh
    Contributor

    BugZero Checklist:

  19. miljakljajic commented on Jan 24, 2024

    @miljakljajic
    Contributor

    Paid and closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringInternalRequires API changes or must be handled by Expensify staffWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions