You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[PAID] [HOLD for payment 2023-10-13] [$250] Distance - App crashes when clicking "Replace" while replacing images in IOU. #28909
Open FAB and select "Request Money" in Distance Mode.
Add start and end points, create a workspace, and split the bill.
Go to IOU, click on the map image, and select the three dots in the top right corner. From the dropdown, select "Replace".
The app crashes.
Expected Result:
The app should not crash when replacing images in IOU.
Actual Result:
App crashes when clicking "Replace" while replacing images in IOU.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.78.0 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
changed the title [-]Distance - App crashes when clicking "Replace" while replacing images in IOU.[/-][+][$500] Distance - App crashes when clicking "Replace" while replacing images in IOU.[/+]on Oct 5, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-][HOLD for payment 2023-10-13] [$250] Distance - App crashes when clicking "Replace" while replacing images in IOU.[/-][+][HOLD for payment 2023-10-16] [HOLD for payment 2023-10-13] [$250] Distance - App crashes when clicking "Replace" while replacing images in IOU.[/+]on Oct 9, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.79-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-16. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@mountiny] The PR that introduced the bug has been identified. Link to the PR:
[@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mountiny] Determine if we should create a regression test for this bug.
[@mountiny] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2023-10-16] [HOLD for payment 2023-10-13] [$250] Distance - App crashes when clicking "Replace" while replacing images in IOU.[/-][+][PAID] [HOLD for payment 2023-10-13] [$250] Distance - App crashes when clicking "Replace" while replacing images in IOU.[/+]on Oct 17, 2023
Activity
gadhiyamanan commentedon Oct 5, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
App crashes on click of "Replace"
What is the root cause of that problem?
We are using wrong route here
What changes do you think we should make in order to solve the problem?
use ROUTES.EDIT_REQUEST.getRoute instead of ROUTES.getEditRequestRoute
App/src/components/AttachmentModal.js
Line 351 in 1eae800
[-]Distance - App crashes when clicking "Replace" while replacing images in IOU.[/-][+][$500] Distance - App crashes when clicking "Replace" while replacing images in IOU.[/+]melvin-bot commentedon Oct 5, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01324cd349c7f43f8b
melvin-bot commentedon Oct 5, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (
External)OSBotify commentedon Oct 5, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Oct 5, 2023
Current assignee @mountiny is eligible for the Engineering assigner, not assigning anyone new.
21 remaining items
[-][HOLD for payment 2023-10-13] [$250] Distance - App crashes when clicking "Replace" while replacing images in IOU.[/-][+][HOLD for payment 2023-10-16] [HOLD for payment 2023-10-13] [$250] Distance - App crashes when clicking "Replace" while replacing images in IOU.[/+]melvin-bot commentedon Oct 9, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.79-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-16. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Oct 9, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
mountiny commentedon Oct 9, 2023
No regression test required here, this offending PR was identified and fixed promptly as this was a deploy blocker.
@strepanier03 only pending item on this issue is to pay $50 to @tewodrosGirmaA thank you
strepanier03 commentedon Oct 16, 2023
@tewodrosGirmaA - I have hired you in Upwork and will check for payout later today.
tewodrosGirmaA commentedon Oct 16, 2023
@strepanier03 , I accepted the offer , Thank you
[-][HOLD for payment 2023-10-16] [HOLD for payment 2023-10-13] [$250] Distance - App crashes when clicking "Replace" while replacing images in IOU.[/-][+][PAID] [HOLD for payment 2023-10-13] [$250] Distance - App crashes when clicking "Replace" while replacing images in IOU.[/+]strepanier03 commentedon Oct 17, 2023
Thank you @tewodrosGirmaA - I've paid you via Upwork and closed the contract. Thanks for being part of the community!