Skip to content

[PAID] [HOLD for payment 2023-10-13] [$250] Distance - App crashes when clicking "Replace" while replacing images in IOU. #28909

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open FAB and select "Request Money" in Distance Mode.
  2. Add start and end points, create a workspace, and split the bill.
  3. Go to IOU, click on the map image, and select the three dots in the top right corner. From the dropdown, select "Replace".
  4. The app crashes.

Expected Result:

The app should not crash when replacing images in IOU.

Actual Result:

App crashes when clicking "Replace" while replacing images in IOU.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.78.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-10-04.at.9.29.43.PM.mov
Recorder_05102023_072040.mp4
Screen.Recording.2023-10-04.at.9.17.26.PM.mov
Screen.Recording.2023-10-04.at.9.14.49.PM.mov
Screen.Recording.2023-10-04.at.9.03.24.PM.mov
Screen.Recording.2023-10-04.at.8.56.54.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @tewodrosGirmaA
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696478163356909

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01324cd349c7f43f8b
  • Upwork Job ID: 1709905823974797312
  • Last Price Increase: 2023-10-05

Activity

  1. gadhiyamanan commented on Oct 5, 2023

    @gadhiyamanan
    Contributor

    Proposal



    Please re-state the problem that we are trying to solve in this issue.

    
App crashes on click of "Replace"

    What is the root cause of that problem?

    We are using wrong route here

    What changes do you think we should make in order to solve the problem?


    use ROUTES.EDIT_REQUEST.getRoute instead of ROUTES.getEditRequestRoute



    onModalHideCallbackRef.current = () => Navigation.navigate(ROUTES.getEditRequestRoute(props.report.reportID, CONST.EDIT_REQUEST_FIELD.RECEIPT));

  2. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 5, 2023
  3. self-assigned this
    on Oct 5, 2023
  4. changed the title [-]Distance - App crashes when clicking "Replace" while replacing images in IOU.[/-] [+][$500] Distance - App crashes when clicking "Replace" while replacing images in IOU.[/+] on Oct 5, 2023
  5. melvin-bot commented on Oct 5, 2023

    @melvin-bot
  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 5, 2023
  7. melvin-bot commented on Oct 5, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

  8. OSBotify commented on Oct 5, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  9. melvin-bot commented on Oct 5, 2023

    @melvin-bot

    Current assignee @mountiny is eligible for the Engineering assigner, not assigning anyone new.

  10. 21 remaining items

  11. changed the title [-][HOLD for payment 2023-10-13] [$250] Distance - App crashes when clicking "Replace" while replacing images in IOU.[/-] [+][HOLD for payment 2023-10-16] [HOLD for payment 2023-10-13] [$250] Distance - App crashes when clicking "Replace" while replacing images in IOU.[/+] on Oct 9, 2023
  12. melvin-bot commented on Oct 9, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.79-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-10-16. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter - @tewodrosGirmaA - $50 via Upwork
    • Contributor that fixed the issue - N/A
    • Contributor+ that helped on the issue and/or PR - N/A

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  13. melvin-bot commented on Oct 9, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
    • [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@mountiny] Determine if we should create a regression test for this bug.
    • [@mountiny] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  14. mountiny commented on Oct 9, 2023

    @mountiny
    Contributor

    No regression test required here, this offending PR was identified and fixed promptly as this was a deploy blocker.

    @strepanier03 only pending item on this issue is to pay $50 to @tewodrosGirmaA thank you

  15. strepanier03 commented on Oct 16, 2023

    @strepanier03
    Contributor

    @tewodrosGirmaA - I have hired you in Upwork and will check for payout later today.

  16. tewodrosGirmaA commented on Oct 16, 2023

    @tewodrosGirmaA

    @strepanier03 , I accepted the offer , Thank you

  17. changed the title [-][HOLD for payment 2023-10-16] [HOLD for payment 2023-10-13] [$250] Distance - App crashes when clicking "Replace" while replacing images in IOU.[/-] [+][PAID] [HOLD for payment 2023-10-13] [$250] Distance - App crashes when clicking "Replace" while replacing images in IOU.[/+] on Oct 17, 2023
  18. strepanier03 commented on Oct 17, 2023

    @strepanier03
    Contributor

    Thank you @tewodrosGirmaA - I've paid you via Upwork and closed the contract. Thanks for being part of the community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions