You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-18] [$500] Chat - Despite deleting the workspace, users still have access to Zoom and Google Meeting. #28959
If the workspace is not created, create a new one.
Delete the workspace by clicking on the three dots in the top right corner.
Go to admin> click on the three dots in the top right corner>Observe that the user still has access to Zoom and Google Meetings.
Expected Result:
After deleting the workspace, users should no longer have access to Zoom and Google Meeting
Actual Result:
Even after deleting the workspace, users still have access to Zoom and Google Meetings.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.78.0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
changed the title [-]Chat - Despite deleting the workspace, users still have access to Zoom and Google Meeting.[/-][+][$500] Chat - Despite deleting the workspace, users still have access to Zoom and Google Meeting.[/+]on Oct 5, 2023
Please re-state the problem that we are trying to solve in this issue.
Even after deleting workspace, users still have access to Zoom and Google Meeting
What is the root cause of that problem?
We are checking whether the workspace has been deleted or not while showing the google meet and zoom in the menu.
Below is the code which explains this
We can also add or remove these icons based upon the ARCHIVE_REASON, like for which archive reason to hide or for which to show according to the UX, which can be discussed.
What alternative solutions did you explore? (Optional)
@abzokhattab was assigned to the issue on 2023-10-06, and the PR was merged the same day, so this is eligible for a speed bonus. This means we need to pay:
@abzokhattab - $750 ($500 for PR and $250 speed bonus). Paid via Upwork.
@Ollyws - $750 ($500 for C+ and $250 speed bonus). Paid via Upwork.
BugZero Checklist:
This isn't a regression from any PR because as far as I can see, even before the call button was moved to the three dots menu there was no condition for not showing it on archived rooms. So it's more of a new feature.
I don't think a regression test would be helpful here as it doesn't affect any important flow nor is it very impacful.
Activity
melvin-bot commentedon Oct 5, 2023
Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.[-]Chat - Despite deleting the workspace, users still have access to Zoom and Google Meeting.[/-][+][$500] Chat - Despite deleting the workspace, users still have access to Zoom and Google Meeting.[/+]melvin-bot commentedon Oct 5, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0169223f940da2f148
melvin-bot commentedon Oct 5, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)abzokhattab commentedon Oct 5, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Even after the workspace is deleted, users still have access to Zoom and Google Meeting items in the menu chat.
What is the root cause of that problem?
we don't check if the current room is archived or not when displaying the Zoom and Google meeting items in the menu
App/src/pages/home/HeaderView.js
Line 163 in 25f7ac1
What changes do you think we should make in order to solve the problem?
add a condition to check if the current room is not archived before showing those items
and the line above to:
this way the Google and Zoom items will be shown in case the room is not archived
POC
Screen.Recording.2023-10-05.at.12.06.08.PM.mov
melvin-bot commentedon Oct 5, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (
External)saranshbalyan-1234 commentedon Oct 5, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Even after deleting workspace, users still have access to Zoom and Google Meeting
What is the root cause of that problem?
We are checking whether the workspace has been deleted or not while showing the google meet and zoom in the menu.
Below is the code which explains this
App/src/pages/home/HeaderView.js
Lines 162 to 179 in 42e2247
What changes do you think we should make in order to solve the problem?
we need to add this code to withOnyx HOC first
and then add this same to the condition where we are pushing google meet and zoom link menu like this
We can also add or remove these icons based upon the ARCHIVE_REASON, like for which archive reason to hide or for which to show according to the UX, which can be discussed.
What alternative solutions did you explore? (Optional)
N/A
DylanDylann commentedon Oct 5, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Despite deleting the workspace, users still have access to Zoom and Google Meeting.
What is the root cause of that problem?
Currently, in
App/src/pages/home/HeaderView.js
Line 163 in 25f7ac1
isAutomatedExpensifyAccountand notisTaskReportWhat changes do you think we should make in order to solve the problem?
In function
HeaderViewadd check report is archived roomAnd add this to this condition
What alternative solutions did you explore? (Optional)
Result
Ollyws commentedon Oct 6, 2023
The first proposal by @abzokhattab looks good to me.
🎀👀🎀 C+ reviewed
21 remaining items
joekaufmanexpensify commentedon Oct 16, 2023
@Ollyws could you please take care of the BZ checklist so we can prep to issue payment here?
joekaufmanexpensify commentedon Oct 17, 2023
@abzokhattab was assigned to the issue on 2023-10-06, and the PR was merged the same day, so this is eligible for a speed bonus. This means we need to pay:
joekaufmanexpensify commentedon Oct 17, 2023
@Ollyws offer sent for $500 ($250 will be added as bonus)!
joekaufmanexpensify commentedon Oct 17, 2023
@abzokhattab offer sent for $500 ($250 will be added as bonus)!
joekaufmanexpensify commentedon Oct 17, 2023
@tewodrosGirmaA offer sent for $50!
Ollyws commentedon Oct 17, 2023
BugZero Checklist:
This isn't a regression from any PR because as far as I can see, even before the call button was moved to the three dots menu there was no condition for not showing it on archived rooms. So it's more of a new feature.
I don't think a regression test would be helpful here as it doesn't affect any important flow nor is it very impacful.
joekaufmanexpensify commentedon Oct 18, 2023
TY! BZ checklist is complete. All set to issue payment.
joekaufmanexpensify commentedon Oct 18, 2023
@abzokhattab $750 sent and contract ended!
joekaufmanexpensify commentedon Oct 18, 2023
@Ollyws $750 sent and contract ended!
joekaufmanexpensify commentedon Oct 18, 2023
@tewodrosGirmaA $50 sent and contract ended!
joekaufmanexpensify commentedon Oct 18, 2023
Closed upwork job
joekaufmanexpensify commentedon Oct 18, 2023
Bug is fixed, BZ checklist complete, and all payment issued. Closing as this is all set. Thanks everyone!