Skip to content

[HOLD for payment 2023-10-18] [$500] Chat - Despite deleting the workspace, users still have access to Zoom and Google Meeting. #28959

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to Settings and select Workspace.
  2. If the workspace is not created, create a new one.
  3. Delete the workspace by clicking on the three dots in the top right corner.
  4. Go to admin> click on the three dots in the top right corner>Observe that the user still has access to Zoom and Google Meetings.

Expected Result:

After deleting the workspace, users should no longer have access to Zoom and Google Meeting

Actual Result:

Even after deleting the workspace, users still have access to Zoom and Google Meetings.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.78.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recorder_05102023_095607.mp4
Screen.Recording.2023-10-04.at.11.46.49.PM.mov
Screen.Recording.2023-10-04.at.11.49.48.PM.mov
Screen.Recording.2023-10-04.at.11.48.01.PM.mov
Screen.Recording.2023-10-04.at.11.45.28.PM.mov
Screen.Recording.2023-10-04.at.11.40.54.PM.mov
Recording.4862.mp4

Expensify/Expensify Issue URL:
Issue reported by: @tewodrosGirmaA
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696487761131489

View all open jobs on GitHub

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 5, 2023
  2. melvin-bot commented on Oct 5, 2023

    @melvin-bot

    Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. changed the title [-]Chat - Despite deleting the workspace, users still have access to Zoom and Google Meeting.[/-] [+][$500] Chat - Despite deleting the workspace, users still have access to Zoom and Google Meeting.[/+] on Oct 5, 2023
  4. melvin-bot commented on Oct 5, 2023

    @melvin-bot
  5. melvin-bot commented on Oct 5, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  6. abzokhattab commented on Oct 5, 2023

    @abzokhattab
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Even after the workspace is deleted, users still have access to Zoom and Google Meeting items in the menu chat.

    What is the root cause of that problem?

    we don't check if the current room is archived or not when displaying the Zoom and Google meeting items in the menu

    } else if (!isAutomatedExpensifyAccount && !isTaskReport) {

    What changes do you think we should make in order to solve the problem?

    add a condition to check if the current room is not archived before showing those items

    const isArchivedRoom = ReportUtils.isArchivedRoom(props.report);

    and the line above to:

        } else if (!isAutomatedExpensifyAccount && !isTaskReport && !isArchivedRoom) {

    this way the Google and Zoom items will be shown in case the room is not archived

    POC

    Screen.Recording.2023-10-05.at.12.06.08.PM.mov
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 5, 2023
  8. melvin-bot commented on Oct 5, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

  9. saranshbalyan-1234 commented on Oct 5, 2023

    @saranshbalyan-1234
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Even after deleting workspace, users still have access to Zoom and Google Meeting

    What is the root cause of that problem?

    We are checking whether the workspace has been deleted or not while showing the google meet and zoom in the menu.
    Below is the code which explains this

    } else if (!isAutomatedExpensifyAccount && !isTaskReport) {
    threeDotMenuItems.push({
    icon: ZoomIcon,
    iconFill: themeColors.icon,
    text: props.translate('videoChatButtonAndMenu.zoom'),
    onSelected: () => {
    Link.openExternalLink(CONST.NEW_ZOOM_MEETING_URL);
    },
    });
    threeDotMenuItems.push({
    icon: GoogleMeetIcon,
    iconFill: themeColors.icon,
    text: props.translate('videoChatButtonAndMenu.googleMeet'),
    onSelected: () => {
    Link.openExternalLink(CONST.NEW_GOOGLE_MEET_MEETING_URL);
    },
    });
    }

    What changes do you think we should make in order to solve the problem?

    we need to add this code to withOnyx HOC first

        withOnyx({
            reportClosedAction: {
                key: ({report}) => `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report.reportID}`,
                canEvict: false,
                selector: ReportActionsUtils.getLastClosedReportAction,
            },

    and then add this same to the condition where we are pushing google meet and zoom link menu like this

    if (!isAutomatedExpensifyAccount && !isTaskReport && !props.reportClosedAction) {
            threeDotMenuItems.push({
                icon: ZoomIcon,
                iconFill: themeColors.icon,
                text: props.translate('videoChatButtonAndMenu.zoom'),
                onSelected: () => {
                    Link.openExternalLink(CONST.NEW_ZOOM_MEETING_URL);
                },
            });
            threeDotMenuItems.push({
                icon: GoogleMeetIcon,
                iconFill: themeColors.icon,
                text: props.translate('videoChatButtonAndMenu.googleMeet'),
                onSelected: () => {
                    Link.openExternalLink(CONST.NEW_GOOGLE_MEET_MEETING_URL);
                },
            });
        }

    We can also add or remove these icons based upon the ARCHIVE_REASON, like for which archive reason to hide or for which to show according to the UX, which can be discussed.

    What alternative solutions did you explore? (Optional)

    N/A

  10. DylanDylann commented on Oct 5, 2023

    @DylanDylann
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Despite deleting the workspace, users still have access to Zoom and Google Meeting.

    What is the root cause of that problem?

    Currently, in

    } else if (!isAutomatedExpensifyAccount && !isTaskReport) {
    We just render the Zoom and GG meet link when it's not isAutomatedExpensifyAccount and not isTaskReport

    What changes do you think we should make in order to solve the problem?

    In function HeaderView add check report is archived room

        const isArchivedRoom = ReportUtils.isArchivedRoom(props.report);
    

    And add this to this condition

    else if (!isAutomatedExpensifyAccount && !isTaskReport && !isArchivedRoom) {
            threeDotMenuItems.push({
                icon: ZoomIcon,
               ...
                },
            });
            threeDotMenuItems.push({
                icon: GoogleMeetIcon,
               ...
                }),
    }
    

    What alternative solutions did you explore? (Optional)

    • NA

    Result

    Screenshot 2023-10-05 at 17 43 04
  11. Ollyws commented on Oct 6, 2023

    @Ollyws
    Contributor

    The first proposal by @abzokhattab looks good to me.
    🎀👀🎀 C+ reviewed

  12. 21 remaining items

  13. joekaufmanexpensify commented on Oct 16, 2023

    @joekaufmanexpensify
    Contributor

    @Ollyws could you please take care of the BZ checklist so we can prep to issue payment here?

  14. joekaufmanexpensify commented on Oct 17, 2023

    @joekaufmanexpensify
    Contributor

    @abzokhattab was assigned to the issue on 2023-10-06, and the PR was merged the same day, so this is eligible for a speed bonus. This means we need to pay:

    • @abzokhattab - $750 ($500 for PR and $250 speed bonus). Paid via Upwork.
    • @Ollyws - $750 ($500 for C+ and $250 speed bonus). Paid via Upwork.
    • @tewodrosGirmaA - $50 for reporting. Paid via upwork.
  15. joekaufmanexpensify commented on Oct 17, 2023

    @joekaufmanexpensify
    Contributor

    @Ollyws offer sent for $500 ($250 will be added as bonus)!

  16. joekaufmanexpensify commented on Oct 17, 2023

    @joekaufmanexpensify
    Contributor

    @abzokhattab offer sent for $500 ($250 will be added as bonus)!

  17. joekaufmanexpensify commented on Oct 17, 2023

    @joekaufmanexpensify
    Contributor

    @tewodrosGirmaA offer sent for $50!

  18. Ollyws commented on Oct 17, 2023

    @Ollyws
    Contributor

    BugZero Checklist:
    This isn't a regression from any PR because as far as I can see, even before the call button was moved to the three dots menu there was no condition for not showing it on archived rooms. So it's more of a new feature.
    I don't think a regression test would be helpful here as it doesn't affect any important flow nor is it very impacful.

  19. joekaufmanexpensify commented on Oct 18, 2023

    @joekaufmanexpensify
    Contributor

    TY! BZ checklist is complete. All set to issue payment.

  20. joekaufmanexpensify commented on Oct 18, 2023

    @joekaufmanexpensify
    Contributor

    @abzokhattab $750 sent and contract ended!

  21. joekaufmanexpensify commented on Oct 18, 2023

    @joekaufmanexpensify
    Contributor

    @Ollyws $750 sent and contract ended!

  22. joekaufmanexpensify commented on Oct 18, 2023

    @joekaufmanexpensify
    Contributor

    @tewodrosGirmaA $50 sent and contract ended!

  23. joekaufmanexpensify commented on Oct 18, 2023

    @joekaufmanexpensify
    Contributor

    Closed upwork job

  24. joekaufmanexpensify commented on Oct 18, 2023

    @joekaufmanexpensify
    Contributor

    Bug is fixed, BZ checklist complete, and all payment issued. Closing as this is all set. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions