You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-31] [HOLD for payment 2023-10-30] [$500] Scroll is not working properly on the distance detail page, it sometimes gets stuck when scrolling up and down #29038
Select Start and Finish points and proceed with the request.
Navigate to the distance detail page.
Attempt to scroll up and down the page
Expected Result:
The page should smoothly scroll up and down without getting stuck
Actual Result:
Scrolling is not properly, and the page sometimes gets stuck when scrolling on the distance detail page
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.79-3 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
changed the title [-] Scroll is not working properly on the distance detail page, it sometimes gets stuck when scrolling up and down[/-][+][$500] Scroll is not working properly on the distance detail page, it sometimes gets stuck when scrolling up and down[/+]on Oct 6, 2023
The style StyleUtils.getMinimumHeight(CONST.EMPTY_STATE_BACKGROUND.MONEY_REPORT.MIN_HEIGHT) is setting min height of 250 regardless of the devices causing the container becoming small and assumes there is not room to scroll down
What changes do you think we should make in order to solve the problem?
I suggest removing the StyleUtils.getMinimumHeight(CONST.EMPTY_STATE_BACKGROUND.MONEY_REPORT.MIN_HEIGHT) as it overridesStyleUtils.getReportWelcomeContainerStyle(props.isSmallScreenWidth) that is more device size friendly instead of forcing the minHeight to be CONST.EMPTY_STATE_BACKGROUND.MONEY_REPORT.MIN_HEIGHT .
What alternative solutions did you explore? (Optional)
The issue comes partially from the AnimatedEmptyStateBackground component that ignores all pointerEvents. Including the scroll event. Somehow, setting it to auto or at least to box-none fixed the issue.
Please re-state the problem that we are trying to solve in this issue.
Scroll is not working properly on the Money request view page.
What is the root cause of that problem?
The root cause of the issue is that we're defining a min height for the empty state background image container without adding a appropriate margin on the child components in MoneyRequestView and MoneyReportView components.
What changes do you think we should make in order to solve the problem?
We should follow the same pattern as defined here and try to replicate in the MoneyRequestView and MoneyReportView components (this and this) as well.
What alternative solutions did you explore? (Optional)
We can also just remove StyleUtils.getMinimumHeight(CONST.EMPTY_STATE_BACKGROUND.MONEY_REPORT.MIN_HEIGHT) from here as suggested by the first proposal. However, doing that results in the following:
📣 @Arcadekwizera! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
📣 @corpitts! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
N/A
Determine if we should create a regression test for this bug.
I don't think a regression test would be helpful here as it's fairly edge case, hard to test for accurately and doesn't affect the flow in any significant way.
All set to issue payment. @allroundexperts was assigned to the PR on 2023-10-09, and PR was merged on 2023-10-19, so no speed bonus is applicable here. This means we need to pay:
@allroundexperts - $250 for PR (50% regression penalty applies). Paid via NewDot.
@Ollyws - $250 for C+ review (50% regression penalty applies). Paid via Upwork.
Activity
[-] Scroll is not working properly on the distance detail page, it sometimes gets stuck when scrolling up and down[/-][+][$500] Scroll is not working properly on the distance detail page, it sometimes gets stuck when scrolling up and down[/+]melvin-bot commentedon Oct 6, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01348e03e4994bab90
melvin-bot commentedon Oct 6, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (
External)abdel-h66 commentedon Oct 6, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Scroll is briefly blocked when trying to scroll to the distance details page, or IOU page with receipt.
The issue can be better replicated using the trackpad
What is the root cause of that problem?
The problem comes from the container of the
AnimatedEmptyStateBackgroundused in both these pagessrc/components/ReportActionItem/MoneyRequestView.jssrc/components/ReportActionItem/MoneyReportView.jsThe style
StyleUtils.getMinimumHeight(CONST.EMPTY_STATE_BACKGROUND.MONEY_REPORT.MIN_HEIGHT)is setting min height of 250 regardless of the devices causing the container becoming small and assumes there is not room to scroll downWhat changes do you think we should make in order to solve the problem?
I suggest removing the
StyleUtils.getMinimumHeight(CONST.EMPTY_STATE_BACKGROUND.MONEY_REPORT.MIN_HEIGHT)as itoverridesStyleUtils.getReportWelcomeContainerStyle(props.isSmallScreenWidth)that is more device size friendly instead of forcing theminHeightto beCONST.EMPTY_STATE_BACKGROUND.MONEY_REPORT.MIN_HEIGHT.What alternative solutions did you explore? (Optional)
The issue comes partially from the
AnimatedEmptyStateBackgroundcomponent that ignores allpointerEvents. Including the scroll event. Somehow, setting it to auto or at least tobox-nonefixed the issue.N/A
allroundexperts commentedon Oct 6, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Scroll is not working properly on the Money request view page.
What is the root cause of that problem?
The root cause of the issue is that we're defining a min height for the empty state background image container without adding a appropriate margin on the child components in
MoneyRequestViewandMoneyReportViewcomponents.What changes do you think we should make in order to solve the problem?
We should follow the same pattern as defined here and try to replicate in the
MoneyRequestViewandMoneyReportViewcomponents (this and this) as well.This involves replacing this with:
Result
Screen.Recording.2023-10-07.at.4.19.48.AM.mov
Screen.Recording.2023-10-07.at.4.20.44.AM.mov
Screen.Recording.2023-10-07.at.4.21.10.AM.mov
What alternative solutions did you explore? (Optional)
We can also just remove
StyleUtils.getMinimumHeight(CONST.EMPTY_STATE_BACKGROUND.MONEY_REPORT.MIN_HEIGHT)from here as suggested by the first proposal. However, doing that results in the following:melvin-bot commentedon Oct 7, 2023
📣 @Arcadekwizera! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
Arcade-K commentedon Oct 7, 2023
Contributor details
Your Expensify account email: kwizeraarcade5@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01abf672ae2e36f8b1
melvin-bot commentedon Oct 7, 2023
✅ Contributor details stored successfully. Thank you for contributing to Expensify!
corpitts commentedon Oct 7, 2023
Hello, How to join to Expensify group?
melvin-bot commentedon Oct 7, 2023
📣 @corpitts! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
corpitts commentedon Oct 7, 2023
Contributor details
Your Expensify account email: corpitts@outlook.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01598019cf72f02b90
48 remaining items
Ollyws commentedon Oct 31, 2023
BugZero Checklist:
#23737
https://github.com/Expensify/App/pull/23737/files#r1377413396
N/A
I don't think a regression test would be helpful here as it's fairly edge case, hard to test for accurately and doesn't affect the flow in any significant way.
joekaufmanexpensify commentedon Oct 31, 2023
Great, TY! BZ checklist is now complete.
joekaufmanexpensify commentedon Oct 31, 2023
All set to issue payment. @allroundexperts was assigned to the PR on 2023-10-09, and PR was merged on 2023-10-19, so no speed bonus is applicable here. This means we need to pay:
joekaufmanexpensify commentedon Oct 31, 2023
@Ollyws offer sent for $500! (Only $250 will be paid out because of regression).
joekaufmanexpensify commentedon Oct 31, 2023
@ayazhussain79 offer for $50 sent!
joekaufmanexpensify commentedon Oct 31, 2023
@allroundexperts could you please request $250 via NewDot and confirm here once complete?
ayazhussain79 commentedon Oct 31, 2023
@joekaufmanexpensify offer accepted, Thank you
Ollyws commentedon Oct 31, 2023
We did have a regression from this one.
joekaufmanexpensify commentedon Oct 31, 2023
Ah, okay. Thanks for flagging that! In that case, the 50% regression penalty applies here. I've adjusted the payment amounts above to reflect this.
joekaufmanexpensify commentedon Oct 31, 2023
@Ollyws $250 sent and contract ended!
joekaufmanexpensify commentedon Oct 31, 2023
@ayazhussain79 $50 sent and contract ended!
joekaufmanexpensify commentedon Nov 1, 2023
Chatted with @allroundexperts and confirmed they already submitted a request here, so this is all set.
joekaufmanexpensify commentedon Nov 1, 2023
Closing as we're good to go here. Payment summary message is here. Thanks everyone!
JmillsExpensify commentedon Nov 3, 2023
$250 payment approved for @allroundexperts based on this comment.