Skip to content

[HOLD for payment 2023-10-31] [HOLD for payment 2023-10-30] [$500] Scroll is not working properly on the distance detail page, it sometimes gets stuck when scrolling up and down #29038

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Click on the "+" button.
  2. Go to Request money > Distance.
  3. Select Start and Finish points and proceed with the request.
  4. Navigate to the distance detail page.
  5. Attempt to scroll up and down the page

Expected Result:

The page should smoothly scroll up and down without getting stuck

Actual Result:

Scrolling is not properly, and the page sometimes gets stuck when scrolling on the distance detail page

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.79-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-recording-2023-10-04-at-113521-pm_daRS8ow5.mp4
Recording.16.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696444461290349

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01348e03e4994bab90
  • Upwork Job ID: 1710395668949966848
  • Last Price Increase: 2023-10-06

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 6, 2023
  2. changed the title [-] Scroll is not working properly on the distance detail page, it sometimes gets stuck when scrolling up and down[/-] [+][$500] Scroll is not working properly on the distance detail page, it sometimes gets stuck when scrolling up and down[/+] on Oct 6, 2023
  3. melvin-bot commented on Oct 6, 2023

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 6, 2023
  5. melvin-bot commented on Oct 6, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

  6. abdel-h66 commented on Oct 6, 2023

    @abdel-h66
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Scroll is briefly blocked when trying to scroll to the distance details page, or IOU page with receipt.

    The issue can be better replicated using the trackpad

    1. Use the same steps as above
    2. Scroll to the top of the page using the trackpad
    3. try scrolling back down, you will notice that the page is kind of stuck until you scroll down faster

    What is the root cause of that problem?

    The problem comes from the container of the AnimatedEmptyStateBackground used in both these pages

    src/components/ReportActionItem/MoneyRequestView.js
    src/components/ReportActionItem/MoneyReportView.js

    <View style={[StyleUtils.getReportWelcomeContainerStyle(isSmallScreenWidth), StyleUtils.getMinimumHeight(CONST.EMPTY_STATE_BACKGROUND.MONEY_REPORT.MIN_HEIGHT)]}>
       <AnimatedEmptyStateBackground />
    </View>

    The style StyleUtils.getMinimumHeight(CONST.EMPTY_STATE_BACKGROUND.MONEY_REPORT.MIN_HEIGHT) is setting min height of 250 regardless of the devices causing the container becoming small and assumes there is not room to scroll down

    What changes do you think we should make in order to solve the problem?

    I suggest removing the StyleUtils.getMinimumHeight(CONST.EMPTY_STATE_BACKGROUND.MONEY_REPORT.MIN_HEIGHT) as it overridesStyleUtils.getReportWelcomeContainerStyle(props.isSmallScreenWidth) that is more device size friendly instead of forcing the minHeight to be CONST.EMPTY_STATE_BACKGROUND.MONEY_REPORT.MIN_HEIGHT .

    What alternative solutions did you explore? (Optional)

    The issue comes partially from the AnimatedEmptyStateBackground component that ignores all pointerEvents. Including the scroll event. Somehow, setting it to auto or at least to box-none fixed the issue.

            <Animated.Image
                pointerEvents="box-none"
                source={EmptyStateBackgroundImage}
                style={[StyleUtils.getReportWelcomeBackgroundImageStyle(isSmallScreenWidth), animatedStyles]}
            />

    N/A

  7. allroundexperts commented on Oct 6, 2023

    @allroundexperts
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Scroll is not working properly on the Money request view page.

    What is the root cause of that problem?

    The root cause of the issue is that we're defining a min height for the empty state background image container without adding a appropriate margin on the child components in MoneyRequestView and MoneyReportView components.

    What changes do you think we should make in order to solve the problem?

    We should follow the same pattern as defined here and try to replicate in the MoneyRequestView and MoneyReportView components (this and this) as well.

    This involves replacing this with:

    <View style={StyleUtils.getReportWelcomeContainerStyle(isSmallScreenWidth)}>
                <AnimatedEmptyStateBackground />
                <View style={[styles.p5, StyleUtils.getReportWelcomeTopMarginStyle(isSmallScreenWidth)]}>
                    .
                    .
                    .
                    .
                    .
                    .
               </View>
    

    Result

    Screen.Recording.2023-10-07.at.4.19.48.AM.mov
    Screen.Recording.2023-10-07.at.4.20.44.AM.mov
    Screen.Recording.2023-10-07.at.4.21.10.AM.mov

    What alternative solutions did you explore? (Optional)

    We can also just remove StyleUtils.getMinimumHeight(CONST.EMPTY_STATE_BACKGROUND.MONEY_REPORT.MIN_HEIGHT) from here as suggested by the first proposal. However, doing that results in the following:

    Screenshot 2023-10-07 at 4 24 01 AM
  8. melvin-bot commented on Oct 7, 2023

    @melvin-bot

    📣 @Arcadekwizera! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  9. Arcade-K commented on Oct 7, 2023

    @Arcade-K

    Contributor details
    Your Expensify account email: kwizeraarcade5@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~01abf672ae2e36f8b1

  10. melvin-bot commented on Oct 7, 2023

    @melvin-bot

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  11. corpitts commented on Oct 7, 2023

    @corpitts

    Hello, How to join to Expensify group?

  12. melvin-bot commented on Oct 7, 2023

    @melvin-bot

    📣 @corpitts! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  13. corpitts commented on Oct 7, 2023

    @corpitts

    Contributor details
    Your Expensify account email: corpitts@outlook.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~01598019cf72f02b90

  14. 48 remaining items

  15. Ollyws commented on Oct 31, 2023

    @Ollyws
    Contributor

    BugZero Checklist:

    • The PR that introduced the bug has been identified. Link to the PR:

    #23737

    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

    https://github.com/Expensify/App/pull/23737/files#r1377413396

    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    N/A

    • Determine if we should create a regression test for this bug.

    I don't think a regression test would be helpful here as it's fairly edge case, hard to test for accurately and doesn't affect the flow in any significant way.

  16. joekaufmanexpensify commented on Oct 31, 2023

    @joekaufmanexpensify
    Contributor

    Great, TY! BZ checklist is now complete.

  17. joekaufmanexpensify commented on Oct 31, 2023

    @joekaufmanexpensify
    Contributor

    All set to issue payment. @allroundexperts was assigned to the PR on 2023-10-09, and PR was merged on 2023-10-19, so no speed bonus is applicable here. This means we need to pay:

    • @allroundexperts - $250 for PR (50% regression penalty applies). Paid via NewDot.
    • @Ollyws - $250 for C+ review (50% regression penalty applies). Paid via Upwork.
    • @ayazhussain79 - $50 for reporting (Paid via Upwork).
  18. joekaufmanexpensify commented on Oct 31, 2023

    @joekaufmanexpensify
    Contributor

    @Ollyws offer sent for $500! (Only $250 will be paid out because of regression).

  19. joekaufmanexpensify commented on Oct 31, 2023

    @joekaufmanexpensify
    Contributor

    @ayazhussain79 offer for $50 sent!

  20. joekaufmanexpensify commented on Oct 31, 2023

    @joekaufmanexpensify
    Contributor

    @allroundexperts could you please request $250 via NewDot and confirm here once complete?

  21. ayazhussain79 commented on Oct 31, 2023

    @ayazhussain79
    Contributor

    @joekaufmanexpensify offer accepted, Thank you

  22. Ollyws commented on Oct 31, 2023

    @Ollyws
    Contributor

    We did have a regression from this one.

  23. joekaufmanexpensify commented on Oct 31, 2023

    @joekaufmanexpensify
    Contributor

    Ah, okay. Thanks for flagging that! In that case, the 50% regression penalty applies here. I've adjusted the payment amounts above to reflect this.

  24. joekaufmanexpensify commented on Oct 31, 2023

    @joekaufmanexpensify
    Contributor

    @Ollyws $250 sent and contract ended!

  25. joekaufmanexpensify commented on Oct 31, 2023

    @joekaufmanexpensify
    Contributor

    @ayazhussain79 $50 sent and contract ended!

  26. joekaufmanexpensify commented on Nov 1, 2023

    @joekaufmanexpensify
    Contributor

    Chatted with @allroundexperts and confirmed they already submitted a request here, so this is all set.

  27. joekaufmanexpensify commented on Nov 1, 2023

    @joekaufmanexpensify
    Contributor

    Closing as we're good to go here. Payment summary message is here. Thanks everyone!

  28. JmillsExpensify commented on Nov 3, 2023

    @JmillsExpensify
    Contributor

    $250 payment approved for @allroundexperts based on this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions