You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-18] [$500] Web – Chat - Unable to delete message using Context menu #29159
changed the title [-]Web – Chat - Unable to delete message using Context menu[/-][+][$500] Web – Chat - Unable to delete message using Context menu[/+]on Oct 10, 2023
Seems another regression from : #27221
runAndResetOnPopoverHide cleared the value of reportIDRef.current , later when we used Report.deleteReportComment(reportIDRef.current, reportActionRef.current); it will crash because our reportIDRef.current was already reseted to 0.
We should remove the ref cleanup from runAndResetOnPopoverHide or move them to return of an useEffect for safety.
@s-alves10 Fixed the issue by creating a PR which caused a regression. Later the PR was reverted to fix the regression and the root cause was fixed by another PR thus no new PR was created. @alexpensify
Thanks! @parasharrajat! I'm OOO today but going to input the summary here to make sure everyone is on the same page here. I'll complete the process on Monday.
Activity
[-]Web – Chat - Unable to delete message using Context menu[/-][+][$500] Web – Chat - Unable to delete message using Context menu[/+]melvin-bot commentedon Oct 10, 2023
Triggered auto assignment to @alexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Oct 10, 2023
Job added to Upwork: https://www.upwork.com/jobs/~012ea80a76183e99f1
melvin-bot commentedon Oct 10, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Oct 10, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (
External)hungvu193 commentedon Oct 10, 2023
Seems another regression from : #27221
runAndResetOnPopoverHide cleared the value of reportIDRef.current , later when we used Report.deleteReportComment(reportIDRef.current, reportActionRef.current); it will crash because our reportIDRef.current was already reseted to 0.
We should remove the ref cleanup from runAndResetOnPopoverHide or move them to return of an useEffect for safety.
I also reported it here:
https://expensify.slack.com/archives/C049HHMV9SM/p1696914742812669
Can you please update me as the reporter? @izarutskaya
61 remaining items
alexpensify commentedon Oct 23, 2023
@jasperhuangg and @nkuoch - can I get feedback here?
@hungvu193 reported the issue
@s-alves10 fixed the issue. Now, did the PR create a regression or was it caused by another PR unrelated to @s-alves10 work? Thanks for clarifying!
alexpensify commentedon Oct 26, 2023
Bumping - @jasperhuangg and @nkuoch - I need feedback for the payment breakdown here. Thanks!
parasharrajat commentedon Oct 27, 2023
@s-alves10 Fixed the issue by creating a PR which caused a regression. Later the PR was reverted to fix the regression and the root cause was fixed by another PR thus no new PR was created. @alexpensify
alexpensify commentedon Oct 27, 2023
Thanks! @parasharrajat! I'm OOO today but going to input the summary here to make sure everyone is on the same page here. I'll complete the process on Monday.
Here is the payment summary:
Upwork Job: https://www.upwork.com/jobs/~012ea80a76183e99f1
*If applicable, the bonuses will be applied on the final payment
Extra Notes regarding payment: There is a regression, so there is a 50% reduction to the base rate.
@parasharrajat - I think are are paid in the other GH, but let me know if that's not the case.
alexpensify commentedon Oct 30, 2023
All requests have been sent via Upwork. Once accepted, I can complete the payment process.
hungvu193 commentedon Oct 31, 2023
Can you send it again please?
alexpensify commentedon Nov 1, 2023
@hungvu193 - I sent a new request in Upwork for you to review. Thanks!
hungvu193 commentedon Nov 1, 2023
Accepted. Thank you.
alexpensify commentedon Nov 1, 2023
Perfect, everyone has been paid here via Upwork!