Skip to content

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-18] [$500] Web – Chat - Unable to delete message using Context menu #29159

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.80-0

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: @hungvu193/Applause-Internal Team

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696914742812669

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Log in with any Gmail account.
  3. Navigate to any chat conversation.
  4. Send a message.
  5. Delete the message using Context menu.

Expected Result:

The message has been deleted

Actual Result:

Nothing happenes. The Delete button does not work.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Bug6231518_1696922057008.Thread.mp4
Bug6231518_1696922056951.Impossible_to_delete_comment_from_the_Thread.mp4

utest-dl.s3.amazonaws.com_12102_26469_432782_6231518_bugAttachment_Bug6231518_1696922056983%21log.txt_X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Date=20231010T075332Z&X-Amz-SignedHeaders=host&X-Amz-Expires=86400&X-Amz-Credential=AKIAJ2U.txt

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012ea80a76183e99f1
  • Upwork Job ID: 1711652016993763328
  • Last Price Increase: 2023-10-10

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 10, 2023
  2. changed the title [-]Web – Chat - Unable to delete message using Context menu[/-] [+][$500] Web – Chat - Unable to delete message using Context menu[/+] on Oct 10, 2023
  3. melvin-bot commented on Oct 10, 2023

    @melvin-bot

    Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. melvin-bot commented on Oct 10, 2023

    @melvin-bot
  5. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 10, 2023
  6. melvin-bot commented on Oct 10, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  7. melvin-bot commented on Oct 10, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

  8. hungvu193 commented on Oct 10, 2023

    @hungvu193
    Contributor

    Seems another regression from : #27221
    runAndResetOnPopoverHide cleared the value of reportIDRef.current , later when we used Report.deleteReportComment(reportIDRef.current, reportActionRef.current); it will crash because our reportIDRef.current was already reseted to 0.
    We should remove the ref cleanup from runAndResetOnPopoverHide or move them to return of an useEffect for safety.

    I also reported it here:
    https://expensify.slack.com/archives/C049HHMV9SM/p1696914742812669

    Can you please update me as the reporter? @izarutskaya

  9. 61 remaining items

  10. alexpensify commented on Oct 23, 2023

    @alexpensify
    Contributor

    @jasperhuangg and @nkuoch - can I get feedback here?

    @hungvu193 reported the issue

    @s-alves10 fixed the issue. Now, did the PR create a regression or was it caused by another PR unrelated to @s-alves10 work? Thanks for clarifying!

  11. alexpensify commented on Oct 26, 2023

    @alexpensify
    Contributor

    Bumping - @jasperhuangg and @nkuoch - I need feedback for the payment breakdown here. Thanks!

  12. parasharrajat commented on Oct 27, 2023

    @parasharrajat
    Member

    @s-alves10 Fixed the issue by creating a PR which caused a regression. Later the PR was reverted to fix the regression and the root cause was fixed by another PR thus no new PR was created. @alexpensify

  13. alexpensify commented on Oct 27, 2023

    @alexpensify
    Contributor

    Thanks! @parasharrajat! I'm OOO today but going to input the summary here to make sure everyone is on the same page here. I'll complete the process on Monday.

    Here is the payment summary:

    • External issue reporter - @hungvu193 $50
    • Contributor that fixed the issue - @s-alves10 $250
    • Contributor+ that helped on the issue and/or PR - N/A

    Upwork Job: https://www.upwork.com/jobs/~012ea80a76183e99f1

    *If applicable, the bonuses will be applied on the final payment

    Extra Notes regarding payment: There is a regression, so there is a 50% reduction to the base rate.


    @parasharrajat - I think are are paid in the other GH, but let me know if that's not the case.

  14. alexpensify commented on Oct 30, 2023

    @alexpensify
    Contributor

    All requests have been sent via Upwork. Once accepted, I can complete the payment process.

  15. hungvu193 commented on Oct 31, 2023

    @hungvu193
    Contributor

    All requests have been sent via Upwork. Once accepted, I can complete the payment process.

    Can you send it again please?

  16. alexpensify commented on Nov 1, 2023

    @alexpensify
    Contributor

    @hungvu193 - I sent a new request in Upwork for you to review. Thanks!

  17. hungvu193 commented on Nov 1, 2023

    @hungvu193
    Contributor

    @hungvu193 - I sent a new request in Upwork for you to review. Thanks!

    Accepted. Thank you.

  18. alexpensify commented on Nov 1, 2023

    @alexpensify
    Contributor

    Perfect, everyone has been paid here via Upwork!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions