Skip to content

[HOLD for payment 2023-10-18] [$500] Chat - Green line only appears on the first message marked as unread until the chat is reloaded #29160

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.80-0

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

Action Performed:

  1. Go to staging.new.expensify.com or open iOS/Android/Desktop App
  2. Login with any account
  3. Open a chat with many messages
  4. Mark any message as unread
  5. Check that a green line "New" appears above the message
  6. Mark another message as unread

Expected Result:

Green line "New" appears above the another message

Actual Result:

Green line still marks the previous message

Green line appears above another message only after the chat is reloaded

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
Bug6231446_1696914315542.iOS-Greenline-appear-1st-message-only-until-chat-reload.mp4
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
Bug6231446_1696914315537.Desktop-Greenline-appear-1st-message-only-until-chat-reload.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 10, 2023
  2. changed the title [-]Chat - Green line only appears on the first message marked as unread until the chat is reloaded[/-] [+][$500] Chat - Green line only appears on the first message marked as unread until the chat is reloaded[/+] on Oct 10, 2023
  3. melvin-bot commented on Oct 10, 2023

    @melvin-bot
  4. melvin-bot commented on Oct 10, 2023

    @melvin-bot

    Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  5. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 10, 2023
  6. melvin-bot commented on Oct 10, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  7. melvin-bot commented on Oct 10, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

  8. 40 remaining items

  9. changed the title [-][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-18] [$500] Chat - Green line only appears on the first message marked as unread until the chat is reloaded[/-] [+][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-18] [$500] Chat - Green line only appears on the first message marked as unread until the chat is reloaded[/+] on Oct 16, 2023
  10. melvin-bot commented on Oct 16, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-10-23. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  11. melvin-bot commented on Oct 16, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
    • [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@aimane-chnaif] Determine if we should create a regression test for this bug.
    • [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@NicMendonca] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  12. changed the title [-][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-18] [$500] Chat - Green line only appears on the first message marked as unread until the chat is reloaded[/-] [+][HOLD for payment 2023-10-18] [$500] Chat - Green line only appears on the first message marked as unread until the chat is reloaded[/+] on Oct 18, 2023
  13. NicMendonca commented on Oct 18, 2023

    @NicMendonca
    Contributor
  14. aimane-chnaif commented on Oct 18, 2023

    @aimane-chnaif
    Contributor

    @NicMendonca please unassign and assign me back. Melvin will send offer automatically.

  15. NicMendonca commented on Oct 18, 2023

    @NicMendonca
    Contributor

    Are you sure? Melv couldn't get payment date right 😂

    image
  16. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 18, 2023
  17. NicMendonca commented on Oct 19, 2023

    @NicMendonca
    Contributor

    @aimane-chnaif offer sent

  18. NicMendonca commented on Oct 20, 2023

    @NicMendonca
    Contributor

    @aimane-chnaif you've been paid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions