Skip to content

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] Chat - App crash when open edit date request money by deep link #29183

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.80.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696863974272199

Action Performed:

  1. Create a request money
  2. Click request preview
  3. Click request item
  4. Click date and copy url
  5. Create a public room and send URL
  6. Logout and open the publish room
  7. Click open url

Expected Result:

App does not crash

Actual Result:

App crash when open edit date request money by deep link

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android: mWeb Chrome
Screen.Recording.2023-10-09.at.22.36.55.1.mov
iOS: Native
iOS: mWeb Safari
Screen.Recording.2023-10-09.at.22.49.25.mov
MacOS: Chrome / Safari
Screen.Recording.2023-10-09.at.22.06.44.mov
MacOS: Desktop
Screen.Recording.2023-10-09.at.22.26.22.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c4f5d983bc3511a7
  • Upwork Job ID: 1711819993131061248
  • Last Price Increase: 2023-10-10

Activity

  1. OSBotify commented on Oct 10, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Oct 10, 2023

    @melvin-bot

    Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. namhihi237 commented on Oct 10, 2023

    @namhihi237
    Contributor

    This issue come from #28645

  4. puneetlath commented on Oct 10, 2023

    @puneetlath
    Contributor

    @tgolen mind taking a look? Seems to be coming from your PR.

  5. saranshbalyan-1234 commented on Oct 10, 2023

    @saranshbalyan-1234
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    App crash when open edit date request money by deep link

    What is the root cause of that problem?

    While page is being accessed via deep link, initially report object is null which gives this error as we cannot access properties of null or undefined here

    key: ({report, parentReportActions}) => {
    const parentReportAction = lodashGet(parentReportActions, [report.parentReportActionID]);
    return `${ONYXKEYS.COLLECTION.TRANSACTION}${lodashGet(parentReportAction, 'originalMessage.IOUTransactionID', 0)}`;
    },

    What changes do you think we should make in order to solve the problem?

    use report object like we use in other places of same component like this

    key: ({report}) => `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report ? report.parentReportID : '0'}`,

    thus the solution would look something like this

     const parentReportAction = lodashGet(parentReportActions, [report ? report.parentReportActionID : '0']);

    What alternative solutions did you explore? (Optional)

    N/A

  6. tgolen commented on Oct 10, 2023

    @tgolen
    Contributor

    @saranshbalyan-1234 Has the correct solution 👍

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 10, 2023
  8. changed the title [-]Chat - App crash when open edit date request money by deep link[/-] [+][$500] Chat - App crash when open edit date request money by deep link[/+] on Oct 10, 2023
  9. melvin-bot commented on Oct 10, 2023

    @melvin-bot
  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 10, 2023
  11. 34 remaining items

  12. melvin-bot commented on Oct 16, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-10-23. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  13. melvin-bot commented on Oct 23, 2023

    @melvin-bot

    @puneetlath, @s77rt, @saranshbalyan-1234 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  14. melvin-bot commented on Oct 25, 2023

    @melvin-bot

    @puneetlath, @s77rt, @saranshbalyan-1234 Eep! 4 days overdue now. Issues have feelings too...

  15. puneetlath commented on Oct 25, 2023

    @puneetlath
    Contributor

    Not sure why offers weren't auto-sent.

    @saranshbalyan-1234 @namhihi237 can you please apply to the job? https://www.upwork.com/jobs/~01c4f5d983bc3511a7

  16. namhihi237 commented on Oct 25, 2023

    @namhihi237
    Contributor

    @puneetlath I submitted.

  17. saranshbalyan-1234 commented on Oct 25, 2023

    @saranshbalyan-1234
    Contributor

    unable to apply, can you please send an offer

  18. puneetlath commented on Oct 26, 2023

    @puneetlath
    Contributor

    ok @saranshbalyan-1234 @namhihi237 you both have been sent offers. Please let me know when you've accepted.

  19. namhihi237 commented on Oct 26, 2023

    @namhihi237
    Contributor

    I accepted @puneetlath

  20. saranshbalyan-1234 commented on Oct 26, 2023

    @saranshbalyan-1234
    Contributor

    Thank you @puneetlath accepted

  21. puneetlath commented on Oct 26, 2023

    @puneetlath
    Contributor

    Great, all paid. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions