You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] Chat - App crash when open edit date request money by deep link #29183
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
App crash when open edit date request money by deep link
What is the root cause of that problem?
While page is being accessed via deep link, initially report object is null which gives this error as we cannot access properties of null or undefined here
changed the title [-]Chat - App crash when open edit date request money by deep link[/-][+][$500] Chat - App crash when open edit date request money by deep link[/+]on Oct 10, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-23. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
Activity
OSBotify commentedon Oct 10, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Oct 10, 2023
Triggered auto assignment to @puneetlath (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.namhihi237 commentedon Oct 10, 2023
This issue come from #28645
puneetlath commentedon Oct 10, 2023
@tgolen mind taking a look? Seems to be coming from your PR.
saranshbalyan-1234 commentedon Oct 10, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
App crash when open edit date request money by deep link
What is the root cause of that problem?
While page is being accessed via deep link, initially report object is null which gives this error as we cannot access properties of null or undefined here
App/src/pages/EditRequestPage.js
Lines 323 to 326 in b2cbd26
What changes do you think we should make in order to solve the problem?
use report object like we use in other places of same component like this
App/src/pages/EditRequestPage.js
Line 316 in b2cbd26
thus the solution would look something like this
What alternative solutions did you explore? (Optional)
N/A
tgolen commentedon Oct 10, 2023
@saranshbalyan-1234 Has the correct solution 👍
[-]Chat - App crash when open edit date request money by deep link[/-][+][$500] Chat - App crash when open edit date request money by deep link[/+]melvin-bot commentedon Oct 10, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01c4f5d983bc3511a7
34 remaining items
melvin-bot commentedon Oct 16, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-23. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Oct 23, 2023
@puneetlath, @s77rt, @saranshbalyan-1234 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Oct 25, 2023
@puneetlath, @s77rt, @saranshbalyan-1234 Eep! 4 days overdue now. Issues have feelings too...
puneetlath commentedon Oct 25, 2023
Not sure why offers weren't auto-sent.
@saranshbalyan-1234 @namhihi237 can you please apply to the job? https://www.upwork.com/jobs/~01c4f5d983bc3511a7
namhihi237 commentedon Oct 25, 2023
@puneetlath I submitted.
saranshbalyan-1234 commentedon Oct 25, 2023
unable to apply, can you please send an offer
puneetlath commentedon Oct 26, 2023
ok @saranshbalyan-1234 @namhihi237 you both have been sent offers. Please let me know when you've accepted.
namhihi237 commentedon Oct 26, 2023
I accepted @puneetlath
saranshbalyan-1234 commentedon Oct 26, 2023
Thank you @puneetlath accepted
puneetlath commentedon Oct 26, 2023
Great, all paid. Thanks everyone!