Skip to content

LHN - 'Chats' in the LHN is not translated to Spanish #29186

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.80-0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Settings > Preferences > Language
  3. Change the language to Spanish

Expected Result:

'Chats' in the LHN is translated to Spanish

Actual Result:

'Chats' in the LHN is not translated to Spanish

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
0-02-01-ffab619b0fc4ef8dcf9197560bd41c05f8f1ec748f6ef2e79546eb2e28d6c55b_501ee0b7d66c913c.mp4
Android: mWeb Chrome
iOS: Native
0-02-01-a5100aaf4dab0cb87da5ab7af19bd01c926e179e87972cbe0d791631508e0973_3246e079ab150794.mp4
iOS: mWeb Safari
0-02-01-a5100aaf4dab0cb87da5ab7af19bd01c926e179e87972cbe0d791631508e0973_3246e079ab150794.mp4
MacOS: Chrome / Safari
Bug6231770_1696937138832.20231010_174848.mp4
MacOS: Desktop
2023-10-10.9.30.00.AM.mov

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 10, 2023
  2. melvin-bot commented on Oct 10, 2023

    @melvin-bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Oct 10, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. OSBotify commented on Oct 10, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Oct 10, 2023

    @melvin-bot

    Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  6. Nodebrute commented on Oct 10, 2023

    @Nodebrute
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The word chats is not translated into Spanish.

    What is the root cause of that problem?

    In es.ts we are not using the Spanish translation for the word chats

    App/src/languages/es.ts

    Lines 2311 to 2313 in 477c630

    globalNavigationOptions: {
    chats: 'Chats',
    },

    What changes do you think we should make in order to solve the problem?

    We should use the Spanish translation of the word "Chats", probably "Charlas" or any other word that translates 'chats' in Spanish.

    What alternative solutions did you explore? (Optional)

  7. jasperhuangg commented on Oct 10, 2023

    @jasperhuangg
    Contributor

    According to this, "Chats" is accepted colloquially in Spanish, so no need to fix this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions