You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-11-07] [$500] Request Money - Amount input getting displaced if there is an error #29204
changed the title [-]Request Money - Amount input getting displaced if there is an error[/-][+][$500] Request Money - Amount input getting displaced if there is an error[/+]on Oct 10, 2023
Please re-state the problem that we are trying to solve in this issue.
Amount input getting displaced if there is an error
What is the root cause of that problem?
When the error message appears, it takes up additional vertical space within its container, causing the layout to shift.
What changes do you think we should make in order to solve the problem?
We can use a parent View for the FormHelpMessage and assign it a fixed height here, ensuring its presence at all times.
And when the conditions are met, the error message will occupy this space.
We might need to made some adjustments for BigNumberPad as it will also have an effect when BigNumberPad is visible for smaller screens (mWeb)
What alternative solutions did you explore? (Optional)
We can implement relative positioning by placing both the Amount Input's container and the FormHelpMessage within a parent View and then aligning the FormHelpMessage at the bottom.
📣 @jenyaftw! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.93-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-11-07. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@situchan] The PR that introduced the bug has been identified. Link to the PR:
[@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@situchan] Determine if we should create a regression test for this bug.
[@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
This is minor style issue and doesn't affect money request flow so I propose no regression test
Activity
[-]Request Money - Amount input getting displaced if there is an error[/-][+][$500] Request Money - Amount input getting displaced if there is an error[/+]melvin-bot commentedon Oct 10, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0189b47702ed5e01e9
melvin-bot commentedon Oct 10, 2023
Triggered auto assignment to @muttmuure (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Oct 10, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Oct 10, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (
External)kbecciv commentedon Oct 10, 2023
Proposal by: @aman-atg
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696005319999269
Proposal
Please re-state the problem that we are trying to solve in this issue.
Amount input getting displaced if there is an error
What is the root cause of that problem?
When the error message appears, it takes up additional vertical space within its container, causing the layout to shift.
What changes do you think we should make in order to solve the problem?
We can use a parent View for the
FormHelpMessageand assign it a fixed height here, ensuring its presence at all times.And when the conditions are met, the error message will occupy this space.
We might need to made some adjustments for
BigNumberPadas it will also have an effect when BigNumberPad is visible for smaller screens (mWeb)What alternative solutions did you explore? (Optional)
We can implement relative positioning by placing both the Amount Input's container and the FormHelpMessage within a parent View and then aligning the FormHelpMessage at the bottom.
jenyaftw commentedon Oct 10, 2023
Trying to recreate this, can't seem to figure it out. Do I select manual? And what should the input be to cause an error?
melvin-bot commentedon Oct 10, 2023
📣 @jenyaftw! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
melvin-bot commentedon Oct 10, 2023
✅ Contributor details stored successfully. Thank you for contributing to Expensify!
32 remaining items
melvin-bot commentedon Oct 31, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.93-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-11-07. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Oct 31, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
muttmuure commentedon Nov 9, 2023
Everyone is paid
situchan commentedon Nov 9, 2023
This is eligible for bonus
situchan commentedon Nov 9, 2023
This is minor style issue and doesn't affect money request flow so I propose no regression test
amyevans commentedon Nov 9, 2023
Looks like the PR was created before the announcement so just confirming the urgency bonus request @muttmuure.
Agreed no regression test necessary.
muttmuure commentedon Nov 13, 2023
Urgency bonuses given