Skip to content

[HOLD for payment 2023-11-07] [$500] Request Money - Amount input getting displaced if there is an error #29204

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.74.3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @aman-atg
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696005319999269

Action Performed:

  1. Login to new.expensify.com
  2. Click on FAB > Request Money > Request

Expected Result:

An error message is shown and input doesn't move

Actual Result:

Amount input is getting displaced and error message is shown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
android.mp4
Android: mWeb Chrome
Screen_Recording_20231010_113155_Chrome.mp4
iOS: Native
Screen.Recording.2023-10-09.at.6.09.28.PM.mov
iOS: mWeb Safari
Screen.Recording.2023-09-29.at.10.38.12.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2023-09-29.at.9.31.36.PM.mov
MacOS: Desktop
Screen.Recording.2023-09-29.at.9.33.09.PM.1.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0189b47702ed5e01e9
  • Upwork Job ID: 1711768995907104768
  • Last Price Increase: 2023-10-17
  • Automatic offers:
    • situchan | Reviewer | 27350803
    • aman-atg | Contributor | 27350805
    • aman-atg | Reporter | 27350806

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 10, 2023
  2. changed the title [-]Request Money - Amount input getting displaced if there is an error[/-] [+][$500] Request Money - Amount input getting displaced if there is an error[/+] on Oct 10, 2023
  3. melvin-bot commented on Oct 10, 2023

    @melvin-bot
  4. melvin-bot commented on Oct 10, 2023

    @melvin-bot

    Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  5. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 10, 2023
  6. melvin-bot commented on Oct 10, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  7. melvin-bot commented on Oct 10, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

  8. kbecciv commented on Oct 10, 2023

    @kbecciv
    Author

    Proposal by: @aman-atg
    Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696005319999269

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Amount input getting displaced if there is an error

    What is the root cause of that problem?

    When the error message appears, it takes up additional vertical space within its container, causing the layout to shift.

    What changes do you think we should make in order to solve the problem?

    We can use a parent View for the FormHelpMessage and assign it a fixed height here, ensuring its presence at all times.
    And when the conditions are met, the error message will occupy this space.

    We might need to made some adjustments for BigNumberPad as it will also have an effect when BigNumberPad is visible for smaller screens (mWeb)

    What alternative solutions did you explore? (Optional)

    We can implement relative positioning by placing both the Amount Input's container and the FormHelpMessage within a parent View and then aligning the FormHelpMessage at the bottom.

  9. jenyaftw commented on Oct 10, 2023

    @jenyaftw

    Trying to recreate this, can't seem to figure it out. Do I select manual? And what should the input be to cause an error?

  10. melvin-bot commented on Oct 10, 2023

    @melvin-bot

    📣 @jenyaftw! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  11. melvin-bot commented on Oct 10, 2023

    @melvin-bot

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  12. 32 remaining items

  13. melvin-bot commented on Oct 31, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.93-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-11-07. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Oct 31, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@situchan] The PR that introduced the bug has been identified. Link to the PR:
    • [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@situchan] Determine if we should create a regression test for this bug.
    • [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  15. muttmuure commented on Nov 9, 2023

    @muttmuure
    Contributor

    Everyone is paid

  16. situchan commented on Nov 9, 2023

    @situchan
    Contributor

    This is eligible for bonus

  17. situchan commented on Nov 9, 2023

    @situchan
    Contributor
    • The PR that introduced the bug has been identified. Link to the PR: Fix Inconsistency in the security page and Request money page #23712
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/23712/files#r1388117046
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • Determine if we should create a regression test for this bug.
    • If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    This is minor style issue and doesn't affect money request flow so I propose no regression test

  18. amyevans commented on Nov 9, 2023

    @amyevans
    Contributor

    Looks like the PR was created before the announcement so just confirming the urgency bonus request @muttmuure.

    Agreed no regression test necessary.

  19. muttmuure commented on Nov 13, 2023

    @muttmuure
    Contributor

    Urgency bonuses given

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions