Skip to content

[HOLD awaiting refund from overpayment] [$500] Details - Workspace split bill displays user name instead of workspace name to admin #29219

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.80.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696924602489199

Action Performed:

  1. Open the app and login with user A
  2. Open the app using any other device and login with user B
  3. From user A, add user B as member in any of user A workspaces
  4. From user A, open workspace chat created newly after step 3
  5. From user B, click on green plus button situated in LHN of app
  6. From user B, click on request money->manual
  7. Type in any amount and click Next
  8. In the user list, click on split besides workspace report name used in step 3 and finish the request money process
  9. From user A, click on split bill message and observe that in details, instead of workspace name it displays username

Expected Result:

App should display workspace name besides workspace avatar in split bill details page

Actual Result:

App displays username name besides workspace avatar to admin user in split bill details page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
android.native.wrong.workspace.name.split.details.mp4
Android: mWeb Chrome
android.chrome.wrong.split.bill.workspace.name.mp4
iOS: Native
ios.native.split.bill.wrong.workspace.name.1.mov
iOS: mWeb Safari
ios.safari.wrong.split.bill.workspace.name.mov
MacOS: Chrome / Safari
mac.chrome.wrong.split.bill.workspace.name.mov
windows.chrome.wrong.workspace.name.split.bill.mp4
Recording.4932.mp4
MacOS: Desktop
mac.desktop.wrong.split.bill.workspace.name.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015f60ccd423ab1d2e
  • Upwork Job ID: 1711802547356061696
  • Last Price Increase: 2023-10-10
  • Automatic offers:
    • s77rt | Reviewer | 27154595
    • akamefi202 | Contributor | 27154596
    • dhanashree-sawant | Reporter | 27154598

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 10, 2023
  2. changed the title [-]Details - Workspace split bill displays user name instead of workspace name to admin[/-] [+][$500] Details - Workspace split bill displays user name instead of workspace name to admin[/+] on Oct 10, 2023
  3. melvin-bot commented on Oct 10, 2023

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. melvin-bot commented on Oct 10, 2023

    @melvin-bot
  5. melvin-bot commented on Oct 10, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 10, 2023
  7. melvin-bot commented on Oct 10, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

  8. akamefi202 commented on Oct 10, 2023

    @akamefi202
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Workspace split bill displays user name instead of workspace name in split details.

    What is the root cause of that problem?

    function getPolicyExpenseReportOption(report) {
    const expenseReport = policyExpenseReports[`${ONYXKEYS.COLLECTION.REPORT}${report.reportID}`];
    const policyExpenseChatAvatarSource = ReportUtils.getWorkspaceAvatar(expenseReport);
    const reportName = ReportUtils.getReportName(expenseReport);

    The app gets the information to display inside getPolicyExpenseReportOption function.
    And inside it, the app calls getReportName function to get name.

    App/src/libs/ReportUtils.js

    Lines 1798 to 1800 in b5445bd

    if (isPolicyExpenseChat(report)) {
    formattedName = getPolicyExpenseChatName(report, policy);
    }

    Inside getReportName function, it calls getPolicyExpenseChatName function to get the name of workspace.

    App/src/libs/ReportUtils.js

    Lines 1308 to 1310 in b5445bd

    if (report.isOwnPolicyExpenseChat) {
    return getPolicyName(report, false, policy);
    }

    But the getPolicyExpenseChatName function returns workspace name only if policy is owned by the user.
    If not, it returns the name of owner.

    As a result, we see the name of user B instead of the workspace name if we check split details as user A.
    Because the policy is owned by user B.

    What changes do you think we should make in order to solve the problem?

    We should call getPolicyName function directly inside getPolicyExpenseReportOption function.
    Because we're always meant to get workspace name here.

    const workspaceName = ReportUtils.getPolicyName(expenseReport);
    

    What alternative solutions did you explore? (Optional)

    N/A

  9. mallenexpensify commented on Oct 11, 2023

    @mallenexpensify
    Contributor

    @s77rt can you please review @akamefi202 's proposal? Thx

  10. s77rt commented on Oct 11, 2023

    @s77rt
    Member

    @akamefi202 Thanks for the proposal. Your RCA is correct and the solution looks good to me 👍

    🎀 👀 🎀 C+ reviewed
    Link to proposal

  11. 35 remaining items

  12. akamefi202 commented on Oct 23, 2023

    @akamefi202
    Contributor

    @mallenexpensify @s77rt Could you please finish this issue if you have any time?

  13. Christinadobrzyn commented on Oct 23, 2023

    @Christinadobrzyn
    Contributor

    Ah okay, thanks @mallenexpensify I do see the option to request a refund on this job so I did that. Just a heads up @akamefi202 I requested a partial refund for this job through Upwork.

  14. akamefi202 commented on Oct 23, 2023

    @akamefi202
    Contributor

    @mallenexpensify Could you please pay here first? That $1000 payment was more than 3 weeks ago so that I don't have enough money for refund in Upwork now. I promise that I will do refund.

  15. changed the title [-][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [$500] Details - Workspace split bill displays user name instead of workspace name to admin[/-] [+][HOLD for payment 2023-10-23] [$500] Details - Workspace split bill displays user name instead of workspace name to admin[/+] on Oct 24, 2023
  16. mallenexpensify commented on Oct 24, 2023

    @mallenexpensify
    Contributor

    Oooof, that is a tricky situation @akamefi202. I just paid this

    Issue reporter: @@dhanashree-sawant paid $50 via Upwork
    Contributor: @akamefi202 paid $750 via Upwork. Please accept/pay the refund for the other job
    Contributor+: @s77rt paid $750 via Upwork.

    @s77rt I wasn't sure about the regression test so I created on, Applause/QA will do something with it if they think it'd be helpful
    https://github.com/Expensify/Expensify/issues/329593

    Gonna leave this open and a weekly til I'm able to confirm @akamefi202 's refund for the other issue.

  17. changed the title [-][HOLD for payment 2023-10-23] [$500] Details - Workspace split bill displays user name instead of workspace name to admin[/-] [+][HOLD awaiting refund from overpayment] [$500] Details - Workspace split bill displays user name instead of workspace name to admin[/+] on Oct 26, 2023
  18. mallenexpensify commented on Nov 3, 2023

    @mallenexpensify
    Contributor

    Awaiting refund on other issue
    #26214 (comment)

  19. akamefi202 commented on Nov 6, 2023

    @akamefi202
    Contributor

    @mallenexpensify Sorry for late reply. I was OOO last week. I made the refund and I think we might close this issue now.

  20. mallenexpensify commented on Nov 6, 2023

    @mallenexpensify
    Contributor

    Thanks @akamefi202 , confirming refund was issued for #26214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions