You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD awaiting refund from overpayment] [$500] Details - Workspace split bill displays user name instead of workspace name to admin #29219
changed the title [-]Details - Workspace split bill displays user name instead of workspace name to admin[/-][+][$500] Details - Workspace split bill displays user name instead of workspace name to admin[/+]on Oct 10, 2023
Ah okay, thanks @mallenexpensify I do see the option to request a refund on this job so I did that. Just a heads up @akamefi202 I requested a partial refund for this job through Upwork.
@mallenexpensify Could you please pay here first? That $1000 payment was more than 3 weeks ago so that I don't have enough money for refund in Upwork now. I promise that I will do refund.
changed the title [-][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [$500] Details - Workspace split bill displays user name instead of workspace name to admin[/-][+][HOLD for payment 2023-10-23] [$500] Details - Workspace split bill displays user name instead of workspace name to admin[/+]on Oct 24, 2023
changed the title [-][HOLD for payment 2023-10-23] [$500] Details - Workspace split bill displays user name instead of workspace name to admin[/-][+][HOLD awaiting refund from overpayment] [$500] Details - Workspace split bill displays user name instead of workspace name to admin[/+]on Oct 26, 2023
Activity
[-]Details - Workspace split bill displays user name instead of workspace name to admin[/-][+][$500] Details - Workspace split bill displays user name instead of workspace name to admin[/+]melvin-bot commentedon Oct 10, 2023
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Oct 10, 2023
Job added to Upwork: https://www.upwork.com/jobs/~015f60ccd423ab1d2e
melvin-bot commentedon Oct 10, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Oct 10, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (
External)akamefi202 commentedon Oct 10, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Workspace split bill displays user name instead of workspace name in split details.
What is the root cause of that problem?
App/src/libs/OptionsListUtils.js
Lines 99 to 102 in b5445bd
The app gets the information to display inside
getPolicyExpenseReportOptionfunction.And inside it, the app calls
getReportNamefunction to get name.App/src/libs/ReportUtils.js
Lines 1798 to 1800 in b5445bd
Inside
getReportNamefunction, it callsgetPolicyExpenseChatNamefunction to get the name of workspace.App/src/libs/ReportUtils.js
Lines 1308 to 1310 in b5445bd
But the
getPolicyExpenseChatNamefunction returns workspace name only if policy is owned by the user.If not, it returns the name of owner.
As a result, we see the name of user B instead of the workspace name if we check split details as user A.
Because the policy is owned by user B.
What changes do you think we should make in order to solve the problem?
We should call
getPolicyNamefunction directly insidegetPolicyExpenseReportOptionfunction.Because we're always meant to get workspace name here.
What alternative solutions did you explore? (Optional)
N/A
mallenexpensify commentedon Oct 11, 2023
@s77rt can you please review @akamefi202 's proposal? Thx
s77rt commentedon Oct 11, 2023
@akamefi202 Thanks for the proposal. Your RCA is correct and the solution looks good to me 👍
🎀 👀 🎀 C+ reviewed
Link to proposal
35 remaining items
akamefi202 commentedon Oct 23, 2023
@mallenexpensify @s77rt Could you please finish this issue if you have any time?
Christinadobrzyn commentedon Oct 23, 2023
Ah okay, thanks @mallenexpensify I do see the option to request a refund on this job so I did that. Just a heads up @akamefi202 I requested a partial refund for this job through Upwork.
akamefi202 commentedon Oct 23, 2023
@mallenexpensify Could you please pay here first? That $1000 payment was more than 3 weeks ago so that I don't have enough money for refund in Upwork now. I promise that I will do refund.
[-][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [$500] Details - Workspace split bill displays user name instead of workspace name to admin[/-][+][HOLD for payment 2023-10-23] [$500] Details - Workspace split bill displays user name instead of workspace name to admin[/+]mallenexpensify commentedon Oct 24, 2023
Oooof, that is a tricky situation @akamefi202. I just paid this
Issue reporter: @@dhanashree-sawant paid $50 via Upwork
Contributor: @akamefi202 paid $750 via Upwork. Please accept/pay the refund for the other job
Contributor+: @s77rt paid $750 via Upwork.
@s77rt I wasn't sure about the regression test so I created on, Applause/QA will do something with it if they think it'd be helpful
https://github.com/Expensify/Expensify/issues/329593
Gonna leave this open and a weekly til I'm able to confirm @akamefi202 's refund for the other issue.
[-][HOLD for payment 2023-10-23] [$500] Details - Workspace split bill displays user name instead of workspace name to admin[/-][+][HOLD awaiting refund from overpayment] [$500] Details - Workspace split bill displays user name instead of workspace name to admin[/+]mallenexpensify commentedon Nov 3, 2023
Awaiting refund on other issue
#26214 (comment)
akamefi202 commentedon Nov 6, 2023
@mallenexpensify Sorry for late reply. I was OOO last week. I made the refund and I think we might close this issue now.
mallenexpensify commentedon Nov 6, 2023
Thanks @akamefi202 , confirming refund was issued for #26214