Skip to content

[HOLD for payment 2023-12-28] [HOLD for payment regression] [$500] Conversation - In group details page, plus options are shown #29379

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.81-4

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Tap on a group chat report
  3. Tap plus icon and quickly tap the header

Expected Result:

In group details page, plus options like split bill, assign task and add attachment must not be shown

Actual Result:

In group details page, plus options like split bill, assign task and add attachment are shown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android: mWeb Chrome
Bug6233473_1697051252956.double.mp4
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016354d05fb227f48d
  • Upwork Job ID: 1714386765019463680
  • Last Price Increase: 2023-10-24
  • Automatic offers:
    • ishpaul777 | Contributor | 27498473

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 11, 2023
  2. melvin-bot commented on Oct 11, 2023

    @melvin-bot

    Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Oct 11, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. ishpaul777 commented on Oct 16, 2023

    @ishpaul777
    Contributor

    Proposal

    Problem

    When Header is clicked and quickly the plus is clicked the plus option open in report details page

    Root Cause

    When we click the header there is a naviagtion delay in that moment if user clicks the plus button the popover will open and then navigation happens, there is no code specific root cause just a case not handled.

    Changes

    We can avoid opening of Plus button options when navigation is in progress. We can use withNavigationFocus HOC to get isFocused prop which tells if screen is not focused(navigating in progress)

    https://github.com/Expensify/App/blob/5d9ac2ceda20f487c5b0772d976217525a95d547/src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.js

    ans onPress of plus button we can early return if isFoucused is false, the same ^ needs to be implemented for Emojipicker Popover.

  5. melvin-bot commented on Oct 17, 2023

    @melvin-bot

    @JmillsExpensify Eep! 4 days overdue now. Issues have feelings too...

  6. JmillsExpensify commented on Oct 17, 2023

    @JmillsExpensify
    Contributor

    Can we get a video for this one?

  7. JmillsExpensify commented on Oct 17, 2023

    @JmillsExpensify
    Contributor

    Regardless, triaging for review and more proposals.

  8. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 17, 2023
  9. changed the title [-]Conversation - In group details page, plus options are shown[/-] [+][$500] Conversation - In group details page, plus options are shown[/+] on Oct 17, 2023
  10. melvin-bot commented on Oct 17, 2023

    @melvin-bot
  11. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 17, 2023
  12. 69 remaining items

  13. changed the title [-][HOLD for payment regression] [$500] Conversation - In group details page, plus options are shown[/-] [+][HOLD for payment 2023-12-28] [HOLD for payment regression] [$500] Conversation - In group details page, plus options are shown[/+] on Dec 21, 2023
  14. melvin-bot commented on Dec 21, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Dec 21, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-12-28. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

  16. melvin-bot commented on Dec 21, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
    • [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@eVoloshchak] Determine if we should create a regression test for this bug.
    • [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  17. JmillsExpensify commented on Jan 3, 2024

    @JmillsExpensify
    Contributor

    @eVoloshchak Mind completing the BZ checklist?

  18. eVoloshchak commented on Jan 3, 2024

    @eVoloshchak
    Contributor
    • The PR that introduced the bug has been identified. Link to the PR: there isn't a PR that caused this, this was caused by a race condition and reproducible only as an edge case
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: I don't think an additional discussion is needed, this is an edge case and the bug does not prevent users from using the app

    Regression Test Proposal

    1. Open any chat and upload a file bigger than 24 Mb. Dissmiss the popup error.
    2. Tap on the report header, verify the keyboard doesn't pop up
    3. Tap on the report header and quickly tap on plus icon, verify popover closes as soon user is navigated to details page
    4. Tap on the report header and quickly tap on emoji popover, verify popover closes as soon user is navigated to details page
    5. Tap the plus icon and quickly tap the header, verify popover closes as soon user is navigated to details page

    Do we agree 👍 or 👎

  19. JmillsExpensify commented on Jan 5, 2024

    @JmillsExpensify
    Contributor

    Thank you! Payment summary:

  20. JmillsExpensify commented on Jan 5, 2024

    @JmillsExpensify
    Contributor

    Contributor paid out and @eVoloshchak is paid via Expensify. Closing this issue!

  21. eVoloshchak commented on Jan 6, 2024

    @eVoloshchak
    Contributor

    @JmillsExpensify, there was a regression, shouldn't the payment be $250?

  22. JmillsExpensify commented on Jan 6, 2024

    @JmillsExpensify
    Contributor

    Oh thank you for your honesty! I'll update the payment summary above and request a refund on the contributor payment.

  23. JmillsExpensify commented on Jan 22, 2024

    @JmillsExpensify
    Contributor

    $250 payment approved for @eVoloshchak based on summary above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions