You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-12-28] [HOLD for payment regression] [$500] Conversation - In group details page, plus options are shown #29379
When Header is clicked and quickly the plus is clicked the plus option open in report details page
Root Cause
When we click the header there is a naviagtion delay in that moment if user clicks the plus button the popover will open and then navigation happens, there is no code specific root cause just a case not handled.
Changes
We can avoid opening of Plus button options when navigation is in progress. We can use withNavigationFocus HOC to get isFocused prop which tells if screen is not focused(navigating in progress)
changed the title [-]Conversation - In group details page, plus options are shown[/-][+][$500] Conversation - In group details page, plus options are shown[/+]on Oct 17, 2023
changed the title [-][HOLD for payment regression] [$500] Conversation - In group details page, plus options are shown[/-][+][HOLD for payment 2023-12-28] [HOLD for payment regression] [$500] Conversation - In group details page, plus options are shown[/+]on Dec 21, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-12-28. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
@eVoloshchak requires payment through NewDot Manual Requests
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
[@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@eVoloshchak] Determine if we should create a regression test for this bug.
[@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
The PR that introduced the bug has been identified. Link to the PR: there isn't a PR that caused this, this was caused by a race condition and reproducible only as an edge case
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: I don't think an additional discussion is needed, this is an edge case and the bug does not prevent users from using the app
Regression Test Proposal
Open any chat and upload a file bigger than 24 Mb. Dissmiss the popup error.
Tap on the report header, verify the keyboard doesn't pop up
Tap on the report header and quickly tap on plus icon, verify popover closes as soon user is navigated to details page
Tap on the report header and quickly tap on emoji popover, verify popover closes as soon user is navigated to details page
Tap the plus icon and quickly tap the header, verify popover closes as soon user is navigated to details page
Activity
melvin-bot commentedon Oct 11, 2023
Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Oct 11, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)ishpaul777 commentedon Oct 16, 2023
Proposal
Problem
When Header is clicked and quickly the plus is clicked the plus option open in report details page
Root Cause
When we click the header there is a naviagtion delay in that moment if user clicks the plus button the popover will open and then navigation happens, there is no code specific root cause just a case not handled.
Changes
We can avoid opening of Plus button options when navigation is in progress. We can use
withNavigationFocusHOC to getisFocusedprop which tells if screen is not focused(navigating in progress)https://github.com/Expensify/App/blob/5d9ac2ceda20f487c5b0772d976217525a95d547/src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.js
ans onPress of plus button we can early return if
isFoucusedisfalse, the same ^ needs to be implemented for Emojipicker Popover.melvin-bot commentedon Oct 17, 2023
@JmillsExpensify Eep! 4 days overdue now. Issues have feelings too...
JmillsExpensify commentedon Oct 17, 2023
Can we get a video for this one?
JmillsExpensify commentedon Oct 17, 2023
Regardless, triaging for review and more proposals.
[-]Conversation - In group details page, plus options are shown[/-][+][$500] Conversation - In group details page, plus options are shown[/+]melvin-bot commentedon Oct 17, 2023
Job added to Upwork: https://www.upwork.com/jobs/~016354d05fb227f48d
69 remaining items
[-][HOLD for payment regression] [$500] Conversation - In group details page, plus options are shown[/-][+][HOLD for payment 2023-12-28] [HOLD for payment regression] [$500] Conversation - In group details page, plus options are shown[/+]melvin-bot commentedon Dec 21, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Dec 21, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-12-28. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Dec 21, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
JmillsExpensify commentedon Jan 3, 2024
@eVoloshchak Mind completing the BZ checklist?
eVoloshchak commentedon Jan 3, 2024
Regression Test Proposal
Do we agree 👍 or 👎
JmillsExpensify commentedon Jan 5, 2024
Thank you! Payment summary:
JmillsExpensify commentedon Jan 5, 2024
Contributor paid out and @eVoloshchak is paid via Expensify. Closing this issue!
eVoloshchak commentedon Jan 6, 2024
@JmillsExpensify, there was a regression, shouldn't the payment be $250?
JmillsExpensify commentedon Jan 6, 2024
Oh thank you for your honesty! I'll update the payment summary above and request a refund on the contributor payment.
JmillsExpensify commentedon Jan 22, 2024
$250 payment approved for @eVoloshchak based on summary above.