Skip to content

[HOLD for payment 2023-11-02] [$125] Member list - Tooltip show phone number include "@expensify.sms" #29645

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.84-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697284170153569

Action Performed:

  1. Create a workspace
  2. Go to member and click invite
  3. Input invite account phone number "eg: +84989493033"
  4. Click next => Invite
  5. Hover onto the newly invited member's avatar, Observe that the phone number contains "@expensify.sms""

Expected Result:

Tooltip show does not include "@expensify.sms"

Actual Result:

Tooltip show phone number include "@expensify.sms"

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2023-10-14.at.17.48.36.1.mov

Snip - (8) New Expensify - Google Chrome

MacOS: Desktop

View all open jobs on GitHub

web.1.mov
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015beae79e8b315fdb
  • Upwork Job ID: 1713671640416272384
  • Last Price Increase: 2023-10-23

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 15, 2023
  2. changed the title [-]Member list - Tooltip show phone number include "@expensify.sms"[/-] [+][$500] Member list - Tooltip show phone number include "@expensify.sms"[/+] on Oct 15, 2023
  3. melvin-bot commented on Oct 15, 2023

    @melvin-bot

    Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. melvin-bot commented on Oct 15, 2023

    @melvin-bot
  5. melvin-bot commented on Oct 15, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 15, 2023
  7. melvin-bot commented on Oct 15, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

  8. m-natarajan commented on Oct 15, 2023

    @m-natarajan
    Author

    Proposal by @namhihi237

    Please re-state the problem that we are trying to solve in this issue.

    The tooltip shown does not include "@expensify.sms" on the member page, it should not include '@expensify.sms'

    What is the root cause of that problem?

    We have the logic to get the name to show the tooltip here:

    icons: [
    {
    source: UserUtils.getAvatar(details.avatar, accountID),
    name: details.login,
    type: CONST.ICON_TYPE_AVATAR,
    },
    ],

    But we don't format if the login is a phone number because it has the format "xxxxxx@expensify.sms"
    In addition, I also found the same error in TaskPreview, we previously fixed it but since we switched to using accountid here, the error has returned.
    const htmlForTaskPreview =
    taskAssignee && taskAssigneeAccountID !== 0
    ? `<comment><mention-user accountid="${taskAssigneeAccountID}">@${taskAssignee}</mention-user> ${taskTitle}</comment>`
    : `<comment>${taskTitle}</comment>`;

    But we haven't formatted the phone here:
    displayNameOrLogin = lodashGet(user, 'login', '') || lodashGet(user, 'displayName', '') || translate('common.hidden');

    What changes do you think we should make in order to solve the problem?

    We should use formatPhoneNumber to format the name

    1. In here
    name: props.formatPhoneNumber(details.login),
    1. And MentionUserRenderer
    displayNameOrLogin = LocalePhoneNumber.formatPhoneNumber(lodashGet(user, 'login', '')) || lodashGet(user, 'displayName', '') || translate('common.hidden');

    What alternative solutions did you explore? (Optional)

    N/Axqx

  9. saad995 commented on Oct 16, 2023

    @saad995

    Please re-state the problem that we are trying to solve in this issue.
    The tooltip shows "@expensify.sms" on the member page icon, it should not include '@expensify.sms'.

    What is the root cause of that problem?
    For the icon tooltip, we are not formatting the login name,
    image

    What changes do you think we should make in order to solve the problem?
    We can make use of the already defined function for formatting phone number, the change would look like this,
    image

  10. melvin-bot commented on Oct 19, 2023

    @melvin-bot

    @eVoloshchak, @miljakljajic Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  11. 25 remaining items

  12. melvin-bot commented on Oct 26, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Oct 26, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.91-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-11-02. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Oct 26, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
    • [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@eVoloshchak] Determine if we should create a regression test for this bug.
    • [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  15. miljakljajic commented on Nov 2, 2023

    @miljakljajic
    Contributor

    Sent @namhihi237 contract for reporting bonus, contributor payment + urgency bonus.

  16. miljakljajic commented on Nov 2, 2023

    @miljakljajic
    Contributor

    Paid, closing.

  17. eVoloshchak commented on Nov 2, 2023

    @eVoloshchak
    Contributor
    • The PR that introduced the bug has been identified. Link to the PR: Add New Default Workspace Avatars #15280
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/15280/files#r1380605892
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: this is a simple visual bug, I don't think an additional discussion is needed here
  18. eVoloshchak commented on Nov 2, 2023

    @eVoloshchak
    Contributor

    Regression Test Proposal

    1. Go to any workspace' settings ar create a new workspace
    2. Go to Members and click on Invite
    3. Paste a phone number "eg: +84989493033" and select it
    4. Click next => Invite
    5. Hover on the newly invited member's avatar, verify that the phone number does not contain "@expensify.sms"

    Do we agree 👍 or 👎

  19. eVoloshchak commented on Nov 2, 2023

    @eVoloshchak
    Contributor

    @miljakljajic, could you post a payment summary for this so I can request the payment on NewDot? Thanks

  20. eVoloshchak commented on Nov 6, 2023

    @eVoloshchak
    Contributor

    @miljakljajic, gentle bump on the above

  21. miljakljajic commented on Nov 7, 2023

    @miljakljajic
    Contributor

    @eVoloshchak is eligible for manual payments, listing the payment summary here:

    C+ role: 125 USD + 50% urgency bonus:

    187.5 USD owed

  22. JmillsExpensify commented on Nov 13, 2023

    @JmillsExpensify
    Contributor

    $187.50 payment approved for @eVoloshchak based on comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions