You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-11-02] [$125] Member list - Tooltip show phone number include "@expensify.sms" #29645
changed the title [-]Member list - Tooltip show phone number include "@expensify.sms"[/-][+][$500] Member list - Tooltip show phone number include "@expensify.sms"[/+]on Oct 15, 2023
But we don't format if the login is a phone number because it has the format "xxxxxx@expensify.sms"
In addition, I also found the same error in TaskPreview, we previously fixed it but since we switched to using accountid here, the error has returned.
Please re-state the problem that we are trying to solve in this issue.
The tooltip shows "@expensify.sms" on the member page icon, it should not include '@expensify.sms'.
What is the root cause of that problem?
For the icon tooltip, we are not formatting the login name,
What changes do you think we should make in order to solve the problem?
We can make use of the already defined function for formatting phone number, the change would look like this,
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.91-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-11-02. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
@eVoloshchakdoes not require payment (Eligible for Manual Requests)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
[@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@eVoloshchak] Determine if we should create a regression test for this bug.
[@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: this is a simple visual bug, I don't think an additional discussion is needed here
Activity
[-]Member list - Tooltip show phone number include "@expensify.sms"[/-][+][$500] Member list - Tooltip show phone number include "@expensify.sms"[/+]melvin-bot commentedon Oct 15, 2023
Triggered auto assignment to @miljakljajic (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Oct 15, 2023
Job added to Upwork: https://www.upwork.com/jobs/~015beae79e8b315fdb
melvin-bot commentedon Oct 15, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Oct 15, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (
External)m-natarajan commentedon Oct 15, 2023
Proposal by @namhihi237
Please re-state the problem that we are trying to solve in this issue.
The tooltip shown does not include "@expensify.sms" on the member page, it should not include '@expensify.sms'
What is the root cause of that problem?
We have the logic to get the name to show the tooltip here:
App/src/pages/workspace/WorkspaceMembersPage.js
Lines 331 to 337 in fe282b4
But we don't format if the login is a phone number because it has the format "xxxxxx@expensify.sms"
In addition, I also found the same error in TaskPreview, we previously fixed it but since we switched to using accountid here, the error has returned.
App/src/components/ReportActionItem/TaskPreview.js
Lines 79 to 82 in fe282b4
But we haven't formatted the phone here:
App/src/components/HTMLEngineProvider/HTMLRenderers/MentionUserRenderer.js
Line 43 in fe282b4
What changes do you think we should make in order to solve the problem?
We should use
formatPhoneNumberto format the nameWhat alternative solutions did you explore? (Optional)
N/Axqx
saad995 commentedon Oct 16, 2023
Please re-state the problem that we are trying to solve in this issue.
The tooltip shows "@expensify.sms" on the member page icon, it should not include '@expensify.sms'.
What is the root cause of that problem?

For the icon tooltip, we are not formatting the login name,
What changes do you think we should make in order to solve the problem?

We can make use of the already defined function for formatting phone number, the change would look like this,
melvin-bot commentedon Oct 19, 2023
@eVoloshchak, @miljakljajic Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
25 remaining items
melvin-bot commentedon Oct 26, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 26, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.91-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-11-02. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Oct 26, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
miljakljajic commentedon Nov 2, 2023
Sent @namhihi237 contract for reporting bonus, contributor payment + urgency bonus.
miljakljajic commentedon Nov 2, 2023
Paid, closing.
eVoloshchak commentedon Nov 2, 2023
eVoloshchak commentedon Nov 2, 2023
Regression Test Proposal
Membersand click onInviteDo we agree 👍 or 👎
eVoloshchak commentedon Nov 2, 2023
@miljakljajic, could you post a payment summary for this so I can request the payment on NewDot? Thanks
eVoloshchak commentedon Nov 6, 2023
@miljakljajic, gentle bump on the above
miljakljajic commentedon Nov 7, 2023
@eVoloshchak is eligible for manual payments, listing the payment summary here:
C+ role: 125 USD + 50% urgency bonus:
187.5 USD owed
JmillsExpensify commentedon Nov 13, 2023
$187.50 payment approved for @eVoloshchak based on comment above.