Skip to content

[HOLD for payment 2023-10-27] [P2P Activation] Adding a bank account while enabling an Expensify Wallet drops you in the Wallet page rather than continuing the enablement flow #29726

Closed

Description

@isagoico

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.3.85-0
Reproducible in staging?: Yes
Reproducible in production?: Unknown
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): N/A
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @kevinksullivan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697492929166339

Action Performed:

User A:

  1. Select Request money
  2. User A: enter User B as the person you're requesting from

User B:

  1. Login
  2. Navigate to the IOU report
  3. Select Pay with Expensify
  4. Select Bank account
  5. Add a personal bank account

Expected Result:

The user should land on the Additional details page to continue the Wallet enablement flow, which asks them for personal information.

Actual Result:

The user lands on the wallet page , and has to go back and select Pay again.

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Note: the first screen shows the prompt to add a bank account or debit card when selecting Pay with Expensify , and the second screenshot shows where you're brought after adding the account.

bank.Account.wallet.mp4

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 16, 2023
  2. melvin-bot commented on Oct 16, 2023

    @melvin-bot

    Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Oct 16, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. changed the title [-]Adding a bank account while enabling an Expensify Wallet drops you in the Wallet page rather than continuing the enablement flow[/-] [+][P2P Activation] Adding a bank account while enabling an Expensify Wallet drops you in the Wallet page rather than continuing the enablement flow[/+] on Oct 17, 2023
  5. MariaHCD commented on Oct 17, 2023

    @MariaHCD
    Contributor
  6. getusha commented on Oct 17, 2023

    @getusha
    Contributor
    Screenshot 2023-10-17 at 4 50 00 PM

    @MariaHCD facing this error, is this something known?

  7. MariaHCD commented on Oct 17, 2023

    @MariaHCD
    Contributor

    Ah, yes, we throttle users when adding bank accounts via Plaid 😅 I think testing with another account will work.

  8. abdulrahuman5196 commented on Oct 18, 2023

    @abdulrahuman5196
    Contributor

    Kindly assign me this GH for C+ review.

  9. 3 remaining items

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Oct 20, 2023
  11. changed the title [-][P2P Activation] Adding a bank account while enabling an Expensify Wallet drops you in the Wallet page rather than continuing the enablement flow[/-] [+][HOLD for payment 2023-10-27] [P2P Activation] Adding a bank account while enabling an Expensify Wallet drops you in the Wallet page rather than continuing the enablement flow[/+] on Oct 20, 2023
  12. melvin-bot commented on Oct 20, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Oct 20, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.87-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-10-27. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  14. melvin-bot commented on Oct 20, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
    • [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@abdulrahuman5196] Determine if we should create a regression test for this bug.
    • [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  15. bfitzexpensify commented on Oct 27, 2023

    @bfitzexpensify
    Contributor

    Offers sent @abdulrahuman5196 @getusha.

    Also a reminder to complete the BZ checklist @abdulrahuman5196 - thank you!

  16. getusha commented on Oct 27, 2023

    @getusha
    Contributor

    @bfitzexpensify Accepted thanks!

  17. abdulrahuman5196 commented on Oct 27, 2023

    @abdulrahuman5196
    Contributor

    The PR that introduced the bug has been identified. Link to the PR:
    The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    Not a regression but a new expectation.

    Determine if we should create a regression test for this bug.

    Yes.

    If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    1. Navigate to the IOU report
    2. Select Pay with Expensify
    3. Select Bank account
    4. Add a personal bank account
    5. Choose account from drop down menu and click Save & continue > Continue
    6. Verify that Additional details page is opened.

    @bfitzexpensify Accepted the offer and checklist complete.

  18. bfitzexpensify commented on Oct 27, 2023

    @bfitzexpensify
    Contributor

    Great, those steps look good to me. I opened https://github.com/Expensify/Expensify/issues/330782 for the regression test.

    All payments complete, we're all done here - thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions