You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-27] [P2P Activation] Adding a bank account while enabling an Expensify Wallet drops you in the Wallet page rather than continuing the enablement flow #29726
User A: enter User B as the person you're requesting from
User B:
Login
Navigate to the IOU report
Select Pay with Expensify
Select Bank account
Add a personal bank account
Expected Result:
The user should land on the Additional details page to continue the Wallet enablement flow, which asks them for personal information.
Actual Result:
The user lands on the wallet page , and has to go back and select Pay again.
Workaround:
N/A
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Note: the first screen shows the prompt to add a bank account or debit card when selecting Pay with Expensify , and the second screenshot shows where you're brought after adding the account.
changed the title [-]Adding a bank account while enabling an Expensify Wallet drops you in the Wallet page rather than continuing the enablement flow[/-][+][P2P Activation] Adding a bank account while enabling an Expensify Wallet drops you in the Wallet page rather than continuing the enablement flow[/+]on Oct 17, 2023
changed the title [-][P2P Activation] Adding a bank account while enabling an Expensify Wallet drops you in the Wallet page rather than continuing the enablement flow[/-][+][HOLD for payment 2023-10-27] [P2P Activation] Adding a bank account while enabling an Expensify Wallet drops you in the Wallet page rather than continuing the enablement flow[/+]on Oct 20, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.87-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-27. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
[@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@abdulrahuman5196] Determine if we should create a regression test for this bug.
[@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
Not a regression but a new expectation.
Determine if we should create a regression test for this bug.
Yes.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Navigate to the IOU report
Select Pay with Expensify
Select Bank account
Add a personal bank account
Choose account from drop down menu and click Save & continue > Continue
Activity
melvin-bot commentedon Oct 16, 2023
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Oct 16, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)[-]Adding a bank account while enabling an Expensify Wallet drops you in the Wallet page rather than continuing the enablement flow[/-][+][P2P Activation] Adding a bank account while enabling an Expensify Wallet drops you in the Wallet page rather than continuing the enablement flow[/+]MariaHCD commentedon Oct 17, 2023
@getusha has offered to take a look at this one! 🙏🏼
https://expensify.slack.com/archives/C01GTK53T8Q/p1697547375338189?thread_ts=1697033275.944009&cid=C01GTK53T8Q
getusha commentedon Oct 17, 2023
@MariaHCD facing this error, is this something known?
MariaHCD commentedon Oct 17, 2023
Ah, yes, we throttle users when adding bank accounts via Plaid 😅 I think testing with another account will work.
MariaHCD commentedon Oct 17, 2023
Do let me know if there is overlap with https://github.com/Expensify/App/pull/29573/files#diff-186ee6dd4f2074460e09890d51b9ef7ef11bc902c32e472b58b76a060a3e4d63R367
abdulrahuman5196 commentedon Oct 18, 2023
Kindly assign me this GH for C+ review.
3 remaining items
[-][P2P Activation] Adding a bank account while enabling an Expensify Wallet drops you in the Wallet page rather than continuing the enablement flow[/-][+][HOLD for payment 2023-10-27] [P2P Activation] Adding a bank account while enabling an Expensify Wallet drops you in the Wallet page rather than continuing the enablement flow[/+]melvin-bot commentedon Oct 20, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 20, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.87-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-27. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Oct 20, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
bfitzexpensify commentedon Oct 27, 2023
Offers sent @abdulrahuman5196 @getusha.
Also a reminder to complete the BZ checklist @abdulrahuman5196 - thank you!
getusha commentedon Oct 27, 2023
@bfitzexpensify Accepted thanks!
abdulrahuman5196 commentedon Oct 27, 2023
Not a regression but a new expectation.
Yes.
@bfitzexpensify Accepted the offer and checklist complete.
bfitzexpensify commentedon Oct 27, 2023
Great, those steps look good to me. I opened https://github.com/Expensify/Expensify/issues/330782 for the regression test.
All payments complete, we're all done here - thanks everyone!