Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v1.3.84-4
Reproducible in staging?: Yes
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: (internal ref) https://expensify.slack.com/archives/C02NZ2HGJAZ/p1697493830052679?thread_ts=1697488517.137999&cid=C02NZ2HGJAZ
Action Performed:
- Global create > Request money > scan a picture of your receipt or a image file that will fail
- Select 2 participants to split > confirm
- Wait for receipt scanning to fail
Observe the split preview component in the groupDM contains a red dot that's left-alignedbeing fixed here- Observe the groupDM chat in the LHN does not have a red dot on the chat row
- Observe we're showing
Split $0.00in the LHN preview message instead ofReceipt missing detailswhen a split scan fails
Expected Result:
The red dot for the "RBR" (red-brick-road) in a preview component should be right-aligned being fixed here.
The chat row in the LHN should have a RBR red dot
The LHN preview message shows Receipt missing details not Split $0.00 when a split scan fails
Actual Result:
The red dot on the preview component is left-aligned and the chat row does not have a red dot
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
N/A
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Desktop
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01fdff9c9cc073642c
- Upwork Job ID: 1714068202452070400
- Last Price Increase: 2023-11-09
- Automatic offers:
- Ollyws | Reviewer | 27613990
- dukenv0307 | Contributor | 27613993

Activity
melvin-bot commentedon Oct 16, 2023
Current assignee @youssef-lr is eligible for the Engineering assigner, not assigning anyone new.
melvin-bot commentedon Oct 16, 2023
Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.
melvin-bot commentedon Oct 16, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Oct 16, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01fdff9c9cc073642c
melvin-bot commentedon Oct 16, 2023
Triggered auto assignment to Contributor Plus for review of internal employee PR - @Ollyws (
Internal)trjExpensify commentedon Oct 17, 2023
Same here @youssef-lr assigning this one to us for now, as I know you were working on the handling of the failure case. Equally, can you confirm if the updates coming will have
Receipt missing detailsin the LHN preview message instead ofSplit $0.00when it fails or do we need to take care of that here?youssef-lr commentedon Oct 17, 2023
Nope not included, I'll fix it as part of this issue!
trjExpensify commentedon Oct 17, 2023
Perfect, thanks!
60 remaining items
[-][$500] RBR polish on failed split receipt scans [/-][+][HOLD for payment 2023-12-18] [$500] RBR polish on failed split receipt scans [/+]melvin-bot commentedon Dec 11, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Dec 11, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.10-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-12-18. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Dec 11, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
trjExpensify commentedon Dec 18, 2023
👋 checklist time please!
Ollyws commentedon Dec 18, 2023
BugZero Checklist:
This was a new feature so no PR is responsible.
N/A
N/A
I don't think a regression test is really helpful here as it takes a long time to test for (while waiting for the recepit scan to fail) and doesn't affect the flow in any significant way.
trjExpensify commentedon Dec 20, 2023
That isn't a good reason in itself, really. A customer has the same experience and we need to make sure it works for them! We have failed scan receipt regression tests, so all good.
As for the payments then, confirming as follows?
Let me know and I'll settle up tomorrow!
trjExpensify commentedon Dec 20, 2023
Settled up, closing!