Skip to content

[HOLD for payment 2023-12-18] [$500] RBR polish on failed split receipt scans  #29733

Closed

Description

@trjExpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.3.84-4
Reproducible in staging?: Yes
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: (internal ref) https://expensify.slack.com/archives/C02NZ2HGJAZ/p1697493830052679?thread_ts=1697488517.137999&cid=C02NZ2HGJAZ

Action Performed:

  1. Global create > Request money > scan a picture of your receipt or a image file that will fail
  2. Select 2 participants to split > confirm
  3. Wait for receipt scanning to fail
  4. Observe the split preview component in the groupDM contains a red dot that's left-aligned being fixed here
  5. Observe the groupDM chat in the LHN does not have a red dot on the chat row
  6. Observe we're showing Split $0.00 in the LHN preview message instead of Receipt missing details when a split scan fails

Expected Result:

The red dot for the "RBR" (red-brick-road) in a preview component should be right-aligned being fixed here.
The chat row in the LHN should have a RBR red dot
The LHN preview message shows Receipt missing details not Split $0.00 when a split scan fails

Actual Result:

The red dot on the preview component is left-aligned and the chat row does not have a red dot

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari image
MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01fdff9c9cc073642c
  • Upwork Job ID: 1714068202452070400
  • Last Price Increase: 2023-11-09
  • Automatic offers:
    • Ollyws | Reviewer | 27613990
    • dukenv0307 | Contributor | 27613993

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 16, 2023
  2. melvin-bot commented on Oct 16, 2023

    @melvin-bot

    Current assignee @youssef-lr is eligible for the Engineering assigner, not assigning anyone new.

  3. melvin-bot commented on Oct 16, 2023

    @melvin-bot

    Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

  4. melvin-bot commented on Oct 16, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  5. melvin-bot commented on Oct 16, 2023

    @melvin-bot
  6. melvin-bot commented on Oct 16, 2023

    @melvin-bot

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @Ollyws (Internal)

  7. trjExpensify commented on Oct 17, 2023

    @trjExpensify
    ContributorAuthor

    Same here @youssef-lr assigning this one to us for now, as I know you were working on the handling of the failure case. Equally, can you confirm if the updates coming will have Receipt missing details in the LHN preview message instead of Split $0.00 when it fails or do we need to take care of that here?

  8. youssef-lr commented on Oct 17, 2023

    @youssef-lr
    Contributor

    can you confirm if the updates coming will have Receipt missing details in the LHN preview message instead of Split $0.00 when it fails or do we need to take care of that here?

    Nope not included, I'll fix it as part of this issue!

  9. trjExpensify commented on Oct 17, 2023

    @trjExpensify
    ContributorAuthor

    Perfect, thanks!

  10. 60 remaining items

  11. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Dec 11, 2023
  12. changed the title [-][$500] RBR polish on failed split receipt scans [/-] [+][HOLD for payment 2023-12-18] [$500] RBR polish on failed split receipt scans [/+] on Dec 11, 2023
  13. melvin-bot commented on Dec 11, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Dec 11, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.10-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-12-18. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

  15. melvin-bot commented on Dec 11, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
    • [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@Ollyws] Determine if we should create a regression test for this bug.
    • [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  16. trjExpensify commented on Dec 18, 2023

    @trjExpensify
    ContributorAuthor

    👋 checklist time please!

  17. Ollyws commented on Dec 18, 2023

    @Ollyws
    Contributor

    BugZero Checklist:

    • The PR that introduced the bug has been identified. Link to the PR:

    This was a new feature so no PR is responsible.

    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

    N/A

    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    N/A

    • Determine if we should create a regression test for this bug.

    I don't think a regression test is really helpful here as it takes a long time to test for (while waiting for the recepit scan to fail) and doesn't affect the flow in any significant way.

  18. trjExpensify commented on Dec 20, 2023

    @trjExpensify
    ContributorAuthor

    I don't think a regression test is really helpful here as it takes a long time to test for (while waiting for the recepit scan to fail) and doesn't affect the flow in any significant way.

    That isn't a good reason in itself, really. A customer has the same experience and we need to make sure it works for them! We have failed scan receipt regression tests, so all good.

    As for the payments then, confirming as follows?

    Let me know and I'll settle up tomorrow!

  19. trjExpensify commented on Dec 20, 2023

    @trjExpensify
    ContributorAuthor

    Settled up, closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions