You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-01-17] [$500] Android - Request money - Currency list flashes briefly when opening currency list #29780
changed the title [-] Android - Request money - Currency list flashes briefly when opening currency list[/-][+][$500] Android - Request money - Currency list flashes briefly when opening currency list[/+]on Oct 17, 2023
I propose wrapping only SectionList in the view and passing prepared styles there
@barttom That's already my suggestion in #29780 (comment) , there is no need to wrap the whole section list in a new view we can just pass the styles to the section list.
changed the title [-][$500] Android - Request money - Currency list flashes briefly when opening currency list[/-][+][HOLD for payment 2024-01-17] [$500] Android - Request money - Currency list flashes briefly when opening currency list[/+]on Jan 10, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.23-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
[@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@fedirjh] Determine if we should create a regression test for this bug.
[@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Link to the PR: I don't believe this is related to any recent PR. It doesn't appear to be a regression. There is no evidence of a PR that could have caused this issue.
Link to comment: N/A
Link to discussion: N/A
Determine if we should create a regression test for this bug: N/A This is not worth a regression test, it's a little UI improvement, the bug doesn’t affect the user experience.
Activity
[-] Android - Request money - Currency list flashes briefly when opening currency list[/-][+][$500] Android - Request money - Currency list flashes briefly when opening currency list[/+]melvin-bot commentedon Oct 17, 2023
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Oct 17, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01937182f6afc52c43
melvin-bot commentedon Oct 17, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Oct 17, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (
External)abekkala commentedon Oct 20, 2023
I'll give this another day-2 for proposals and I'll bring to CS or SWM
96 remaining items
fedirjh commentedon Dec 28, 2023
@barttom That's already my suggestion in #29780 (comment) , there is no need to wrap the whole section list in a new view we can just pass the styles to the section list.
[-][$500] Android - Request money - Currency list flashes briefly when opening currency list[/-][+][HOLD for payment 2024-01-17] [$500] Android - Request money - Currency list flashes briefly when opening currency list[/+]melvin-bot commentedon Jan 10, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 10, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.23-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-17. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 10, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
abekkala commentedon Jan 17, 2024
Issue reported by: Applause - Internal Team
Fix: @barttom does not require payment (Callstack)
PR Review: @fedirjh offer
@fedirjh can you complete the checklist above, I can then process payment in Upwork
fedirjh commentedon Jan 24, 2024
BugZero Checklist:
abekkala commentedon Jan 24, 2024
@fedirjh payment sent and contract ended - thank you! 🎉