Skip to content

[HOLD for payment 2024-01-17] [$500] Android - Request money - Currency list flashes briefly when opening currency list #29780

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.85-0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to + > Request money > Manual
  3. Tap on the currency

Expected Result:

The currency list will not flash

Actual Result:

The currency list flashes briefly

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Bug6240571_1697551012172.Screen_Recording_20231017_191736_New_Expensify__1_.mp4
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01937182f6afc52c43
  • Upwork Job ID: 1714287345950720000
  • Last Price Increase: 2023-10-31
  • Automatic offers:
    • fedirjh | Reviewer | 27488223

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 17, 2023
  2. changed the title [-] Android - Request money - Currency list flashes briefly when opening currency list[/-] [+][$500] Android - Request money - Currency list flashes briefly when opening currency list[/+] on Oct 17, 2023
  3. melvin-bot commented on Oct 17, 2023

    @melvin-bot

    Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. melvin-bot commented on Oct 17, 2023

    @melvin-bot
  5. melvin-bot commented on Oct 17, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 17, 2023
  7. melvin-bot commented on Oct 17, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

  8. abekkala commented on Oct 20, 2023

    @abekkala
    Contributor

    I'll give this another day-2 for proposals and I'll bring to CS or SWM

  9. 96 remaining items

  10. fedirjh commented on Dec 28, 2023

    @fedirjh
    Contributor

    I propose wrapping only SectionList in the view and passing prepared styles there

    @barttom That's already my suggestion in #29780 (comment) , there is no need to wrap the whole section list in a new view we can just pass the styles to the section list.

  11. changed the title [-][$500] Android - Request money - Currency list flashes briefly when opening currency list[/-] [+][HOLD for payment 2024-01-17] [$500] Android - Request money - Currency list flashes briefly when opening currency list[/+] on Jan 10, 2024
  12. melvin-bot commented on Jan 10, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Jan 10, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.23-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-01-17. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Jan 10, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
    • [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@fedirjh] Determine if we should create a regression test for this bug.
    • [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  15. abekkala commented on Jan 17, 2024

    @abekkala
    Contributor

    Issue reported by: Applause - Internal Team
    Fix: @barttom does not require payment (Callstack)
    PR Review: @fedirjh offer

    @fedirjh can you complete the checklist above, I can then process payment in Upwork

  16. fedirjh commented on Jan 24, 2024

    @fedirjh
    Contributor

    BugZero Checklist:

    • Link to the PR: I don't believe this is related to any recent PR. It doesn't appear to be a regression. There is no evidence of a PR that could have caused this issue.
    • Link to comment: N/A
    • Link to discussion: N/A
    • Determine if we should create a regression test for this bug: N/A This is not worth a regression test, it's a little UI improvement, the bug doesn’t affect the user experience.
  17. abekkala commented on Jan 24, 2024

    @abekkala
    Contributor

    @fedirjh payment sent and contract ended - thank you! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions