You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-11-13] [$500] IOU - Copy to clipboard paid IOU in IOU page, instead of paid text requested text shown #29878
reportAction is not up to date and is not getting the latest reportAction instead is reading the previous reportAction.
We can see the current latest report action contains the correct originalMessage type hence gets the correct message.
Things work perfectly fine for ReportActionItem because it is getting the current correct prop.
What changes do you think we should make in order to solve the problem?
I just identified the root cause and wanted to bring forth my discoveries for what its worth. Still didn't know why it is not getting the latest reportAction props.
What alternative solutions did you explore? (Optional)
changed the title [-]IOU - Copy to clipboard paid IOU in IOU page, instead of paid text requested text shown[/-][+][$500] IOU - Copy to clipboard paid IOU in IOU page, instead of paid text requested text shown[/+]on Oct 20, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.95-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-11-13. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
[@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@Ollyws] Determine if we should create a regression test for this bug.
[@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
The PR that introduced the bug has been identified. Link to the PR:
I don't think we can really call this a regression from any PR as the we never had copy functionality for the IOU preview before #24630 was implemented, which unearthed this issue.
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
N/A
Determine if we should create a regression test for this bug.
I don't think a regression test would be helpful for this one as it's not very impactful nor does it affect the flow in any significant way.
Activity
melvin-bot commentedon Oct 18, 2023
Triggered auto assignment to @MitchExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Oct 18, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)dukenv0307 commentedon Oct 19, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Copy to clipboard paid IOU in IOU page, instead of paid text requested text shown
What is the root cause of that problem?
if
originalMessageofMoneyRequestActionhas type isn'tpay, we always returniou.requestedAmountwithout checking it's paid or notApp/src/libs/ReportUtils.js
Lines 3911 to 3915 in 229cb5d
What changes do you think we should make in order to solve the problem?
For this case we should check if the request is paid or not we will return the display message accordingly
For the case the request is paid, we can create a new translation key to display more information about the request i.e.
comment, ...App/src/libs/ReportUtils.js
Lines 3911 to 3915 in 229cb5d
What alternative solutions did you explore? (Optional)
Nathan-Mulugeta commentedon Oct 19, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
"Request" message is being shown instead of "paid" message when copying from the iou preview component.
What is the root cause of that problem?
The root cause of this issue is here:
App/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.js
Lines 57 to 62 in 69ad7bd
reportActionis not up to date and is not getting the latest reportAction instead is reading the previous reportAction.We can see the current latest report action contains the correct originalMessage type hence gets the correct message.
Things work perfectly fine for
ReportActionItembecause it is getting the current correct prop.What changes do you think we should make in order to solve the problem?
I just identified the root cause and wanted to bring forth my discoveries for what its worth. Still didn't know why it is not getting the latest reportAction props.
What alternative solutions did you explore? (Optional)
[-]IOU - Copy to clipboard paid IOU in IOU page, instead of paid text requested text shown[/-][+][$500] IOU - Copy to clipboard paid IOU in IOU page, instead of paid text requested text shown[/+]melvin-bot commentedon Oct 20, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01ee91e1d5782ad7bf
melvin-bot commentedon Oct 20, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (
External)18 remaining items
melvin-bot commentedon Nov 6, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.95-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-11-13. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 6, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
MitchExpensify commentedon Nov 7, 2023
Payment summary:
$500 @Ollyws requires payment
$500 @dukenv0307 requires payment
MitchExpensify commentedon Nov 14, 2023
Invited you both to the Upwork, job @dukenv0307 @Ollyws - Lemme know when you accept to issue payment 🙇
dukenv0307 commentedon Nov 15, 2023
@MitchExpensify accepted, thank you!
Ollyws commentedon Nov 15, 2023
BugZero Checklist:
I don't think we can really call this a regression from any PR as the we never had copy functionality for the IOU preview before #24630 was implemented, which unearthed this issue.
N/A
N/A
I don't think a regression test would be helpful for this one as it's not very impactful nor does it affect the flow in any significant way.
MitchExpensify commentedon Nov 16, 2023
Paid and contracts ended, thanks everyone!